New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777996 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Add unit tests for UiInputManager

Project Member Reported by cjgrant@chromium.org, Oct 24 2017

Issue description

UiInputManager needs refactoring to handle deletion of UI elements between frames.

As part of that rework, we should have tests for UiInputManager.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7e87211aa02c337795f9260705c47d8a277e5b

commit 8c7e87211aa02c337795f9260705c47d8a277e5b
Author: Christopher Grant <cjgrant@chromium.org>
Date: Wed Oct 25 20:50:22 2017

VR: Add UI input manager unit tests for hover and click.

This change does not test scrolling for fling.

Also, it fixes bugs whereby, when pressing the button and moving from one
element to another, then releasing the button, hover events were not delivered
to either the old or new element.  The problem was masked by having subsequent
calls to InputManager flush this state.

Bug= 777996 

Change-Id: Ifa91c8c415ff9b26ab2477c195f20d6def4da9b5
Reviewed-on: https://chromium-review.googlesource.com/736389
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511578}
[modify] https://crrev.com/8c7e87211aa02c337795f9260705c47d8a277e5b/chrome/browser/vr/test/constants.h
[modify] https://crrev.com/8c7e87211aa02c337795f9260705c47d8a277e5b/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/8c7e87211aa02c337795f9260705c47d8a277e5b/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/8c7e87211aa02c337795f9260705c47d8a277e5b/chrome/browser/vr/ui_input_manager_unittest.cc

Status: Available (was: Started)
Test have been added for hover, move and click.

We should still have tests for scroll and fling.
Owner: ----
Owner: acondor@chromium.org
Status: Started (was: Available)
Aldo's adding such tests now alongside an input manager change; assigning.
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15a5770f2ac6cf71399cecf2bd0870353b4e48b8

commit 15a5770f2ac6cf71399cecf2bd0870353b4e48b8
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Wed May 09 20:04:20 2018

VR: tests for scroll handling in UiInputManager

Bug:  777996 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: If13acb466acee907750147164613f31929c03b96
Reviewed-on: https://chromium-review.googlesource.com/1052370
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557290}
[modify] https://crrev.com/15a5770f2ac6cf71399cecf2bd0870353b4e48b8/chrome/browser/vr/ui_input_manager_unittest.cc

Status: Fixed (was: Started)
Labels: M-68 Test-Complete

Sign in to add a comment