ARC apps can be triggered even when using "Open in a new tab/window" |
|||||||
Issue descriptionARC apps shouldn't be triggered when the user selects either "Open in a new tab" or "open in a new window". PlzNavigate (now enabled by default) adds paths that we didn't consider while plumbing the flag telling whether the navigation was started from a context menu or not, we need to correctly pass the flag and add a test for this since it may get broken again.
,
Oct 27 2017
Tested on 10071 caroline, asking for Merge to M63
,
Oct 27 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 27 2017
Hi gkihumba@, could you please take a look at this?
,
Oct 27 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28a58cdd43499bd412a3146a733f570133be8daa commit 28a58cdd43499bd412a3146a733f570133be8daa Author: David Jacobo <djacobo@chromium.org> Date: Fri Oct 27 20:38:49 2017 Add context menu flag to CommonNavigationParams Plumbing started_from_context_menu to CommonNavigationParams so it can be correctly seen by ArcNavigationThrottle even when PlzNavigate is enabled by default. Bug: 777990 Test: Try. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I969edbb39d0d12d2a4a6d7d26a2ef4e3d72a7b7a Reviewed-on: https://chromium-review.googlesource.com/736310 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511332}(cherry picked from commit 7508e0b389ba961001e69c5ce18984c8aadea449) Reviewed-on: https://chromium-review.googlesource.com/742385 Reviewed-by: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#275} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/components/renderer_context_menu/render_view_context_menu_base.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/browser/browser_side_navigation_browsertest.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/browser/frame_host/navigation_entry_impl.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/common/navigation_params.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/common/navigation_params.h [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/public/test/render_view_test.cc [modify] https://crrev.com/28a58cdd43499bd412a3146a733f570133be8daa/content/renderer/render_frame_impl.cc
,
Feb 21 2018
I'm assuming this is fixed |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 25 2017