New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777982 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR

Blocking:
issue 773754



Sign in to add a comment

Speech recognition stopped working after a force stop

Project Member Reported by bshe@chromium.org, Oct 24 2017

Issue description

Steps:
1. Start speech recognition while in VR
2. Stop it before recognition start
3. Start speech recognition again
4. say any word (e.g. "cat")

expected: the word should be recognized

However, the result never comes back.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/346df7a1910034e3cfe0c633cc54d9f10f420fd7

commit 346df7a1910034e3cfe0c633cc54d9f10f420fd7
Author: Biao She <bshe@chromium.org>
Date: Tue Oct 24 23:21:38 2017

Use a new SpeechRecognizer weak ptr for a new speech recognition session

Previously, SROnIO has a weak ptr to SR and never update it. This becomes
a problem whenever SpeechRecognizer::Stop is called. All existing weak ptr
became invalid after the call (including the one that SROnIO has). So if
we call SpeechRecognizer::Start again. SROnIO won't call back to SR due to
invalid weak ptr.

This patch passes a new SR weak ptr in the SpeechRecognizerOnIO::Start
function. So that SROnIO don't try to use invalid weak ptr.

Bug:  777982 
Change-Id: I8ce26d38105f2d76d5d0575edeb382612b13844e
Reviewed-on: https://chromium-review.googlesource.com/736239
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511298}
[modify] https://crrev.com/346df7a1910034e3cfe0c633cc54d9f10f420fd7/chrome/browser/vr/speech_recognizer.cc
[modify] https://crrev.com/346df7a1910034e3cfe0c633cc54d9f10f420fd7/chrome/browser/vr/speech_recognizer_unittest.cc

Comment 2 by ymalik@chromium.org, Oct 31 2017

Status: Fixed (was: Started)

Sign in to add a comment