New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777968 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Call to action label jumps to the trailing side after screen reloads

Project Member Reported by mahmadi@chromium.org, Oct 24 2017

Issue description

The call to action labels jumps to the trailing side after the screen reloads. To reproduce:

(1) Go to paymentrequest.show/demo
(2) Check the shipping checkbox and tap "BUY NOW".
(3) Go to the shipping address selection screen. Select any shipping address.
(4) Observe that the "Add Address" label jumps to the trailing side after the screen refreshes.


 
jumpy.gif
748 KB View Download
Cc: macourteau@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb304828d16e5bbbfe2ad81d6881eb2dc2f9367e

commit fb304828d16e5bbbfe2ad81d6881eb2dc2f9367e
Author: Mohamad Ahmadi <mahmadi@chromium.org>
Date: Wed Oct 25 14:43:24 2017

[PR] width/height constraints for leading/trailing images of PaymentsTextCell

 - Widths and heights of the UIImageViews won't be ambiguous anymore and
   and therefore the labels are displayed correctly.

Bug:  777968 
Change-Id: I533d7b69f7e0e21ca7a421468a9a13bf3169ce35
Reviewed-on: https://chromium-review.googlesource.com/736143
Reviewed-by: Marc-Antoine Courteau <macourteau@chromium.org>
Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511454}
[modify] https://crrev.com/fb304828d16e5bbbfe2ad81d6881eb2dc2f9367e/ios/chrome/browser/ui/payments/cells/payments_text_item.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 64.0.3254.0 Canary, iPhone 8 iOS 11.0.3, iPhone 7 iOS11, 
"Add Shipping Address" label is not jumping anymore.
Looks good

Sign in to add a comment