New issue
Advanced search Search tips

Issue 777962 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 778306



Sign in to add a comment

Reader Mode for Accessibility

Project Member Reported by wychen@chromium.org, Oct 24 2017

Issue description

The Reader Mode infobar currently only shows up on non-mobile-friendly long-form articles. For accessibility users, one toggle in the Settings > Accessibility page can make it available on mobile-friendly long-form articles as well.

This feature is not complete yet. To try the triggering logic in the final stage, choose "All articles" in the chrome://flags#reader-mode-heuristics.
 

Comment 1 by wychen@chromium.org, Oct 24 2017

The following CL is related:

commit 80683458629e16a2d1d8f1ece7108ae3abb47c77
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date:   Mon Oct 2 19:08:25 2017 +0000

    Add setting UI to toggle Reader Mode for Accessibility
    
    The user-facing name is "Simplified View".
    
    Bug:
    Change-Id: I50aff7a3e6d936c7f3277a8f378ab7b4ac28db7a
    Reviewed-on: https://chromium-review.googlesource.com/691160
    Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#505708}

 chrome/android/java/res/xml/accessibility_preferences.xml                                     |  7 ++++++-
 chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java                    |  1 +
 chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java            |  7 ++++++-
 chrome/android/java/src/org/chromium/chrome/browser/preferences/AccessibilityPreferences.java |  9 +++++++++
 chrome/android/java/strings/android_chrome_strings.grd                                        | 11 ++++++++++-
 chrome/browser/about_flags.cc                                                                 | 11 +++++++++--
 chrome/browser/android/chrome_feature_list.cc                                                 |  4 ++++
 chrome/browser/android/chrome_feature_list.h                                                  |  1 +
 chrome/browser/flag_descriptions.cc                                                           |  4 ++++
 chrome/browser/flag_descriptions.h                                                            |  3 +++
 tools/metrics/histograms/enums.xml                                                            |  2 ++
 11 files changed, 55 insertions(+), 5 deletions(-)

Comment 2 by k...@chromium.org, Oct 25 2017

Blocking: 778306
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a12df44bb668da56c00c939355b2c79442bb6d0

commit 2a12df44bb668da56c00c939355b2c79442bb6d0
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Wed Oct 25 23:17:49 2017

Update the strings about simplified view

Update the string on the simplified view infobar, and also unify
the capitalization of strings about simplified view.

Bug: 777962
Change-Id: I654c53ac41ed35c74de2cb5a887ab3a94506e828
Reviewed-on: https://chromium-review.googlesource.com/737462
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511633}
[modify] https://crrev.com/2a12df44bb668da56c00c939355b2c79442bb6d0/chrome/android/java/strings/android_chrome_strings.grd

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d174a525391c53028e3c5b53496f0e0f26e30219

commit d174a525391c53028e3c5b53496f0e0f26e30219
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Fri Oct 27 02:49:04 2017

Save Reader Mode for Accessibility preference

The setting UI to toggle Reader Mode for Accessibility is now saved
in the preference. The triggering logic hasn't been linked to the
preference though.

TBR=bauerb@chromium.org

Bug: 777962
Change-Id: Ibdee6a12557885aec0be3ee0111197e273456fcc
Reviewed-on: https://chromium-review.googlesource.com/736182
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512068}
[modify] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/chrome/android/java/src/org/chromium/chrome/browser/preferences/AccessibilityPreferences.java
[modify] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
[modify] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/chrome/browser/android/preferences/prefs.h
[modify] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/chrome/browser/android/preferences/prefs_unittest.cc
[modify] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/components/dom_distiller/core/BUILD.gn
[modify] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/components/dom_distiller/core/distilled_page_prefs.cc
[add] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/components/dom_distiller/core/pref_names.cc
[add] https://crrev.com/d174a525391c53028e3c5b53496f0e0f26e30219/components/dom_distiller/core/pref_names.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e776a2fcde4ea41e0ce96bf0f99548fedb093816

commit e776a2fcde4ea41e0ce96bf0f99548fedb093816
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Jan 04 10:28:39 2018

Use Reader Mode for Accessibility preference

Link triggering logic to the Reader Mode for Accessibility preference.
If "Enable simplified view on all articles" is checked, the triggering
heuristics would be the same as "All articles" in
flags#reader-mode-heuristics.

Bug: 777962
Change-Id: I1dc03969978e00754cd04ccaf5979dc614f02eea
Reviewed-on: https://chromium-review.googlesource.com/835428
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526954}
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/chrome/android/BUILD.gn
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/chrome/browser/dom_distiller/tab_utils_android.cc
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/content/browser/android/java/src/org/chromium/components/dom_distiller/content/DistillablePageUtils.java
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/content/browser/distillability_driver.cc
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/content/browser/distillability_driver.h
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/content/browser/distillable_page_utils.h
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/content/browser/distillable_page_utils_android.cc
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/content/common/distillability_service.mojom
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/content/renderer/distillability_agent.cc
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/core/BUILD.gn
[modify] https://crrev.com/e776a2fcde4ea41e0ce96bf0f99548fedb093816/components/dom_distiller/core/experiments.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bed258aae2495b72bfad15fbed565e783e47f4a

commit 8bed258aae2495b72bfad15fbed565e783e47f4a
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Fri Jan 12 19:51:09 2018

Do not automatically enable reader for a11y with TalkBack

Reader Mode for Accessibility should be turned on if and only if
the setting is enabled.

Bug: 777962
Change-Id: I7f78661a75d197372568932d05f5a47d8f8048e6
Reviewed-on: https://chromium-review.googlesource.com/864823
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529030}
[modify] https://crrev.com/8bed258aae2495b72bfad15fbed565e783e47f4a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e320411168e4684645624da12bf7ce45d40725a5

commit e320411168e4684645624da12bf7ce45d40725a5
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Thu Jan 18 20:01:43 2018

Update string IDS_READER_FOR_ACCESSIBILITY_SUMMARY

See discussion in g/dom-distiller-eng/6OMbavfHIAk.

Bug: 777962
Change-Id: I839d278be4c66164445541a196a149ec5650f091
Reviewed-on: https://chromium-review.googlesource.com/864786
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530243}
[modify] https://crrev.com/e320411168e4684645624da12bf7ce45d40725a5/chrome/android/java/strings/android_chrome_strings.grd

Comment 8 by k...@chromium.org, Jan 26 2018

Cc: wychen@chromium.org
 Issue 709849  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/959de62f316f4a1731b2fc915ad70724c55354f9

commit 959de62f316f4a1731b2fc915ad70724c55354f9
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Mon Jan 29 11:18:38 2018

Enable experiment AllowReaderForAccessibility by default

Bug: 777962
Change-Id: I6cf85600830ddd6c2398a15e4a1c4c74aa9fbfd9
Reviewed-on: https://chromium-review.googlesource.com/886830
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532390}
[modify] https://crrev.com/959de62f316f4a1731b2fc915ad70724c55354f9/chrome/browser/android/chrome_feature_list.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5264b39a7cf4dca978a18e40cfaeea25ad6a155a

commit 5264b39a7cf4dca978a18e40cfaeea25ad6a155a
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jan 30 01:22:59 2018

Declare the ReaderForAccessibility experments for fieldtrial testing

Bug: 777962
Change-Id: I23ffb355ada1efe954b8080c8d2c9e1b2049fd5d
Reviewed-on: https://chromium-review.googlesource.com/886829
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532715}
[modify] https://crrev.com/5264b39a7cf4dca978a18e40cfaeea25ad6a155a/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235dc691756b1c06c33a8d83b50498fc48ef1be1

commit 235dc691756b1c06c33a8d83b50498fc48ef1be1
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Wed Jan 31 05:07:02 2018

Fix fieldtrial config for ReaderForAccessibility experment

This fixes https://crrev.com/c/886829.

Bug: 777962
Change-Id: Ie8df07034375e8f1e5d5dfb8b821f178bb479b5f
Reviewed-on: https://chromium-review.googlesource.com/892490
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533206}
[modify] https://crrev.com/235dc691756b1c06c33a8d83b50498fc48ef1be1/testing/variations/fieldtrial_testing_config.json

Labels: Merge-Request-65
We'd like to merge the CL in #c9 to M65.
Project Member

Comment 13 by sheriffbot@chromium.org, Feb 5 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 28 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 14 by cmasso@google.com, Feb 5 2018

Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Merge approved for #c9
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 6 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aeb59032ef63d44b3479fd26c28466f72d7dc6e

commit 2aeb59032ef63d44b3479fd26c28466f72d7dc6e
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Feb 06 06:49:40 2018

[Merge to M65] Enable experiment AllowReaderForAccessibility by default

Bug: 777962
Change-Id: I6cf85600830ddd6c2398a15e4a1c4c74aa9fbfd9
Reviewed-on: https://chromium-review.googlesource.com/886830
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532390}(cherry picked from commit 959de62f316f4a1731b2fc915ad70724c55354f9)
Reviewed-on: https://chromium-review.googlesource.com/903429
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#343}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/2aeb59032ef63d44b3479fd26c28466f72d7dc6e/chrome/browser/android/chrome_feature_list.cc

Comment 16 by k...@chromium.org, Feb 15 2018

Cc: -k...@chromium.org
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ba469316ffda95f9ab385af49d583f8cd4ad13b

commit 0ba469316ffda95f9ab385af49d583f8cd4ad13b
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Wed Aug 15 08:46:31 2018

Post-launch cleanup for AllowReaderForAccessibility

AllowReaderForAccessibility was launched in M65.

Bug: 777962
Change-Id: I1d702be283cb551ae64cb5c87009a05b6510e2e9
Reviewed-on: https://chromium-review.googlesource.com/1174098
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583198}
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/android/java/src/org/chromium/chrome/browser/preferences/AccessibilityPreferences.java
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/browser/about_flags.cc
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/0ba469316ffda95f9ab385af49d583f8cd4ad13b/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment