New issue
Advanced search Search tips

Issue 777949 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Merge request for custom tab related glitch fix

Project Member Reported by dskiba@chromium.org, Oct 24 2017

Issue description

This is to merge the fix mentioned in #15 in issue 776456 to M63 branch.

 

Comment 1 by dskiba@chromium.org, Oct 24 2017

Fix details:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9b7b30337ded7f20041f545792bcbadc55dd8d1

commit d9b7b30337ded7f20041f545792bcbadc55dd8d1
Author: Dmitry Skiba <dskiba@chromium.org>
Date: Mon Oct 23 23:02:30 2017

Avoid flash when aborting CTA.

Sometimes there is a visual glitch when ChromeTabbedActivity finishes
itself after starting another activity. For example the associated bug
documents a case where there is a momentary flash during custom tab
redirection.

The glitch is caused by abortLaunch() calling overridePendingTransition()
to do the following:

1. Disable exit animation on CTA window.

2. Force enter animation of the next window to be 'activity_open_enter'.

Both of those arguments were chosen without much experimentation, and
together they cause a flash because initial state of 'activity_open_enter'
animation is a transparent window, and canceling exit animation on a CTA
window immediately removes it.

This CL fixes overridePendingTransition() call to do the following:

1. Use 'no_anim' for the exit animation. This causes CTA window to be
   visible for a short amount of time (should enough for the next activity
   to render its UI).

2. Disable enter animation for the incoming activity. Animating another
   window on top of still CTA window just doesn't look good.


Bug:  776456 
Change-Id: I4a8de790087c4f3f2711999c2255198f311b6b7e
Reviewed-on: https://chromium-review.googlesource.com/734260
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510954}
[modify] https://crrev.com/d9b7b30337ded7f20041f545792bcbadc55dd8d1/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java

Comment 2 by dskiba@chromium.org, Oct 24 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 25 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by dskiba@chromium.org, Oct 25 2017

Labels: -Merge-Approved-63 merge-merged-3239
Manually changing tags, because the CL mentioned issue 776456, so the bot added comment added there.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f2ba4669e054a4e526a23dc9f4f7ed73fa5d1e3

commit 5f2ba4669e054a4e526a23dc9f4f7ed73fa5d1e3
Author: Dmitry Skiba <dskiba@chromium.org>
Date: Wed Oct 25 19:22:36 2017

[Merge to M63] Avoid flash when aborting CTA.

Sometimes there is a visual glitch when ChromeTabbedActivity finishes
itself after starting another activity. For example the associated bug
documents a case where there is a momentary flash during custom tab
redirection.

The glitch is caused by abortLaunch() calling overridePendingTransition()
to do the following:

1. Disable exit animation on CTA window.

2. Force enter animation of the next window to be 'activity_open_enter'.

Both of those arguments were chosen without much experimentation, and
together they cause a flash because initial state of 'activity_open_enter'
animation is a transparent window, and canceling exit animation on a CTA
window immediately removes it.

This CL fixes overridePendingTransition() call to do the following:

1. Use 'no_anim' for the exit animation. This causes CTA window to be
   visible for a short amount of time (should enough for the next activity
   to render its UI).

2. Disable enter animation for the incoming activity. Animating another
   window on top of still CTA window just doesn't look good.


Bug:  776456 
Change-Id: I4a8de790087c4f3f2711999c2255198f311b6b7e
Reviewed-on: https://chromium-review.googlesource.com/734260
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510954}(cherry picked from commit d9b7b30337ded7f20041f545792bcbadc55dd8d1)
Reviewed-on: https://chromium-review.googlesource.com/738493
Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#228}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/5f2ba4669e054a4e526a23dc9f4f7ed73fa5d1e3/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java

Comment 5 by dskiba@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)

Sign in to add a comment