New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777948 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Fix the autolayouted Toolbar on iPad.

Project Member Reported by jif@chromium.org, Oct 24 2017

Issue description

Currently the constraints are only for iPhone.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce0a474e2d38395dc0c985b00900c486980c4f76

commit ce0a474e2d38395dc0c985b00900c486980c4f76
Author: Jean-François Geyelin <jif@chromium.org>
Date: Wed Oct 25 12:34:11 2017

Add specific autolayout constraints for the Toolbar on iPad.

The experimental flag "Safe Area Compatible Toolbar" makes the Toolbar
be laid out with autolayout. Before this CL, enabling this flag made
the Toolbar be aligned with the top of the screen, like on iPhone.

Bug:  777948 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I83db7b5ed345b7336324f369d3b1dec175c12b4b
Reviewed-on: https://chromium-review.googlesource.com/735549
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511427}
[modify] https://crrev.com/ce0a474e2d38395dc0c985b00900c486980c4f76/ios/chrome/browser/ui/browser_view_controller.mm

Comment 2 by jif@chromium.org, Oct 25 2017

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.

Comment 4 by jif@chromium.org, Oct 27 2017

Labels: Merge-Request-63
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 27 2017

Labels: -Merge-Request-63 Hotlist-Merge-Reject Merge-Reject-63
The bug is marked as P3 or Feature. It should not be merged as M63 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by jif@chromium.org, Oct 27 2017

Labels: -Pri-3 -Hotlist-Merge-Reject -Merge-Reject-63 Merge-Request-63 Pri-1
This is actually a P1
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 27 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by cma...@chromium.org, Oct 27 2017

Has this been verified in Canary?
Cc: gambard@chromium.org cma...@chromium.org
cmasso@: This is for iPhone X. We cannot verify in Canary as it is simulator only at the moment.
Labels: -Hotlist-Merge-Review -Merge-TBD -Merge-Review-63 Merge-Approved-63
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 3 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-63
Removing the M63 merge request as the flag won't be enabled in M63.
Labels: -ReleaseBlock-Stable
Then this is no more a blocker as well.
Status: Assigned (was: Fixed)
Tested this today, this fix is not reflecting in the following Builds

Build : 63.0.3239.48 beta
iOS   : 10.3.3, 11.2, 11.1.1
Device: iPad, iPad mini, iPhone X

Comment 15 by jif@chromium.org, Nov 16 2017

Status: Fixed (was: Assigned)
I believe this was fixed by https://chromium-review.googlesource.com/735549

Sign in to add a comment