New issue
Advanced search Search tips

Issue 777940 link

Starred by 1 user
Status: Fixed
Owner:
thildebr@chromium.org
Closed: Oct 2017
Cc:
twelling...@chromium.org
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Bottom nav panel is hard to click and highlight bounds are too small on older Android versions

Project Member Reported by tedc...@chromium.org, Oct 24 2017 
Application Version : 64.0.3249.0 
Android Build Number : KTU85H
Device: Nexus 5

Steps to reproduce: 
* Open Chrome Home
* Long press on one of the nav buttons in the section picker

Observed behavior: 
The highlight bounds are constrained to the image height and width.

You can also click above and below the highlight region and see that the section doesn't get selected.

Expected behavior: 
The highlight bounds should go to the top and bottom of the panel.

Frequency: 
10/10

Additional comments:
screenshot-06936436235548db-20171024T112105.png
348 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2e7ef01b15272ba2d39fff1965df80f63aa59fc

commit b2e7ef01b15272ba2d39fff1965df80f63aa59fc
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Wed Oct 25 15:32:44 2017

[Home] Make bottom navigation menu items as tall as the menu.

Bug:  777940 
Change-Id: I5533fa1b8ffb981799ee2075b54c7dedb1455b87
Reviewed-on: https://chromium-review.googlesource.com/736321
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511470}
[modify] https://crrev.com/b2e7ef01b15272ba2d39fff1965df80f63aa59fc/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationItemView.java

Comment 2 by thildebr@chromium.org, Oct 25 2017

Status: Fixed (was: Assigned)

Comment 3 by twelling...@chromium.org, Oct 25 2017 

Is this only an M64 issues or should we request a 63 merge?

Comment 4 by thildebr@google.com, Oct 25 2017 

Should only be 64, the change that introduced it was for the bottom nav labels which landed after branch.

Comment 5 by ram...@chromium.org, Oct 31 2017 

Verified fix with Chrome Dev '64.0.3254' on Nexus 5/KTU85H
►

Sign in to add a comment