autofdo: switch back to binary profiles |
||||
Issue descriptionIn https://bugs.chromium.org/p/chromium/issues/detail?id=777507, we switched to text profiles as an workaround to a bug in autofdo tools. The side effect is that the compilation of each file increased ~150ms. Although only release builders set USE=afdo_use, this expense is unnecessary once the tool is fixed.
,
Nov 7 2017
,
Dec 5 2017
The CL to switch back to binary profile is on the way: https://chromium-review.googlesource.com/c/chromiumos/chromite/+/809236
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/85d186db3d0218103d04722904ce9738611ddd12 commit 85d186db3d0218103d04722904ce9738611ddd12 Author: Ting-Yuan Huang <laszio@chromium.org> Date: Wed Dec 06 04:22:38 2017 Revert "afdo: switch to text format" This reverts commit 0c5febae83359abe80736cfc5acad600245fd400. Reason for revert: LLVM had been fixed. BUG= chromium:777932 Original change's description: > afdo: switch to text format > > This worksaround a bug in autofdo-0.17. It is also easier to debug. > > The size change is around 3.3x (17M -> 56M), however, after bz2 it is > 1.5x (2.6M -> 3.9M). > > BUG=chromium:777507 > TEST=create_llvm_profile generates profiles in text. > > Change-Id: I5dffa73c0f9f92580d0be9c30fbe92df3e90852a > Reviewed-on: https://chromium-review.googlesource.com/734285 > Commit-Queue: Ting-Yuan Huang <laszio@chromium.org> > Tested-by: Ting-Yuan Huang <laszio@chromium.org> > Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org> > Reviewed-by: Luis Lozano <llozano@chromium.org> Bug: chromium:777507 Change-Id: Iaa14b25556e3caa08db41116a0dfd7b0183ed4bb Reviewed-on: https://chromium-review.googlesource.com/809236 Commit-Ready: Ting-Yuan Huang <laszio@chromium.org> Tested-by: Ting-Yuan Huang <laszio@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/85d186db3d0218103d04722904ce9738611ddd12/cbuildbot/afdo.py
,
Jan 2 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by laszio@chromium.org
, Oct 24 2017