Better data for tests in autofill |
||
Issue descriptionInstead of making a new data source for every test class we write, we should use countryinfo.txt available to the test classes, and use that instead.
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a51e21498c6fd3f3949782da63d4c0612d698be3 commit a51e21498c6fd3f3949782da63d4c0612d698be3 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Mon Nov 06 17:08:23 2017 Make countryinfo.txt accessible to test classes. For autofill, instead of writing a new test data class for each test class, we now use the regional data in countyinfo.txt (third_party/libaddressinput.) The AutofillAddressValidationTest and the SubKeyRequesterTest are changed accordingly. Updates the ref to the most recent libaddressinput. Bug: 777925 Change-Id: I17062c3cc7e0d247638d076010fd26e4387b93f5 Reviewed-on: https://chromium-review.googlesource.com/613504 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#514156} [modify] https://crrev.com/a51e21498c6fd3f3949782da63d4c0612d698be3/DEPS [modify] https://crrev.com/a51e21498c6fd3f3949782da63d4c0612d698be3/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/a51e21498c6fd3f3949782da63d4c0612d698be3/components/autofill/core/browser/address_validation_util_unittest.cc [modify] https://crrev.com/a51e21498c6fd3f3949782da63d4c0612d698be3/components/autofill/core/browser/subkey_requester_unittest.cc [modify] https://crrev.com/a51e21498c6fd3f3949782da63d4c0612d698be3/third_party/libaddressinput/BUILD.gn
,
Nov 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by parastoog@chromium.org
, Oct 24 2017