New issue
Advanced search Search tips

Issue 777898 link

Starred by 3 users

Issue metadata

Status: Archived
Owner: ----
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

onBeforeRequestEvent doesn't provide requestBody.formData anymore

Reported by br...@compcc.com, Oct 24 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:57.0) Gecko/20100101 Firefox/57.0

Steps to reproduce the problem:
1. Install SAML to AWS STS Keys Conversion from webstore (https://chrome.google.com/webstore/detail/saml-to-aws-sts-keys-conv/ekniobabpcnfjgfbphhcolcinmnbehde), GitHub repo: https://github.com/prolane/samltoawsstskeys
2. Authenticate to AWS using a SAML provider (we use Google org federation).

What is the expected behavior?
'credentials' file is auto-downloaded by Chrome

What went wrong?
Exception is thrown in extension console, because details.requestBody.formData is undefined.

See https://github.com/prolane/samltoawsstskeys/pull/7 for workaround.

Did this work before? Yes Chrome 61

Does this work in other browsers? Yes

Chrome version: 62.0.3202.62 (Official Build) (64-bit)  Channel: stable
OS Version: OS X 10.12
Flash Version: Shockwave Flash 25.0 r0

Not clear from webRequest documentation (https://developer.chrome.com/extensions/webRequest#event-onBeforeRequest) why formData wouldn't be available if it was before. Didn't see any particular changes in Chrome 62 that would have yielded this. All the info is still available in the 'raw' ArrayBuffers, it just isn't being parsed and made available in 'formData' as it was in Chrome 61.
 

Comment 1 by br...@compcc.com, Oct 24 2017

FWIW, the "Does this work in other browsers" is invalid/moot - this is Chrome-specific (because Chrome extension).
Components: Platform>Extensions>API
While not exactly moot (because Firefox and Edge implement the Chrome extension API to some extent), it is not a web interoperability issue.

If you can provide a small extension that just demonstrates the issue (without any Amazon/SAML/credentials), that would expedite the triaging (and the fix, if any).
Labels: -Hotlist-Interop

Comment 4 by br...@compcc.com, Oct 24 2017

I have no idea how to write an extension, unfortunately. Just had enough knowledge to crack open dev tools for the extension, debug, and come up with a workaround.
Labels: Needs-Triage-M62 Needs-Feedback

Comment 6 by phistuck@gmail.com, Oct 27 2017

Using the attached extension and the following URL -
data:text/html,<form method="post" name="crap" action="http://phistuck-app.appspot.com" target="fff"><input name=f value=fdfdsf><input type=submit></form>

Submitting the form and looking at the console of the background page reveals the form data on Windows. Using BrowserStack, macOS High Sierra and Chrome 62 also reveals the form data. Does it reveal it for you if you load it as an unpacked extension (extract the zip file, go to chrome:extensions, tick the "Developer mode", click on "Load unpacked extension..." and select the folder)?
webrequest-test-extension.zip
606 bytes Download
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 27 2017

Status: Archived (was: Unconfirmed)
No feedback was received in the last 30 days from reporter "bruth@compcc.com", so archiving this. Please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment