New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777890 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Find in Page does not respect the safe area on iPhone X

Project Member Reported by gambard@chromium.org, Oct 24 2017

Issue description

iPhone X only

What steps will reproduce the problem?
(1) Open a page in landscape
(2) Open find in page

What is the expected result?
Find in page should respect the safe area.

What happens instead?
The controls (previous/next/close) are outside the safe area.
 
Simulator Screen Shot - iPhone X - 2017-10-24 at 17.59.07.png
459 KB View Download

Comment 1 by pkl@chromium.org, Oct 25 2017

Cc: jif@chromium.org noyau@chromium.org pkl@chromium.org
Labels: M-63
Owner: lod@chromium.org
Status: Assigned (was: Untriaged)
We should fix this, but since Find In Page is only used by a small percentage of all Chrome users, this may not need to be release blocking.

Comment 2 by lod@chromium.org, Nov 6 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5281c619313d1974cc3e66374db525d531b1f465

commit 5281c619313d1974cc3e66374db525d531b1f465
Author: Elodie Banel <lod@google.com>
Date: Tue Nov 07 09:19:24 2017

Pin FindBarView to safe area.

Bug:  777890 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5ec7cebc3a3bd8af0aa1e85c0b7318f214a26413
Reviewed-on: https://chromium-review.googlesource.com/753375
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514427}
[modify] https://crrev.com/5281c619313d1974cc3e66374db525d531b1f465/ios/chrome/browser/ui/find_bar/find_bar_view.mm

Comment 4 by lod@chromium.org, Nov 7 2017

Status: Fixed (was: Started)
Tested this bug today, this bug is not fixed in the following build

Build: 63.0.3239.48 beta
iOS: 11.1
Device: iPhone X

But, this Bug is fixed in latest 64.0.3267.0 Canary, please merge this fix 
Status: Assigned (was: Fixed)

Comment 7 by lod@chromium.org, Nov 14 2017

Labels: Merge-Request-63
Status: Fixed (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 14 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Less than 17 days to go before AppStore submit on M63
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by cma...@chromium.org, Nov 15 2017

Labels: -Merge-Review-63 mergea-
lod@ can we consider leaving this in M64 since it is not very critical for M63?

Comment 10 by lod@chromium.org, Nov 16 2017

Labels: -M-63 M-64
Sounds good.
Status: Verified (was: Fixed)
Verified in 64.0.3282.75 beta, iPhone X iOS 11.2
Looks good.
https://drive.google.com/file/d/1HDCm59EciRVF_hqQHB1NA4fXXe17M-CK/view

Sign in to add a comment