Find in Page does not respect the safe area on iPhone X |
|||||||||
Issue descriptioniPhone X only What steps will reproduce the problem? (1) Open a page in landscape (2) Open find in page What is the expected result? Find in page should respect the safe area. What happens instead? The controls (previous/next/close) are outside the safe area.
,
Nov 6 2017
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5281c619313d1974cc3e66374db525d531b1f465 commit 5281c619313d1974cc3e66374db525d531b1f465 Author: Elodie Banel <lod@google.com> Date: Tue Nov 07 09:19:24 2017 Pin FindBarView to safe area. Bug: 777890 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5ec7cebc3a3bd8af0aa1e85c0b7318f214a26413 Reviewed-on: https://chromium-review.googlesource.com/753375 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#514427} [modify] https://crrev.com/5281c619313d1974cc3e66374db525d531b1f465/ios/chrome/browser/ui/find_bar/find_bar_view.mm
,
Nov 7 2017
,
Nov 13 2017
Tested this bug today, this bug is not fixed in the following build Build: 63.0.3239.48 beta iOS: 11.1 Device: iPhone X But, this Bug is fixed in latest 64.0.3267.0 Canary, please merge this fix
,
Nov 13 2017
,
Nov 14 2017
,
Nov 14 2017
This bug requires manual review: Less than 17 days to go before AppStore submit on M63 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15 2017
lod@ can we consider leaving this in M64 since it is not very critical for M63?
,
Nov 16 2017
Sounds good.
,
Jan 5 2018
Verified in 64.0.3282.75 beta, iPhone X iOS 11.2 Looks good. https://drive.google.com/file/d/1HDCm59EciRVF_hqQHB1NA4fXXe17M-CK/view |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pkl@chromium.org
, Oct 25 2017Labels: M-63
Owner: lod@chromium.org
Status: Assigned (was: Untriaged)