CompositorFrameMetadata::selection needs to be sent to the browser with --enable-viz |
||||||
Issue descriptionWe need CompositorFrameMetadata::selection to position touch selection handles. With --enable-viz the browser doesn't receive the renderer's CompositorFrame so CompositorFrameMetadata::selection should be sent in another way.
,
Feb 9 2018
Issue 771367 has been merged into this issue.
,
Mar 13 2018
,
Mar 22 2018
,
Apr 3 2018
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bfc8dc942fe24bedf942d2a215cf6883c23723f commit 6bfc8dc942fe24bedf942d2a215cf6883c23723f Author: Mohsen Izadi <mohsen@chromium.org> Date: Tue Apr 03 21:21:35 2018 Add selection info to RenderFrameMetadata Browser needs information about selection to be able to show selection touch handles. When Viz display compositor is enabled, browser does not receive CompositorFrameMetadata which contains this info and it needs to be added to RenderFrameMetadata. BUG= 777882 TEST= content_browsertests: - TouchSelectionControllerClientAuraScaleFactorTest.* - TouchSelectionControllerClientAuraTest.* cc_unittests: - LayerTreeHostImplTest.SelectionBoundsPassedToRenderFrameMetadata Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8d1d03efb22d308048bfa8939af57658cee28b15 Reviewed-on: https://chromium-review.googlesource.com/980583 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547836} [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/cc/trees/render_frame_metadata.cc [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/cc/trees/render_frame_metadata.h [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/content/common/DEPS [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/content/common/render_frame_metadata.mojom [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/content/common/render_frame_metadata_struct_traits.cc [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/content/common/render_frame_metadata_struct_traits.h [modify] https://crrev.com/6bfc8dc942fe24bedf942d2a215cf6883c23723f/testing/buildbot/filters/viz.content_browsertests.filter
,
Apr 18 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jonr...@chromium.org
, Nov 15 2017