NTP's stack view button not functional after rotation. |
|||||||||
Issue descriptionTo repro: -launch on iPhone X in portrait -rotate phone -press the stack view button Expected behavior: -Chrome enters the stack view What actually happens: The omnibox is selected instead.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08637853d9272c18d02c7c6225f54766cb935a1f commit 08637853d9272c18d02c7c6225f54766cb935a1f Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Oct 24 15:22:15 2017 Fix glitches in the Toolbar This CL fixes two glitches: - It resizes the tappable area of the NTP's omnibox to prevent it from overlapping with the stack button. - It puts the omnibox controls (clear and cancel) inside the safe area. Bug: 777807 , 777864 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I96ee42df3bbafe9a76f811b62b6ac2fbaff1f40e Reviewed-on: https://chromium-review.googlesource.com/735327 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#511150} [modify] https://crrev.com/08637853d9272c18d02c7c6225f54766cb935a1f/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm [modify] https://crrev.com/08637853d9272c18d02c7c6225f54766cb935a1f/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
,
Oct 24 2017
,
Oct 25 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0146e6dedea8cc695b0952f4fbd29c41c227090e commit 0146e6dedea8cc695b0952f4fbd29c41c227090e Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Oct 25 15:27:52 2017 Fix glitches in the Toolbar This CL fixes two glitches: - It resizes the tappable area of the NTP's omnibox to prevent it from overlapping with the stack button. - It puts the omnibox controls (clear and cancel) inside the safe area. Bug: 777807 , 777864 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I96ee42df3bbafe9a76f811b62b6ac2fbaff1f40e Reviewed-on: https://chromium-review.googlesource.com/735327 Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511150}(cherry picked from commit 08637853d9272c18d02c7c6225f54766cb935a1f) Reviewed-on: https://chromium-review.googlesource.com/737634 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#215} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/0146e6dedea8cc695b0952f4fbd29c41c227090e/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm [modify] https://crrev.com/0146e6dedea8cc695b0952f4fbd29c41c227090e/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
,
Oct 26 2017
Verified in M63.0.3239.19 beta iPhoneX Simulator Tapping on TabSwicher icon in landscape mode opens Tab Switcher view correctly. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by gambard@chromium.org
, Oct 24 2017