Port functional WebRTC tests from CrOS autotests |
||||
Issue descriptionDescribe problem with existing test, or request for new test. Port for instance webrtc_PausePlayPeerConnections and video_WebRtcMainFeedSwitching. Try to fit them well into the existing tests so we don't force WebRTC devs to maintain different JS paradigms.
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1dbf0484a5b5010cffed3b0d099a5007023303c commit c1dbf0484a5b5010cffed3b0d099a5007023303c Author: Patrik Höglund <phoglund@chromium.org> Date: Thu Oct 26 13:43:29 2017 Porting kerl@'s test to browser tests. These tests have caught bugs over at CrOS and will do more good here, so pull them in. Follow-up CLs: - Rewrite existing browser tests to use promises and (maybe) the peer connection class in here. Bug: 777857 Change-Id: Icd4d73788ab54f5133715a4765c0ceff78b0ad3f Reviewed-on: https://chromium-review.googlesource.com/735347 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#511806} [modify] https://crrev.com/c1dbf0484a5b5010cffed3b0d099a5007023303c/build/sanitizers/tsan_suppressions.cc [add] https://crrev.com/c1dbf0484a5b5010cffed3b0d099a5007023303c/content/browser/webrtc/webrtc_pause_play_browsertest.cc [modify] https://crrev.com/c1dbf0484a5b5010cffed3b0d099a5007023303c/content/test/BUILD.gn [add] https://crrev.com/c1dbf0484a5b5010cffed3b0d099a5007023303c/content/test/data/media/peerconnection-multiple-streams.js [add] https://crrev.com/c1dbf0484a5b5010cffed3b0d099a5007023303c/content/test/data/media/peerconnection-pause-play.html
,
Oct 26 2017
There we go! kerl@, can you port any other interesting tests? I'll be happy to review. I plan to rewrite the old tests to promises on the plane ride next week...
,
Oct 26 2017
This is great, thank you, Patrik! We have some other tasks that is a bit higher in priority, but we can hopefully start with this within a week or two!
,
Oct 26 2017
SGTM
,
Nov 10 2017
Posting this one by hand since I linked the wrong bug in that CL: The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29cb248850060bd37f4105bcd61be7c18c04d599 commit 29cb248850060bd37f4105bcd61be7c18c04d599 Author: Patrik Höglund <phoglund@chromium.org> Date: Tue Nov 07 13:32:12 2017 Rewriting wait-for-video functions to use promises. The end goal here is to get rid of addExpectedEvent() / eventOccurred() and replace with promises, which is more standard. I hope we will end up getting rid of all the callback complexity and replacing with straightforward chains of promises. This also harmonizes us with the new browser tests from kerl@, which uses promises. The next CL will try to get rid of the waitFor functions. Further CLs will eliminate other use of the addExpectedEvent etc functions. Bug: 735347 Change-Id: Ibc6dd5ec15aed21fa7f52b7fcc83f5f4d12fe134 Reviewed-on: https://chromium-review.googlesource.com/747626 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#514458} [modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/getusermedia-depth-capture.html [modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/getusermedia-real-webcam.html [modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/getusermedia.html [modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/peerconnection-call.html [modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/video_capture_test.html [modify] https://crrev.com/29cb248850060bd37f4105bcd61be7c18c04d599/content/test/data/media/webrtc_test_utilities.js
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/674733a38d32b51dbc4b054dcc3495027164ded2 commit 674733a38d32b51dbc4b054dcc3495027164ded2 Author: Patrik Höglund <phoglund@chromium.org> Date: Mon Nov 13 10:38:51 2017 Rewrite getUseMedia calls to use promises. This removes many uses of waitForVideo() etc. and makes the control flow of the test clearer. Instead of having the all-events-occurred handler magically calling reportTestSuccess, it's laid out explicitly in each test. Bug: chromium:777857 Change-Id: I034d8950f764df607069b3e4b5ce6baeb46eab9b Reviewed-on: https://chromium-review.googlesource.com/758848 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#515917} [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/browser/webrtc/webrtc_browsertest.cc [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/test/data/media/getusermedia-real-webcam.html [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/test/data/media/getusermedia.html [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/test/data/media/peerconnection-call-audio.html [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/test/data/media/peerconnection-call-data.html [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/test/data/media/peerconnection-call.html [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/test/data/media/video_capture_test.html [modify] https://crrev.com/674733a38d32b51dbc4b054dcc3495027164ded2/content/test/data/media/webrtc_test_utilities.js
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fd7fdb8a808b8173c69a9a95313f4abd642cdba commit 0fd7fdb8a808b8173c69a9a95313f4abd642cdba Author: Patrik Höglund <phoglund@chromium.org> Date: Thu Nov 23 15:21:26 2017 Get rid of a few more addExpectedEvent calls. The end goal is to get rid of all of them and replace with promises. Bug: chromium:777857 Change-Id: I58c0bc9f1ee80a16522c3a1679a9647dbc623f9a Reviewed-on: https://chromium-review.googlesource.com/786550 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#518941} [modify] https://crrev.com/0fd7fdb8a808b8173c69a9a95313f4abd642cdba/content/test/data/media/getusermedia-depth-capture.html [modify] https://crrev.com/0fd7fdb8a808b8173c69a9a95313f4abd642cdba/content/test/data/media/getusermedia.html [modify] https://crrev.com/0fd7fdb8a808b8173c69a9a95313f4abd642cdba/content/test/data/media/peerconnection-call-audio.html [modify] https://crrev.com/0fd7fdb8a808b8173c69a9a95313f4abd642cdba/content/test/data/media/peerconnection-call.html [modify] https://crrev.com/0fd7fdb8a808b8173c69a9a95313f4abd642cdba/content/test/data/media/webrtc_test_utilities.js
,
Nov 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/454ce26d2d44131a13cf1d6d56de63e4da3cf919 commit 454ce26d2d44131a13cf1d6d56de63e4da3cf919 Author: Patrik Höglund <phoglund@chromium.org> Date: Fri Nov 24 15:55:00 2017 Make waitForConnectionToStabilize promise, rewrite audio tests. This gets rid of a few more addExpectedEvent/eventOccured... Bug: chromium:777857 Change-Id: I1b6332a1a84440d2723a169f4256e95669a5924e Reviewed-on: https://chromium-review.googlesource.com/788380 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#519122} [modify] https://crrev.com/454ce26d2d44131a13cf1d6d56de63e4da3cf919/content/test/data/media/peerconnection-call-audio.html [modify] https://crrev.com/454ce26d2d44131a13cf1d6d56de63e4da3cf919/content/test/data/media/peerconnection-call.html [modify] https://crrev.com/454ce26d2d44131a13cf1d6d56de63e4da3cf919/content/test/data/media/webrtc_test_audio.js [modify] https://crrev.com/454ce26d2d44131a13cf1d6d56de63e4da3cf919/content/test/data/media/webrtc_test_utilities.js
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0122ab8474165ec0e58bd23edaea304f617fae24 commit 0122ab8474165ec0e58bd23edaea304f617fae24 Author: Patrik Höglund <phoglund@chromium.org> Date: Mon Nov 27 14:43:34 2017 Replacing the last addExpectedEvent with promises. This concludes the refactoring. The tests now have a MUCH clearer control flow, and test success is no longer handled behind the scenes. I found that it's better to keep promise chains as long as possible, since we can then append a single .catch(failTest) at the end. This isn't strictly necessary - the test will time out since an error will break the promise chain and not call reportTestSuccess, but it's much nicer if the test fails right away on exceptions, rather than timing out after 45 seconds. Bug: chromium:777857 Change-Id: If8f269adc88a7626d4df64793861372c07fc7bbd Reviewed-on: https://chromium-review.googlesource.com/789883 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#519297} [modify] https://crrev.com/0122ab8474165ec0e58bd23edaea304f617fae24/content/test/data/media/getusermedia-depth-capture.html [modify] https://crrev.com/0122ab8474165ec0e58bd23edaea304f617fae24/content/test/data/media/getusermedia.html [modify] https://crrev.com/0122ab8474165ec0e58bd23edaea304f617fae24/content/test/data/media/peerconnection-call-audio.html [modify] https://crrev.com/0122ab8474165ec0e58bd23edaea304f617fae24/content/test/data/media/peerconnection-call-data.html [modify] https://crrev.com/0122ab8474165ec0e58bd23edaea304f617fae24/content/test/data/media/peerconnection-call.html [modify] https://crrev.com/0122ab8474165ec0e58bd23edaea304f617fae24/content/test/data/media/webrtc_test_utilities.js
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58d99ea4883719b234111e3d41ad2c443451acc1 commit 58d99ea4883719b234111e3d41ad2c443451acc1 Author: Henrik Boström <hbos@chromium.org> Date: Tue Nov 28 10:35:59 2017 Revert "Replacing the last addExpectedEvent with promises." This reverts commit 0122ab8474165ec0e58bd23edaea304f617fae24. Reason for revert: Speculative revert for flaky content_browsertests failure on WebRtcGetUserMediaBrowserTest. TwoGetUserMediaAndVerifyFrameRate, see https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/7694 Original change's description: > Replacing the last addExpectedEvent with promises. > > This concludes the refactoring. The tests now have a MUCH clearer > control flow, and test success is no longer handled behind the scenes. > > I found that it's better to keep promise chains as long as possible, > since we can then append a single .catch(failTest) at the end. This > isn't strictly necessary - the test will time out since an error > will break the promise chain and not call reportTestSuccess, but > it's much nicer if the test fails right away on exceptions, rather > than timing out after 45 seconds. > > Bug: chromium:777857 > Change-Id: If8f269adc88a7626d4df64793861372c07fc7bbd > Reviewed-on: https://chromium-review.googlesource.com/789883 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#519297} TBR=phoglund@chromium.org,guidou@chromium.org Change-Id: I15428ea72187469886e39aaa035f9d293f883b17 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:777857 Reviewed-on: https://chromium-review.googlesource.com/793010 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#519638} [modify] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/content/test/data/media/getusermedia-depth-capture.html [modify] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/content/test/data/media/getusermedia.html [modify] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/content/test/data/media/peerconnection-call-audio.html [modify] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/content/test/data/media/peerconnection-call-data.html [modify] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/content/test/data/media/peerconnection-call.html [modify] https://crrev.com/58d99ea4883719b234111e3d41ad2c443451acc1/content/test/data/media/webrtc_test_utilities.js
,
Nov 28 2017
Ah, I know why the test went flaky. The problem is that the old test did not verify anything at all, since its callback had
var validateFrameRateCallback = function (success) {
if (!success)
failTest("Failed to validate frameRate.");
eventOccured();
};
However, validate framerate does not call back with false if it fails, it calls back with an error message, i.e. an nonempty string. !"nonempty string" always evaluates false, so failTest can never occur.
I'll re-land the patch with the old behavior and file a bug to fix the test.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f commit a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f Author: Patrik Höglund <phoglund@chromium.org> Date: Tue Nov 28 15:33:04 2017 Reland: Replacing the last addExpectedEvent with promises. This concludes the refactoring. The tests now have a MUCH clearer control flow, and test success is no longer handled behind the scenes. I found that it's better to keep promise chains as long as possible, since we can then append a single .catch(failTest) at the end. This isn't strictly necessary - the test will time out since an error will break the promise chain and not call reportTestSuccess, but it's much nicer if the test fails right away on exceptions, rather than timing out after 45 seconds. Bug: chromium:777857 Change-Id: I46c110782488bb20cdf7101690ca6966601506f2 Reviewed-on: https://chromium-review.googlesource.com/793153 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#519695} [modify] https://crrev.com/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f/content/browser/webrtc/webrtc_getusermedia_browsertest.cc [modify] https://crrev.com/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f/content/test/data/media/getusermedia-depth-capture.html [modify] https://crrev.com/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f/content/test/data/media/getusermedia.html [modify] https://crrev.com/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f/content/test/data/media/peerconnection-call-audio.html [modify] https://crrev.com/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f/content/test/data/media/peerconnection-call-data.html [modify] https://crrev.com/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f/content/test/data/media/peerconnection-call.html [modify] https://crrev.com/a3a4cd96d46fb7bf6e223fd7dc26e6ec6ba18c9f/content/test/data/media/webrtc_test_utilities.js
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a00b6f04902d50677e56563de866a94ef720eca commit 8a00b6f04902d50677e56563de866a94ef720eca Author: Kristoffer Erlandsson <kerl@google.com> Date: Mon Dec 18 14:13:25 2017 Add test that switches srcObjects of video elements. Is intended to simulate a video call with one high resolution video element and several with low resolutions. The srcObject of the high resolution element is frequently swapped with one of the low resolution elemements. This is a port of the ChromeOS Autotest video_WebRtcMainFeedSwitching. Bug: 777857 Change-Id: I64f522f7141e6f2c7dcdf04d64af9147e884173d Reviewed-on: https://chromium-review.googlesource.com/819416 Commit-Queue: Kristoffer Erlandsson <kerl@google.com> Reviewed-by: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#524702} [add] https://crrev.com/8a00b6f04902d50677e56563de866a94ef720eca/content/browser/webrtc/webrtc_source_feed_switch_browsertest.cc [modify] https://crrev.com/8a00b6f04902d50677e56563de866a94ef720eca/content/test/BUILD.gn [add] https://crrev.com/8a00b6f04902d50677e56563de866a94ef720eca/content/test/data/media/peerconnection-source-feed-switch.html
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29cd12f363e548cc7d1bc67a1dcfba86b24531ea commit 29cd12f363e548cc7d1bc67a1dcfba86b24531ea Author: Kristoffer Erlandsson <kerl@google.com> Date: Tue Dec 19 10:20:23 2017 Add test that switches between different resolutions. Uses multiple streams with different resolutions per peer connection and switches between which streams is active. Is intended to simulate a way to perform speaker switching in video calls. Set to MANUAL now, is intended to be enabled on WebRTC bots. BUG= chromium:777857 Change-Id: I55b3003be8f88052db1795539aeae6dd85b1aa1f Reviewed-on: https://chromium-review.googlesource.com/832487 Commit-Queue: Kristoffer Erlandsson <kerl@google.com> Reviewed-by: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#524992} [add] https://crrev.com/29cd12f363e548cc7d1bc67a1dcfba86b24531ea/content/browser/webrtc/webrtc_resolution_switch_browsertest.cc [modify] https://crrev.com/29cd12f363e548cc7d1bc67a1dcfba86b24531ea/content/test/BUILD.gn [add] https://crrev.com/29cd12f363e548cc7d1bc67a1dcfba86b24531ea/content/test/data/media/peerconnection-resolution-switch.html
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5efa45b5e2cd9eebc6d131daf9b425df11a76d15 commit 5efa45b5e2cd9eebc6d131daf9b425df11a76d15 Author: Kristoffer Erlandsson <kerl@google.com> Date: Tue Dec 19 12:09:46 2017 Add audio flavor of the pause play test. This is a port of the Chrome OS autotest webrtc_PausePlayPeerConnections.audio. BUG= chromium:777857 Change-Id: Idfb1801da62886d7d7aa4e0685bfb1cf9795aaba Reviewed-on: https://chromium-review.googlesource.com/832483 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Kristoffer Erlandsson <kerl@google.com> Cr-Commit-Position: refs/heads/master@{#525002} [modify] https://crrev.com/5efa45b5e2cd9eebc6d131daf9b425df11a76d15/content/browser/webrtc/webrtc_pause_play_browsertest.cc
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8df826c0d3ff8abc5a9740525b360ab01129971 commit b8df826c0d3ff8abc5a9740525b360ab01129971 Author: Kristoffer Erlandsson <kerl@google.com> Date: Tue Dec 19 14:56:41 2017 Rename WebRtc Stress tests to WebRtcStress*. BUG= chromium:777857 Change-Id: Id2e92cd69eabc34020254466be689265d5f07899 Reviewed-on: https://chromium-review.googlesource.com/833884 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Kristoffer Erlandsson <kerl@google.com> Cr-Commit-Position: refs/heads/master@{#525031} [rename] https://crrev.com/b8df826c0d3ff8abc5a9740525b360ab01129971/content/browser/webrtc/webrtc_stress_pause_browsertest.cc [rename] https://crrev.com/b8df826c0d3ff8abc5a9740525b360ab01129971/content/browser/webrtc/webrtc_stress_resolution_switch_browsertest.cc [rename] https://crrev.com/b8df826c0d3ff8abc5a9740525b360ab01129971/content/browser/webrtc/webrtc_stress_source_switch_browsertest.cc [modify] https://crrev.com/b8df826c0d3ff8abc5a9740525b360ab01129971/content/test/BUILD.gn
,
Dec 19 2017
All tests have now been ported. They are running on the WebRtc Bots in the content_browsertests_manual step: https://ci.chromium.org/p/chromium/g/chromium.webrtc/console. AFAIU all tasks for this effort is now complete. I'm closing this bug.
,
Dec 19 2017
Sure, I might land another small patch which makes the stress tests run a bit faster, but that might be after Christmas.
,
Jan 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/00fe8cddf0b2defbbd45d16935c9cd875950b079 commit 00fe8cddf0b2defbbd45d16935c9cd875950b079 Author: Patrik Höglund <phoglund@chromium.org> Date: Tue Jan 02 10:51:04 2018 Configure a separate stress test step. This runs our new stress tests in parallell, which will speed up bot execution a bit. Bug: chromium:777857 Change-Id: I94025b70e355dee85f2936f7ade8fc9dafd0b4a1 Reviewed-on: https://chromium-review.googlesource.com/833923 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> [modify] https://crrev.com/00fe8cddf0b2defbbd45d16935c9cd875950b079/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/b25a1cdaf3da1d76a66cc837c49f678f9adc3f31 commit b25a1cdaf3da1d76a66cc837c49f678f9adc3f31 Author: Patrik Höglund <phoglund@chromium.org> Date: Thu Jan 11 08:48:11 2018 Correct WebRTC manual test filter, increase timeout. Since these new tests are stress tests, we want to allow them to run longer than usual tests. There was also a bug in the step filter intended for stress tests: it ran all non-manual tests again, which isn't what I intended. I just want manual non-sequential tests to run in there. Bug: chromium:777857 Change-Id: Ie1821719b587718ced5a029887871ea97138fbf0 Reviewed-on: https://chromium-review.googlesource.com/859459 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> [modify] https://crrev.com/b25a1cdaf3da1d76a66cc837c49f678f9adc3f31/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc.py
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad5fca45262419f66357dafa9f4e2e0d66ad26fe commit ad5fca45262419f66357dafa9f4e2e0d66ad26fe Author: Kristoffer Erlandsson <kerl@google.com> Date: Thu Jan 11 13:17:05 2018 Increase duration of WebRTC stress tests to 60s. Depends on https://crrev.com/c/859459. BUG= chromium:777857 Change-Id: I5303bb79dae7a351fe9d9aadaaee578c86d52ef2 Reviewed-on: https://chromium-review.googlesource.com/858136 Reviewed-by: Patrik Höglund <phoglund@chromium.org> Commit-Queue: Kristoffer Erlandsson <kerl@google.com> Cr-Commit-Position: refs/heads/master@{#528613} [modify] https://crrev.com/ad5fca45262419f66357dafa9f4e2e0d66ad26fe/content/browser/webrtc/webrtc_stress_pause_browsertest.cc [modify] https://crrev.com/ad5fca45262419f66357dafa9f4e2e0d66ad26fe/content/browser/webrtc/webrtc_stress_resolution_switch_browsertest.cc [modify] https://crrev.com/ad5fca45262419f66357dafa9f4e2e0d66ad26fe/content/browser/webrtc/webrtc_stress_source_switch_browsertest.cc
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/478db6a01b3c6ba37fb26597a5a82ccd8dd33d4b commit 478db6a01b3c6ba37fb26597a5a82ccd8dd33d4b Author: Christian Fremerey <chfremer@chromium.org> Date: Thu Jan 11 20:10:03 2018 Revert "Increase duration of WebRTC stress tests to 60s." This reverts commit ad5fca45262419f66357dafa9f4e2e0d66ad26fe. Reason for revert: It looks like this still causes test failures because of too much log output. Only this time it is ERROR logs. First failing build: https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/24171 Getting lots of error output like this: [3672:3764:0111/062647.969:ERROR:mf_helpers.cc(14)] Error in dxva_video_decode_accelerator_win.cc on line 695 [3672:3764:0111/062647.970:ERROR:gpu_video_decode_accelerator.cc(369)] HW video decode not available for profile h264 main [7/7] WebRtcStressResolutionSwitchBrowserTest.MANUAL_SurvivesPeerConnectionResolutionSwitching (61427 ms) 1 test produced excessive output: WebRtcStressResolutionSwitchBrowserTest.MANUAL_SurvivesPeerConnectionResolutionSwitching (../../content/browser/webrtc/webrtc_stress_resolution_switch_browsertest.cc:57) Original change's description: > Increase duration of WebRTC stress tests to 60s. > > Depends on https://crrev.com/c/859459. > > BUG= chromium:777857 > > Change-Id: I5303bb79dae7a351fe9d9aadaaee578c86d52ef2 > Reviewed-on: https://chromium-review.googlesource.com/858136 > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Commit-Queue: Kristoffer Erlandsson <kerl@google.com> > Cr-Commit-Position: refs/heads/master@{#528613} TBR=phoglund@chromium.org,kerl@google.com Change-Id: I7df2695620f94d3a642ae0fec38dd9b73d41cbc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:777857 Reviewed-on: https://chromium-review.googlesource.com/862249 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#528726} [modify] https://crrev.com/478db6a01b3c6ba37fb26597a5a82ccd8dd33d4b/content/browser/webrtc/webrtc_stress_pause_browsertest.cc [modify] https://crrev.com/478db6a01b3c6ba37fb26597a5a82ccd8dd33d4b/content/browser/webrtc/webrtc_stress_resolution_switch_browsertest.cc [modify] https://crrev.com/478db6a01b3c6ba37fb26597a5a82ccd8dd33d4b/content/browser/webrtc/webrtc_stress_source_switch_browsertest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by phoglund@chromium.org
, Oct 25 2017