Touch selection doesn't work for PDFs displayed in a (BrowserTag) WebView. |
|||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) Prereq: a desktop device with a touchscreen Prereq: some app that can show a PDF inside a WebView, e.g. https://chrome.google.com/webstore/detail/browser-sample/edggnmnajhcbhlnpjnogkjpghaikidaa?utm_source=chrome-app-launcher-info-dialog What steps will reproduce the problem? (1) Open a PDF (e.g. https://graduateland.com/api/v2/users/jesper/cv) inside a WebView (2) Longpress to select some text. What is the expected result? The text should be selected, and touch-selection editing handles and quickmenu appear. What happens instead? The text is selected, but no handles/quickmenu appear.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba8b11836c19fe995e2f321f32c4d7176535683e commit ba8b11836c19fe995e2f321f32c4d7176535683e Author: W. James MacLean <wjmaclean@chromium.org> Date: Tue Oct 24 20:44:13 2017 Fix finding top-level root in RenderWidgetHostViewGuest. The current code in RenderWidgetHostViewGuest::GetTouchSelectionControllerClientManager() fails to consider the case of a PDF inside another RenderWidgetHostViewGuest/ChildFrame. This means that touch-selection editing fails for a PDF being displayed inside a WebView, for example using the BrowserSample app. This CL uses GetRootView() instead, which does a better job of handling the pdf-in-a-webview case. Bug: 777851 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I4f8be98e88a280da7242266dfec6d06fc3934fed Reviewed-on: https://chromium-review.googlesource.com/735507 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#511252} [modify] https://crrev.com/ba8b11836c19fe995e2f321f32c4d7176535683e/content/browser/frame_host/render_widget_host_view_guest.cc
,
Oct 24 2017
,
Oct 25 2017
Tested the issue on Windows 10 - touchscreen laptop using Chrome version 64.0.3249.0 as per the steps mentioned in comment #0. Observed that fix is working as expected and no issues observed that the text was selected, and touch-selection editing handles and quickmenu appeared as expected. Attaching screen cast of Windows 10 - touchscreen laptop for reference. Unable to test this issue on Ubuntu 14.04 as Touchscreen Laptop is not available at TE-India team. Hence adding 'TE-NeedsTriageFromMTV' for verifying this issue on touch screen linux. Thanks...!! |
|||
►
Sign in to add a comment |
|||
Comment 1 by wjmaclean@chromium.org
, Oct 24 2017