Remove old ui and strings that are not needed anymore.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0f7a9358393ecf4d3d4cf2cbdc86b1dcae306fa commit e0f7a9358393ecf4d3d4cf2cbdc86b1dcae306fa Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Oct 26 16:11:52 2017 Remove history.google.com link The link was replaced by a myactivity.google.com link Bug: 777842 Change-Id: I0c7e8a798d4fabd1d98d9f1a7b7d37ea7f4733d5 Reviewed-on: https://chromium-review.googlesource.com/735157 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#511836} [modify] https://crrev.com/e0f7a9358393ecf4d3d4cf2cbdc86b1dcae306fa/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java [modify] https://crrev.com/e0f7a9358393ecf4d3d4cf2cbdc86b1dcae306fa/chrome/android/java/strings/android_chrome_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e85f43e14908f7372bf291d805bf73205a7aafe0 commit e85f43e14908f7372bf291d805bf73205a7aafe0 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Nov 09 13:39:10 2017 Remove old ClearBrowsingData code The new ClearBrowsingData dialog has been launched in M60, this CL cleans up code of the old dialog and removes overhead caused by having two versions of the dialog. The ic_info_grey.png icon isn't used anymore, so it is removed. Some anonymous classes are converted to lambdas. The TabsInCBD flag is removed from Android as well. Bug: 777842 Change-Id: I7c1541e295bc8965bf4c7ccbc09a2c8f0843be31 Reviewed-on: https://chromium-review.googlesource.com/739561 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#515159} [delete] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/chrome/android/java/res/drawable-hdpi/ic_info_grey.png [delete] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/chrome/android/java/res/drawable-mdpi/ic_info_grey.png [delete] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/chrome/android/java/res/drawable-xhdpi/ic_info_grey.png [delete] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/chrome/android/java/res/drawable-xxhdpi/ic_info_grey.png [delete] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/chrome/android/java/res/drawable-xxxhdpi/ic_info_grey.png [delete] https://crrev.com/d8539ab55438704d7cfa1959574648963e20ad72/chrome/android/java/res/xml/clear_browsing_data_preferences.xml [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/res/xml/privacy_preferences.xml [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataBridge.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesAdvanced.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/java_sources.gni [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/browser/about_flags.cc [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/browser/android/browsing_data/browsing_data_bridge.cc [modify] https://crrev.com/e85f43e14908f7372bf291d805bf73205a7aafe0/chrome/browser/android/preferences/pref_service_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e428ad32252e68b96b3aeece6a35f08a36c62130 commit e428ad32252e68b96b3aeece6a35f08a36c62130 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Nov 10 12:26:03 2017 Remove ClearBrowsingDataTabCheckbox Move code from CBDTabCheckbox to CBDCheckbox. Replace View.OnTouchListener with lambda. Fully remove ClearBrowsingDataPreferencesTab.java. Bug: 777842 Change-Id: I57c668b5a82de74605d57b01647c6b7376cabe21 Reviewed-on: https://chromium-review.googlesource.com/758678 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#515534} [modify] https://crrev.com/e428ad32252e68b96b3aeece6a35f08a36c62130/chrome/android/java/res/layout/clear_browsing_data_tab_content.xml [modify] https://crrev.com/e428ad32252e68b96b3aeece6a35f08a36c62130/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/e428ad32252e68b96b3aeece6a35f08a36c62130/chrome/android/java/res/xml/clear_browsing_data_preferences_tab.xml [modify] https://crrev.com/e428ad32252e68b96b3aeece6a35f08a36c62130/chrome/android/java/src/org/chromium/chrome/browser/preferences/ClearBrowsingDataCheckBoxPreference.java [delete] https://crrev.com/5f1936b1889768f8e386e8c153a58d5c245e942e/chrome/android/java/src/org/chromium/chrome/browser/preferences/ClearBrowsingDataTabCheckBoxPreference.java [modify] https://crrev.com/e428ad32252e68b96b3aeece6a35f08a36c62130/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesBasic.java [delete] https://crrev.com/5f1936b1889768f8e386e8c153a58d5c245e942e/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTab.java [modify] https://crrev.com/e428ad32252e68b96b3aeece6a35f08a36c62130/chrome/android/java_sources.gni
Android is done. Desktop should probably wait for at least a month until the dialog is in stable.
Comment 1 by bugdroid1@chromium.org
, Oct 26 2017