Regression: Unable to perform operations in 'Attach a photo' overlay of hangouts app |
||||||||
Issue descriptionChrome Version:64.0.3246.0 dev OS:windows,Ubuntu 14.04,Chrome OS Test URL: https://chrome.google.com/webstore/search/hangouts?utm_source=chrome-ntp-icon&_category=apps What steps will reproduce the problem? (1)Sign into Chrome,add the Google Hangouts App by using above URL (2)Launch app ->select a user -> click on 'Attach a Photo' and try to upload photo by 'select a photo from your computer' and Observe(kindly refer video) Actual: Unable to upload photo from computer Expected: Should be able to upload photo This is a Regression issue broken in M-63 Manual Bisect Info: ------------------- Good Build:63.0.3223.0(503964) Bad Build :63.0.3225.0(504540)
,
Oct 24 2017
Reprod on M63-ChromeOS:10032.14.0/63.0.3239.17
,
Oct 24 2017
Assigning to wjmaclean@ who's currently looking at this.
,
Oct 25 2017
There is a CL to fix this up for review at: https://chromium-review.googlesource.com/c/chromium/src/+/738278 We expect to get it landed within the next day or so.
,
Oct 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a21ff3d498fdbdc0114fad1cdd127f7675614eb5 commit a21ff3d498fdbdc0114fad1cdd127f7675614eb5 Author: W. James MacLean <wjmaclean@chromium.org> Date: Sat Oct 28 13:04:24 2017 GuestViewMessageFilter should update the embedder web contents before attach. GuestViewMessageFilter::OnAttachToEmbedderFrame() up until now assumed the guest was created with the WebContents* that will be the final owner. This works for WebViews created in static HTML or from JS in the embedder, but can fail if window.open is used, and the embedder web contents may be created along with the new window. This function should instead look up the embedder WebContents* from the provided embedder local frame id, and use that to override in the call to GuestViewBase::WillAttach(). Bug: 777839 Change-Id: I4a33ecf3aaab6dbd645835191247670a3dccd1f3 Reviewed-on: https://chromium-review.googlesource.com/738278 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512399} [modify] https://crrev.com/a21ff3d498fdbdc0114fad1cdd127f7675614eb5/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/a21ff3d498fdbdc0114fad1cdd127f7675614eb5/chrome/test/data/extensions/platform_apps/web_view/shim/main.js [add] https://crrev.com/a21ff3d498fdbdc0114fad1cdd127f7675614eb5/chrome/test/data/extensions/platform_apps/web_view/shim/new_window_main.html [modify] https://crrev.com/a21ff3d498fdbdc0114fad1cdd127f7675614eb5/components/guest_view/browser/guest_view_message_filter.cc [modify] https://crrev.com/a21ff3d498fdbdc0114fad1cdd127f7675614eb5/content/public/test/browser_test_utils.cc [modify] https://crrev.com/a21ff3d498fdbdc0114fad1cdd127f7675614eb5/content/public/test/browser_test_utils.h
,
Oct 29 2017
,
Oct 29 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29 2017
Before we approve merge to M63, could you pls confirm change listed at #5 is well baked/verified in Canary, having enough automation coverage and safe to merge to M63?
,
Oct 30 2017
I think we can say 'yes' to the latter two conditions, so let's let it run until it's been in canary for a bit (and perhaps verified on canary as well).
,
Oct 31 2017
Verified the issue on win-7,Ubuntu 14.04,Mac OS 10.12.6 using chrome version M-64 #64.0.3254.0 and issue is fixed. Able to upload the photo. Adding TE-Verified labels. Thanks!
,
Oct 31 2017
Issue 282477 has been merged into this issue.
,
Oct 31 2017
Approving merge to M63 branch 3239 based on comment #9 & #10. Please merge ASAP so we can pick it up for tomorrow's Beta release. Thank you.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fe084ad1a028c060fcacbb6a027e6b703e8e8f9 commit 0fe084ad1a028c060fcacbb6a027e6b703e8e8f9 Author: W. James MacLean <wjmaclean@chromium.org> Date: Tue Oct 31 17:55:21 2017 GuestViewMessageFilter should update the embedder web contents before attach. GuestViewMessageFilter::OnAttachToEmbedderFrame() up until now assumed the guest was created with the WebContents* that will be the final owner. This works for WebViews created in static HTML or from JS in the embedder, but can fail if window.open is used, and the embedder web contents may be created along with the new window. This function should instead look up the embedder WebContents* from the provided embedder local frame id, and use that to override in the call to GuestViewBase::WillAttach(). TBR=wjmaclean@chromium.org (cherry picked from commit a21ff3d498fdbdc0114fad1cdd127f7675614eb5) Bug: 777839 Change-Id: I4a33ecf3aaab6dbd645835191247670a3dccd1f3 Reviewed-on: https://chromium-review.googlesource.com/738278 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by: Lucas Gadani <lfg@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512399} Reviewed-on: https://chromium-review.googlesource.com/747383 Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#316} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/0fe084ad1a028c060fcacbb6a027e6b703e8e8f9/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/0fe084ad1a028c060fcacbb6a027e6b703e8e8f9/chrome/test/data/extensions/platform_apps/web_view/shim/main.js [add] https://crrev.com/0fe084ad1a028c060fcacbb6a027e6b703e8e8f9/chrome/test/data/extensions/platform_apps/web_view/shim/new_window_main.html [modify] https://crrev.com/0fe084ad1a028c060fcacbb6a027e6b703e8e8f9/components/guest_view/browser/guest_view_message_filter.cc [modify] https://crrev.com/0fe084ad1a028c060fcacbb6a027e6b703e8e8f9/content/public/test/browser_test_utils.cc [modify] https://crrev.com/0fe084ad1a028c060fcacbb6a027e6b703e8e8f9/content/public/test/browser_test_utils.h |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rkalavakuntla@chromium.org
, Oct 24 2017Owner: lfg@chromium.org
Status: Assigned (was: Untriaged)