New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777821 link

Starred by 5 users

Issue metadata

Status: Fixed
Merged: issue 399316
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Chrome started to ignore action-middle-click-titlebar

Reported by markinho...@gmail.com, Oct 24 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

Steps to reproduce the problem:
1. Middle-click any empty space in the title bar (tabs bar).

What is the expected behavior?
None.

What went wrong?
This annoying issue is back. I had this when I first started using Google Chrome on Linux Mint. Because Chrome don't have a title bar (it's the same as the tabs bar and I love it), sometimes when I middle clicked a tab to close it, it minimized my window. I found out that it was a Cinnamon window setting and that I could configure it. After changing the 'action-middle-click-titlebar' to 'none' it stopped annoying me, until Chrome decided to start ignoring the setting. Now it just does not respect my choice.

Did this work before? N/A 

Chrome version: 62.0.3202.62  Channel: stable
OS Version: Linux Mint 18.2
Flash Version:
 
Labels: Needs-Triage-M62
Cc: sc00335...@techmahindra.com
Components: -UI UI>Browser>TabStrip IO>Mouse
Labels: TE-NeedsTriageFromMTV Triaged-ET
Unable to reproduce this issue on Ubuntu 14.04 with 62.0.3202.62. Clicking empty space on Title bar/Tabstrip makes window minimized.

As Chrome ET Team doesn't have Linux Mint 18.2, could someone from MTV team take a look into this.

Thanks!
Did you middle clicked title bar and it got minimized? That's the issue, I disabled that feature and it is still happening. I use middle click to close tabs, and sometimes when I do that, it minimizes my window.
I can reproduce this on Ubuntu Gnome 17.04.

It looks like this was broken by the new gtk3 ui.

This code reads the middle click action: https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/nav_button_layout_manager_gconf.cc?sq=package:chromium&dr=CSs

This one does not: https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/nav_button_layout_manager_gtk3.cc?sq=package:chromium&dr=CSs


There's also an old issue about using dconf instead of gconf: https://bugs.chromium.org/p/chromium/issues/detail?id=399316#c11
I'm guessing that becomes irrelevant now, since you're reading the settings in a different way for gtk3.


Also, I'm going to repeat what I said 5 years ago (https://bugs.chromium.org/p/chromium/issues/detail?id=132061#c6). Middle clicking to make the window suddenly disappear behind all other windows is a marginally useful feature that becomes incredibly annoying with Chrome because you're regularly middle clicking near the title bar (to close tabs). If you're not familiar with this obscure feature, you'll be wondering why your window suddenly disappeared. It would be better to default to no action if you can't read the config or you don't recognize the DE.

What makes this worse is that you're hard-coding in exceptions, e.g. for KDE4 and KDE5 (https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/gtk_ui.cc?q=KDE5&dr=C&l=336). What happens when KDE6 is released? You'll suddenly have middle click to lower back. There's no point in doing that. A KDE user can easily set the relevant Gnome setting. Chrome should respect it regardless of DE.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ed8d96195d9c85940b38681f6e356aac9e0134e

commit 3ed8d96195d9c85940b38681f6e356aac9e0134e
Author: Nikola Kovacs <nikola.kovacs@gmail.com>
Date: Mon Oct 30 18:55:42 2017

Respect GTK3 gtk-titlebar-middle-click setting

When using GTK2, Chromium respects the metacity setting that determines
what to do when the title bar is middle clicked.

There is a similar GTK3 setting for client-side decorated windows,
gtk-titlebar-middle-click, which was ignored by Chromium when using GTK3.
This change makes it respect the GTK3 setting.

Bug:  777821 
Change-Id: I4a1cb0af4f7ec4e74e8c9de789f52ea92b1be171
Reviewed-on: https://chromium-review.googlesource.com/743624
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512559}
[modify] https://crrev.com/3ed8d96195d9c85940b38681f6e356aac9e0134e/AUTHORS
[modify] https://crrev.com/3ed8d96195d9c85940b38681f6e356aac9e0134e/chrome/browser/ui/libgtkui/nav_button_layout_manager_gtk3.cc
[modify] https://crrev.com/3ed8d96195d9c85940b38681f6e356aac9e0134e/chrome/browser/ui/libgtkui/nav_button_layout_manager_gtk3.h

Labels: Needs-Feedback
thomasanderson@ Tested this issue on Ubuntu 14.04 using the latest Canary 64.0.3254.0 by following the steps mentioned in the original comment.
Can observe that on middle-clicking on the empty space of the tab, tab is getting closed.
Attached is the screen cast of the issue after the fix was landed.

Can you please check and confirm if the fix is working as intended or no?

Thanks...
777821.webm
4.4 MB View Download
How can I install Chrome Canary on Ubuntu? On chrome's repository, there is only google-chrome-stable, google-chrome-beta and google-chrome-unstable packages. I tested those 3 and every one of them had the problem.

One thing that I noticed is that the window is not minimized, as I stated in the original comment, but rather sent to the background. As most of the time I had another window maximized, I thougt that it got minimized, but when there is no maximized window, you can see that it is sent to the background, as the restored windows will come to top.

To accurately reproduce the problem, one should click on an empty space at title bar and not on the tabs. That way, the window will be sent to background consistently, while clicking on tabs it happens, but very rarely.
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 31 2017

Cc: susanjuniab@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "susanjuniab@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Finally a version above 64.0.3254.0 reached the Google Chrome's Debian repository and I was able to test it (google-chrome-unstable_64.0.3260.2-1_amd64.deb) and I'm glad to say that the fix is working. Hope that it get to the stable branch soon. 
 Issue 784491  has been merged into this issue.
Cc: thomasanderson@chromium.org
Status: Fixed (was: Unconfirmed)
This should be fixed in M64.  PLMK if this needs to be merged to M63.
Mergedinto: 399316
Status: Duplicate (was: Fixed)
Well Thomas, it's an issue that have a fix. As Chrome 63 is not in beta yet, it would be good to have the fix in it. Yet I'm not a programmer and can't tell if the fix is harmless or not and if it should wait for being applied. For me, I would like to have the fix right now :)

Comment 14 by lfg@chromium.org, Dec 14 2017

Owner: thomasanderson@chromium.org
Status: Assigned (was: Duplicate)
After r512559 landed, middle-click stopped working for me. I've had middle-click sending the window to the back, and it works on every window except Chrome now. I'm using cinnamon as my window manager.

Thomas, can you or someone else take a look?

it's most likely an error in your config/DE.  please see  issue 784491  and the gtk3 related debugging in there.
lfg@: That's a bug in cinnamon-settings-daemon.  It's supposed to provide all Xsettings, including Gtk/TitlebarMiddleClick that you're interested in, but does not.  I've filed a bug here https://github.com/linuxmint/cinnamon-settings-daemon/issues/211

vapier@ provided a workaround here:
https://bugs.chromium.org/p/chromium/issues/detail?id=784491#c10

Comment 17 by lfg@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)
Thanks for the quick reply, vapier@'s workaround works for me. I'll paste it here again for those that end up here:

Manually create a .config/gtk-3.0/settings.ini with:
  [Settings]
  gtk-titlebar-middle-click=lower

I'll close this again as fixed. Hopefully cinnamon will fix this upstream.

Sign in to add a comment