Regression: User name is not seen when we hover mouse over password suggestion
Reported by
vineetha...@etouch.net,
Oct 24 2017
|
||||
Issue descriptionChrome Version: 64.0.3248.0 03ab3c4833605018d8bd5c2cd5efb94434450407-refs/heads/master@{#510988}(32/64-bit) OS: Win(7,8,10), Mac(10.12.6, 10.13.1) and Linux(14.04 LTS). Pre-condition: Valid login credentials for "www.facebook.com" or "www.twitter.com" should be saved in "Manage passwords" for chrome. Steps to reproduce: 1.Launch Chrome, navigate to "www.facebook.com" or "www.twitter.com" and try to log in. 2.Observe that saved login credentials are auto populated in the user name and password field. 3.In password text field try to hover mouse over the password suggestion and observe. Actual Result: User name is not seen when we try to hover mouse over password suggestion. Expected Result: User name should be seen when we try to hover mouse over password suggestion. This is regression issue broken in ‘M-64’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 64.0.3244.0(Revision: 509945) Bad Build: 64.0.3245.0(Revision: 510270) You are probably looking for a change made after 509960 (known good), but no later than 509961 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e73f847bc53b227cb7cf88f7f9d1ba19c3d86108..962a26fe7d0355903d4c2721faddcbe51e0ee45c Suspect: https://chromium.googlesource.com/chromium/src/+/962a26fe7d0355903d4c2721faddcbe51e0ee45c @sebsg: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Oct 24 2017
+Vadym +Maxim I'm pretty sure this is due to my change that uses placeholder for autofill suggestions now. Could you point me to the code where this feature lives so I can take a look and update the logic? Thanks!
,
Oct 24 2017
Thanks Sebastian for looking into this. I believe you're looking for PasswordAutofillAgent::PreviewSuggestion.
,
Oct 24 2017
I debugged a little bit ( I like such bugs:) ). The problem is that here https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp?q=TextFieldInputType.cpp&sq=package:chromium&dr&l=474 in some cases CSSValueNone is set. I think that just setting always CSSValueBlock is a good solution (I've checked it fixes the problem).
,
Oct 24 2017
Good investigation! The problem is here that the UpdatePlaceholderVisibility method is not called in this specific situation. It is usually called when the suggested value is set, but not in this case. I'll make sure it's called, this should make sure the right CSSValue is set. I'll fix it today and send you the CL. Thanks!
,
Oct 27 2017
sebsg@, Friendly ping to get an update on this issue as it is marked as beta blocker. Thanks..!
,
Oct 27 2017
The fix got LGTM. I believe the author will land it today. https://chromium-review.googlesource.com/c/chromium/src/+/739794
,
Oct 30 2017
sebsg@, As per C#7,please land fix for this issue as it is marked as beta blocker. Thanks in advance..!
,
Oct 30 2017
It's in the CQ right now. Thanks!
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b83c312d41040d0ad31430952d935539c34d05a commit 4b83c312d41040d0ad31430952d935539c34d05a Author: Sebastien SG <sebsg@chromium.org> Date: Mon Oct 30 18:48:09 2017 [Autofill] Fix username suggestion display when field is already filled. The problem was that the placeholder visibility was not updated in this particular case. It used to be set when values were suggested for the first time but usernames are filled in the page without a preview. The placeholder's visibility is now updated everytime the view is updated. Bug: 777819 Change-Id: I9b85553f8186f05330207bd083e3fe7fb11395e9 Reviewed-on: https://chromium-review.googlesource.com/739794 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#512554} [modify] https://crrev.com/4b83c312d41040d0ad31430952d935539c34d05a/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-empty-suggested-value-expected.txt [modify] https://crrev.com/4b83c312d41040d0ad31430952d935539c34d05a/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt [modify] https://crrev.com/4b83c312d41040d0ad31430952d935539c34d05a/third_party/WebKit/LayoutTests/fast/forms/suggested-value-expected.txt [modify] https://crrev.com/4b83c312d41040d0ad31430952d935539c34d05a/third_party/WebKit/LayoutTests/platform/win7/fast/forms/suggested-value-expected.txt [modify] https://crrev.com/4b83c312d41040d0ad31430952d935539c34d05a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
,
Oct 30 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Oct 24 2017