New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777818 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 772325



Sign in to add a comment

Add v8.speedometer-future and v8.speedometer2-future to the perf waterfall

Project Member Reported by hablich@chromium.org, Oct 24 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3a375964a43a0e4bbc9bed4c318abee8d38c6b3

commit c3a375964a43a0e4bbc9bed4c318abee8d38c6b3
Author: Michael Hablich <hablich@chromium.org>
Date: Tue Oct 24 19:13:03 2017

[benchmarks] Add --future variants for Speedometer1/2

This enables V8 developers to see the performance
of upcoming VM features that are not yet ready
to be shipped.

R=nednguyen@google.com

Bug: 772325,  777818 
Change-Id: I718c7494609dd89833c5a27cd507b5e57981435a
Reviewed-on: https://chromium-review.googlesource.com/735148
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511227}
[modify] https://crrev.com/c3a375964a43a0e4bbc9bed4c318abee8d38c6b3/tools/perf/benchmarks/speedometer.py
[modify] https://crrev.com/c3a375964a43a0e4bbc9bed4c318abee8d38c6b3/tools/perf/benchmarks/speedometer2.py
[modify] https://crrev.com/c3a375964a43a0e4bbc9bed4c318abee8d38c6b3/tools/perf/core/perf_data_generator.py

Labels: -Pri-2 Pri-1
Ping on this.
Blocking: 772325
Owner: ashleymarie@chromium.org
Ashley: can you take this?
Cc: hablich@chromium.org
How long does it take to run the benchmarks in seconds? We need that number to determine which bot(s) to schedule them on.
Thanks!
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d05be3d7ce4c54f6e63425af010c54d613dbec

commit a5d05be3d7ce4c54f6e63425af010c54d613dbec
Author: Ashley Enstad <ashleymarie@chromium.org>
Date: Mon Nov 13 22:09:00 2017

Schedule speedometer-future and speedometer2-future benchmarks

This change adds speedometer-future and speedometer2-future benchmarks
to the perf waterfall. These benchmarks enable v8 developers to see the
performance of upcoming VM features that aren't ready to be shipped yet.

BUG= chromium:777818 

Change-Id: If77b51046a279706d6f48d6a73733f068a55e91d
Reviewed-on: https://chromium-review.googlesource.com/764403
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#516073}
[modify] https://crrev.com/a5d05be3d7ce4c54f6e63425af010c54d613dbec/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/a5d05be3d7ce4c54f6e63425af010c54d613dbec/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/a5d05be3d7ce4c54f6e63425af010c54d613dbec/tools/perf/benchmark.csv
[modify] https://crrev.com/a5d05be3d7ce4c54f6e63425af010c54d613dbec/tools/perf/core/benchmark_sharding_map.json
[modify] https://crrev.com/a5d05be3d7ce4c54f6e63425af010c54d613dbec/tools/perf/core/perf_data_generator.py

Status: Fixed (was: Assigned)
They are now running on the perf waterfall so I'm going to mark this one fixed!

Sign in to add a comment