Regression:Separator line is missing in Add a new page and use current page under On startup option of setting page.
Reported by
shruti.j...@etouch.net,
Oct 24 2017
|
|||||
Issue descriptionChrome Version: 64.0.3248.0 (Official Build)03ab3c4833605018d8bd5c2cd5efb94434450407-refs/heads/master@{#510988}(64-bit) OS: Win(7,8,10), Mac(10.12.6,10.13.1) and Linux(14.04 LTS). Steps to reproduce: 1.Launch chrome and Navigate to chrome://settings. 2.Go to On startup 3.Click on open specific page or set of pages option0 and observe Actual Result: Separator line is missing in Add a new page and use current page. Expected Result: Separator line should be present between Add a new page and use current page. This is regression issue broken in ‘M-64’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 64.0.3245.0 (Revision:510271). Bad Build: 64.0.3246.0 (Revision:510623). You are probably looking for a change made after 510518 (known good), but no later than 510519 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7126e7c368d0d7ce514cd104178d87949d4de991..7492bd8fb7d69396841bf4a53a4ae6743843bcdb Suspect:https://chromium.googlesource.com/chromium/src/+/7492bd8fb7d69396841bf4a53a4ae6743843bcdb @dschuyler:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Oct 24 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36cc4912f6273c41a703abf6011f34666fc96b5f commit 36cc4912f6273c41a703abf6011f34666fc96b5f Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Oct 26 00:27:00 2017 [MD settings] fix line between startup urls buttons This CL adds (re-adds) a grey separator lines above the startup url button rows. Bug: 777810 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I61015ee3a56172ca5deda741dfd3d07e86cdd9a7 Reviewed-on: https://chromium-review.googlesource.com/735518 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#511661} [modify] https://crrev.com/36cc4912f6273c41a703abf6011f34666fc96b5f/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
,
Oct 26 2017
,
Oct 26 2017
Note : Rechecked the above issue on Win(7,8,10), Mac(10.12.6,10.13.1) and Linux(14.04 LTS) OS with latest canary chrome version :64.0.3250.0 and the issue is not reproducible. Kindly refer the attached screenshot for reference.
,
Nov 8 2017
Verified on M64 dev build (10109.0.0, 64.0.3261.0). |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dschuyler@chromium.org
, Oct 24 2017