Add screenshot.

Deleted: Simulator Screen Shot - iPhone X - 2017-10-24 at 12.27.20.png 177 KB

	Simulator Screen Shot - iPhone X - 2017-10-24 at 12.27.20.png 177 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08637853d9272c18d02c7c6225f54766cb935a1f

commit 08637853d9272c18d02c7c6225f54766cb935a1f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Oct 24 15:22:15 2017

Fix glitches in the Toolbar

This CL fixes two glitches:
- It resizes the tappable area of the NTP's omnibox to prevent it from
   overlapping with the stack button.
- It puts the omnibox controls (clear and cancel) inside the safe area.

Bug:  777807 ,  777864 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I96ee42df3bbafe9a76f811b62b6ac2fbaff1f40e
Reviewed-on: https://chromium-review.googlesource.com/735327
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511150}
[modify] https://crrev.com/08637853d9272c18d02c7c6225f54766cb935a1f/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/08637853d9272c18d02c7c6225f54766cb935a1f/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

The buttons are fixed, but the white background is only inside the safe area.
I don't think there is an easy fix, maybe we will only fix it on M64. WDYT?
(In the screenshot, the additional spacing on the top will be removed, this is only about the one on the sides).

Deleted: Simulator Screen Shot - iPhone X - 2017-10-24 at 17.27.34.png 457 KB

	Simulator Screen Shot - iPhone X - 2017-10-24 at 17.27.34.png 457 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0146e6dedea8cc695b0952f4fbd29c41c227090e

commit 0146e6dedea8cc695b0952f4fbd29c41c227090e
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Oct 25 15:27:52 2017

Fix glitches in the Toolbar

This CL fixes two glitches:
- It resizes the tappable area of the NTP's omnibox to prevent it from
   overlapping with the stack button.
- It puts the omnibox controls (clear and cancel) inside the safe area.

Bug:  777807 ,  777864 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I96ee42df3bbafe9a76f811b62b6ac2fbaff1f40e
Reviewed-on: https://chromium-review.googlesource.com/735327
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511150}(cherry picked from commit 08637853d9272c18d02c7c6225f54766cb935a1f)
Reviewed-on: https://chromium-review.googlesource.com/737634
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#215}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/0146e6dedea8cc695b0952f4fbd29c41c227090e/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/0146e6dedea8cc695b0952f4fbd29c41c227090e/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Please close if fixed

This is no longer RBS but there is still a bug (grey insets on the sides) which needs to be fixed.

This is no longer RBS for 63? It still looks really bad on ntp omnibox typing, ptal:
Screenshot: https://drive.google.com/file/d/1phynpacKFnkWkicMWDaPrHNEL6oPAiP6/view

This is about the grey on the sides only. Not the fact that it is too high.
I tried fixing it, with the current toolbar it would be too risky to fix it on branch.

Thanks, I've filed  issue 782639  to track this.

gambard@ so far all the approaches taken to fix this involve significant amounts of refactoring.  I'm inclined to say it's not worth it if we are already refactoring the toolbar regardless.  What do you think?

I think it is fine to keep it that way if we can land the "clean" toolbar in M65/66.

I think we can mark this as fixed as the other issues are fixed.  Filed  crbug.com/785284  to track the grey bars outside the safe area, which we can target for M66 with the refactored toolbar.