Regression: Close 'x' button not working on thumbnails of Bing.
Reported by
shruti.j...@etouch.net,
Oct 24 2017
|
||||||
Issue descriptionChrome Version: 64.0.3248.0 (Official Build)03ab3c4833605018d8bd5c2cd5efb94434450407-refs/heads/master@{#510988}(64-bit) OS: Win(7,8,10), Mac(10.12.6) and Linux(14.04 LTS). Steps to reproduce: 1.Launch chrome and Navigate to chrome://settings. 2.Go to Search engine and change it to Bing. 3.Visit some pages and open new Tab which shows Bing page having Thumbnails. 4.Click on 'x' button of thumbnails and observe. Actual Result: Close 'x' button not working on thumbnails of Bing. Expected Result: Close 'x' button should work on thumbnails of Bing. This is regression issue broken in ‘M-64’ and will soon update bisect-info Using the per-revision bisect providing the bisect results, Good Build: 64.0.3244.0(Revision:509945). Bad Build: 64.0.3245.0(Revision:510270).
,
Oct 24 2017
Tagging with blocker label, please undo if not the case.
,
Oct 24 2017
Yup, that's mine. Turns out the Bing NTP passes the to-be-blacklisted ID as a string rather than an int, and Gin is more strict about that than the v8::Extension was.
,
Oct 24 2017
,
Oct 24 2017
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d0633dde4a03e0cf3411a04554e73559c835095 commit 7d0633dde4a03e0cf3411a04554e73559c835095 Author: Marc Treib <treib@chromium.org> Date: Tue Oct 24 15:23:35 2017 embeddedSearch API: Be less strict with argument types The API functions deleteMostVisitedItem and undoMostVisitedItemDeletion need an int parameter, but are called with int-inside-a-string by third-party NTPs. This was legal with the old v8::Extension implementation, but the Gin implementation from crrev.com/c/700443 is stricter. This CL relaxes the implementation so that strings that can be converted to int are allowed again. Bug: 777789 Change-Id: I784973ad7bb3626ff58c0d6831053a93e00a8016 Reviewed-on: https://chromium-review.googlesource.com/735608 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#511152} [modify] https://crrev.com/7d0633dde4a03e0cf3411a04554e73559c835095/chrome/browser/ui/search/local_ntp_browsertest.cc [modify] https://crrev.com/7d0633dde4a03e0cf3411a04554e73559c835095/chrome/renderer/searchbox/searchbox_extension.cc
,
Oct 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by shruti.j...@etouch.net
, Oct 24 2017Labels: hasbisect-per-revision
Owner: treib@chromium.org
Status: Assigned (was: Unconfirmed)