Issue 777775 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	hajimehoshi@chromium.org
Closed:	Nov 2017
Cc:	japhet@chromium.org nhiroki@chromium.org altimin@chromium.org haraken@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Task

Blocked on:
issue 710364

Remove TaskRunnerHelper

Project Member Reported by hajimehoshi@chromium.org, Oct 24 2017

Issue description

Now that TaskRunnerHelper just offers simple 'redirect' functions, let's move the implementations to the corresponding classes like Document->GetTaskRunner(type).

For WorkerThread, there is a plan to rename or refactor, so let's wait for that.

Comment 1 by hajimehoshi@chromium.org, Oct 24 2017

Blockedon: 710364

Comment 2 by hajimehoshi@chromium.org, Oct 24 2017

Labels: -Type-Bug Type-Task

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89

commit e6e920bb57b4fb48a23e8f6d656325fecdc6ea89
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Oct 24 12:02:48 2017

Refactoring: Move implementation of TaskRunnerHelper to the corresponding classes

This is one step of removing TaskRunnerHelper.

Bug:  777775 
Change-Id: I151977cbae75f214b1ec16c223315d3780b1ffa7
Reviewed-on: https://chromium-review.googlesource.com/734986
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511100}
[modify] https://crrev.com/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp
[modify] https://crrev.com/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
[modify] https://crrev.com/e6e920bb57b4fb48a23e8f6d656325fecdc6ea89/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h

Comment 4 by hajimehoshi@chromium.org, Oct 24 2017

Hm, I realized that it looks like hard to move the impl of Get(TaskType type, ScriptState* script_state) to ScriptState since ScriptState is in platform/binding and ExecusionContext is in core/dom.

Comment 5 by haraken@chromium.org, Oct 24 2017

Maybe can we deprecate Get(TaskType type, ScriptState* script_state)? There are only 15 occurrences, so it wouldn't be that hard to replace it with script_state->GetExecutionContext()->GetTaskRunner() etc.

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2023dfaa5cf30d61426031c5b450cec3bdb0cc05

commit 2023dfaa5cf30d61426031c5b450cec3bdb0cc05
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Oct 26 16:30:51 2017

Refactoring: Add LocalFrame::GetTaskRunner

This CL replaces frame->FrameScheduler()->GetTaskRunner() with
frame->GetTaskRunner() so that it would be easier to deprecate
TaskRunnerHelper's Get functions.

Bug:  777775 
Change-Id: I6cf90b1c17909baef1b9fa46893786e63cb71778
Reviewed-on: https://chromium-review.googlesource.com/737606
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511844}
[modify] https://crrev.com/2023dfaa5cf30d61426031c5b450cec3bdb0cc05/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2023dfaa5cf30d61426031c5b450cec3bdb0cc05/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp
[modify] https://crrev.com/2023dfaa5cf30d61426031c5b450cec3bdb0cc05/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/2023dfaa5cf30d61426031c5b450cec3bdb0cc05/third_party/WebKit/Source/core/frame/LocalFrame.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/997147ca1f807a5baa8c623f35d07dea1d60247d

commit 997147ca1f807a5baa8c623f35d07dea1d60247d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Oct 27 06:24:31 2017

Refactoring: Make ExecutionContext::GetTaskRunner pure virtual

This CL addresses on nhiroki's comment on the CL https://chromium-review.googlesource.com/c/chromium/src/+/734986

Bug:  777775 
Change-Id: Ib6a6954c1b39459d455d6efa7c11515bdd76006f
Reviewed-on: https://chromium-review.googlesource.com/737714
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512105}
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/testing/NullExecutionContext.cpp
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/testing/NullExecutionContext.h
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
[modify] https://crrev.com/997147ca1f807a5baa8c623f35d07dea1d60247d/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.h

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebabb26252f83aa69c7a005402442d84d2583c56

commit ebabb26252f83aa69c7a005402442d84d2583c56
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Fri Oct 27 08:04:21 2017

Refactoring: Remove TaskRunnerHelper::Get() for ScriptState

Bug:  777775 
Change-Id: Ie7dda668c7f171bf66a505495441e87db766b8b3
Reviewed-on: https://chromium-review.googlesource.com/737915
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512122}
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/core/dom/ModulatorImplBase.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/core/timing/PerformanceObserverTest.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp
[modify] https://crrev.com/ebabb26252f83aa69c7a005402442d84d2583c56/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9e05a4900b5cb81031dbb4b2bd4629736bf9c4

commit cc9e05a4900b5cb81031dbb4b2bd4629736bf9c4
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Mon Oct 30 10:12:25 2017

Bug fix: TaskRunnerHelper::Get might crash at WebAssociatedURLLoaderImpl

Bug:  777775 
Change-Id: I261e8ece3e2f29237eb84922e5f8aaa0acd4a013
Reviewed-on: https://chromium-review.googlesource.com/742780
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512463}
[modify] https://crrev.com/cc9e05a4900b5cb81031dbb4b2bd4629736bf9c4/third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImpl.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d

commit be06aa5c2e97a1b26cd9680b2e5cc6488243c27d
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Oct 31 10:50:20 2017

Remove TaskRunnerHelper usages in core/

This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663

Bug:  777775 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ife29c5e5a6ae5f27e296e962251fc6aefef8e765
Reviewed-on: https://chromium-review.googlesource.com/746621
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512798}
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/animation/DocumentTimeline.h
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/animation/PendingAnimations.h
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/clipboard/ClipboardPromise.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/css/CSSSelectorWatch.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/dom/events/MediaElementEventQueue.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/editing/FrameCaret.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/editing/finder/TextFinder.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/editing/spellcheck/IdleSpellCheckCallback.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/exported/WebNode.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/PlatformEventController.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/ReportingContext.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/HTMLStyleElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/forms/HTMLFormControlElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/forms/HTMLInputElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/forms/HTMLSelectElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/forms/InternalPopupMenu.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/forms/SpinButtonElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/media/MediaCustomControlsFullscreenDetector.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/media/MediaRemotingInterstitial.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/input/MouseEventManager.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/intersection_observer/IntersectionObserverController.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/layout/LayoutProgress.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/IdlenessDetector.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/SubresourceFilter.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/TextTrackLoader.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderTest.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/mojo/test/MojoInterfaceInterceptor.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/scheduler/VirtualTimeTest.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/svg/SVGUseElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/timing/WorkerPerformance.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/MainThreadWorkletTest.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/be06aa5c2e97a1b26cd9680b2e5cc6488243c27d/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e06e96bed790c6a07bcc8274be6f07fb665c989

commit 2e06e96bed790c6a07bcc8274be6f07fb665c989
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Oct 31 13:28:01 2017

Remove TaskRunnerHelper usages in modules/

This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663

Bug:  777775 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I18b22b13bc9b52b4f1ae86b090c32d1521321007
Reviewed-on: https://chromium-review.googlesource.com/746623
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512809}
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandle.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverflowMenuListElement.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/media_controls/elements/MediaControlPanelElement.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/mediacapturefromelement/TimedCanvasDrawListener.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/sensor/Sensor.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/webgl/WebGLQuery.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/webgl/WebGLTimerQueryEXT.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/2e06e96bed790c6a07bcc8274be6f07fb665c989/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64946f117cd4f6442f4743202af7ffa5be2fb704

commit 64946f117cd4f6442f4743202af7ffa5be2fb704
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Oct 31 17:56:49 2017

Remove TaskRunnerHelper usages in bindings/

This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663

Bug:  777775 
Change-Id: Ifdd45ab27dfbb2fdea8e8ff0dd668e083c1f8244
Reviewed-on: https://chromium-review.googlesource.com/746603
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512870}
[modify] https://crrev.com/64946f117cd4f6442f4743202af7ffa5be2fb704/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3763897898cb65f4e60e1e33f7def429b4293259

commit 3763897898cb65f4e60e1e33f7def429b4293259
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 01 05:10:50 2017

Remove TaskRunnerHelper::Get except for WorkerThread

This is one step of all replacings at https://chromium-review.googlesource.com/c/chromium/src/+/743663

Bug:  777775 
Change-Id: Ib388098d7a6f3d1baa3b144734f470b0263f74f7
Reviewed-on: https://chromium-review.googlesource.com/748741
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513078}
[modify] https://crrev.com/3763897898cb65f4e60e1e33f7def429b4293259/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp
[modify] https://crrev.com/3763897898cb65f4e60e1e33f7def429b4293259/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h

Comment 14 by nhiroki@chromium.org, Nov 8 2017

As I replied to platform-architecture-dev, I think I cannot take a time to work on WorkerThread rename soon, so feel free to proceed without waiting for rename.

If you're interested in WorkerThread rename, feel free to take  issue 710364 . I'd really appreciate it :)

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf

commit f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Wed Nov 08 14:11:49 2017

Remove TaskRunnerHelper

Bug:  777775 
Change-Id: Iba86851cc10ba70049f08f5b713991a8b0986f2b
Reviewed-on: https://chromium-review.googlesource.com/758379
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514816}
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/dom/ModulatorImplBase.cpp
[delete] https://crrev.com/6412be800df4c5401b8f9720ecf7b3d4655a7248/third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp
[delete] https://crrev.com/6412be800df4c5401b8f9720ecf7b3d4655a7248/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/dom/events/DOMWindowEventQueue.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/frame/PlatformEventController.h
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/fullscreen/Fullscreen.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.h
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/loader/ImageLoader.h
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/timing/PerformanceObserverTest.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/ThreadedWorkletMessagingProxy.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/core/workers/WorkletModuleTreeClient.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/quota/StorageQuotaClient.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/Source/modules/webdatabase/SQLTransactionClient.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/100f7905609804cd243361aa36560bb23a5da8c5

commit 100f7905609804cd243361aa36560bb23a5da8c5
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Thu Nov 09 09:55:06 2017

Add comment to WorkerThread::GetTaskRunner

Bug:  777775 
Change-Id: I4bc9dd7f20d54a873dffd7375f027a5b4dc4cf7f
Reviewed-on: https://chromium-review.googlesource.com/760177
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515128}
[modify] https://crrev.com/100f7905609804cd243361aa36560bb23a5da8c5/third_party/WebKit/Source/core/workers/WorkerThread.h

Comment 17 by hajimehoshi@chromium.org, Nov 9 2017

Status: Fixed (was: Started)

►

Issue 777775 link

Issue metadata

Remove TaskRunnerHelper

Issue description

Comment 1 by hajimehoshi@chromium.org, Oct 24 2017

Comment 1 Deleted

Comment 2 by hajimehoshi@chromium.org, Oct 24 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 24 2017

Comment 3 Deleted

Comment 4 by hajimehoshi@chromium.org, Oct 24 2017

Comment 4 Deleted

Comment 5 by haraken@chromium.org, Oct 24 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Oct 26 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Oct 27 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Oct 27 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Oct 30 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Oct 31 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Oct 31 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Oct 31 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Nov 1 2017

Comment 13 Deleted

Comment 14 by nhiroki@chromium.org, Nov 8 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Nov 8 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Nov 9 2017

Comment 16 Deleted

Comment 17 by hajimehoshi@chromium.org, Nov 9 2017

Comment 17 Deleted

Sign in to add a comment