New issue
Advanced search Search tips

Issue 777774 link

Starred by 2 users
Status: Started
Owner:
droger@chromium.org
Cc:
msarda@chromium.org
tangltom@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[signin] Cleanup account consistency flags

Project Member Reported by droger@chromium.org, Oct 24 2017 
Once Dice is fully rolled out and Mirror code is removed from desktop, remove the corresponding functions and flags from about://flags and profile_management_switches.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da4c5442fc470317447d3784ca2fcbde268c67f6

commit da4c5442fc470317447d3784ca2fcbde268c67f6
Author: David Roger <droger@chromium.org>
Date: Fri Nov 17 08:58:29 2017

[signin] Split Dice and Mirror specific logic out of AccountReconcilor

This CL creates a AccountReconcilorDelegate class, with two subclasses
specialized for Mirror and Dice respectively.

Bug: 777774
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4bdb4ecee7d4f12e910a2704a09802c383bca9bb
Reviewed-on: https://chromium-review.googlesource.com/766368
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517347}
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/chrome/browser/signin/account_reconcilor_factory.cc
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/chrome/browser/signin/account_reconcilor_factory.h
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/chrome/browser/signin/account_reconcilor_unittest.cc
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/account_reconcilor.cc
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/account_reconcilor.h
[add] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/account_reconcilor_delegate.cc
[add] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/account_reconcilor_delegate.h
[add] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[add] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/dice_account_reconcilor_delegate.h
[add] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
[add] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/mirror_account_reconcilor_delegate.cc
[add] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/core/browser/mirror_account_reconcilor_delegate.h
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/components/signin/ios/browser/account_consistency_service_unittest.mm
[modify] https://crrev.com/da4c5442fc470317447d3784ca2fcbde268c67f6/ios/chrome/browser/signin/account_reconcilor_factory.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18d93641d811ebe9278fc98a52e60125c9a3af7a

commit 18d93641d811ebe9278fc98a52e60125c9a3af7a
Author: David Roger <droger@chromium.org>
Date: Tue Nov 28 13:39:25 2017

[signin] Remove unnecessary dependency of ProfileSyncService on Dice

SigninManager calls its observers with GoogleSigninSucceeded only the first time the user
signs in to Chrome (not in case of a reauth). The logic in the ProfileSyncService was added
initially to avoid enabling sync using an old refresh token during a reauth.

This CL removes this check as it is now obsolete.

Bug: 777774
Change-Id: I78fe5da8d270b099d9bba5fc962d810c00bba409
Reviewed-on: https://chromium-review.googlesource.com/787977
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519669}
[modify] https://crrev.com/18d93641d811ebe9278fc98a52e60125c9a3af7a/components/browser_sync/profile_sync_service.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc

commit e5b3277a4bd838864943a1d1ed3e0adcabaa86cc
Author: David Roger <droger@chromium.org>
Date: Thu Nov 30 12:05:52 2017

[signin] Move Dice migration code from //components to //chrome

Bug: 777774
Change-Id: I1481a7f967873969869f0dcd7a04ae07461f282f
Reviewed-on: https://chromium-review.googlesource.com/785950
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520515}
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/BUILD.gn
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[add] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/account_consistency_mode_manager.cc
[add] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/account_consistency_mode_manager.h
[add] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/account_consistency_mode_manager_unittest.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/account_reconcilor_factory.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/account_reconcilor_factory.h
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/chrome_signin_client.h
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/chrome_signin_client_factory.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/chrome_signin_client_factory.h
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/chrome/test/BUILD.gn
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/components/signin/core/browser/dice_account_reconcilor_delegate.h
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
[modify] https://crrev.com/e5b3277a4bd838864943a1d1ed3e0adcabaa86cc/components/signin/core/browser/signin_client.h
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 1 2018

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0961b6d984396a2515608bf0fc9424e8f9a52b93

commit 0961b6d984396a2515608bf0fc9424e8f9a52b93
Author: David Roger <droger@chromium.org>
Date: Tue Jan 30 14:48:44 2018

[signin] Remove profile_management_switches calls from component

The account consistency is now injected in the component by the embedder.
Chrome determines the current account consistency using the AccountConsistencyManager.

Note: After this CL, the meaning of the AccountConsistencyMethod values is slightly different:
- kDiceMigration means that the migration is ongoing but not completed yet.
- kDice means that Dice is enabled, either because it is forced or because the migration completed.

Bug: 777774
TBR: noyau, pkasting, treib, zea
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I82a6464bb2fa76ca219a5fe419cdc26dfe9ffdfa
Reviewed-on: https://chromium-review.googlesource.com/787231
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532866}
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/profiles/profile_downloader_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/about_signin_internals_factory.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/account_consistency_mode_manager.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/account_consistency_mode_manager.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/account_consistency_mode_manager_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/account_reconcilor_factory.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/chrome_signin_client.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/chrome_signin_client_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/chrome_signin_helper.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/signin/signin_manager_factory.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/ntp_snippets/breaking_news/subscription_manager_impl_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/about_signin_internals.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/chrome_connected_header_helper.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/chrome_connected_header_helper.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/dice_account_reconcilor_delegate.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/dice_header_helper.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/dice_header_helper.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/fake_signin_manager.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/profile_management_switches.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/profile_management_switches.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/signin_header_helper.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/signin_header_helper.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/signin_header_helper_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/signin_manager.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/signin_manager.h
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/core/browser/signin_manager_unittest.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/components/signin/ios/browser/account_consistency_service.mm
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/ios/chrome/browser/signin/about_signin_internals_factory.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/ios/chrome/browser/signin/signin_manager_factory.cc
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/ios/web_view/internal/signin/web_view_signin_manager_factory.mm
[modify] https://crrev.com/0961b6d984396a2515608bf0fc9424e8f9a52b93/services/identity/public/cpp/primary_account_access_token_fetcher_unittest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f436bae87675b5dde2b8c3c0c0cb4a46b512a11

commit 6f436bae87675b5dde2b8c3c0c0cb4a46b512a11
Author: David Roger <droger@chromium.org>
Date: Wed Jun 13 12:33:49 2018

[signin] AccountReconcilorFactory uses the per-profile account consistency

The AccountReconcilorFactory was using the value from the Finch config
experiment instead of the per-profile value. This can lead to bugs when
these differ, which happens in particular when the client ID is not set.

Bug: 777774
Change-Id: I5c67ab704be119770d919a0ce3b8a623809ef0f2
Reviewed-on: https://chromium-review.googlesource.com/1097128
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566808}
[modify] https://crrev.com/6f436bae87675b5dde2b8c3c0c0cb4a46b512a11/chrome/browser/signin/account_reconcilor_factory.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f086a5c1d9349bf4f1ed7aaf4d39bc3effe27212

commit f086a5c1d9349bf4f1ed7aaf4d39bc3effe27212
Author: David Roger <droger@chromium.org>
Date: Wed Jun 13 16:09:55 2018

[signin] DiceResponseHandler gets the account consistency from profile

DiceResponseHandler was getting it from the finch experiment, which is
not always the same as the profile.

Bug: 777774
Change-Id: I1a0e591597312b4a78f95ed5ec6ed072eaf6f972
Reviewed-on: https://chromium-review.googlesource.com/1097409
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566854}
[modify] https://crrev.com/f086a5c1d9349bf4f1ed7aaf4d39bc3effe27212/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/f086a5c1d9349bf4f1ed7aaf4d39bc3effe27212/chrome/browser/signin/dice_response_handler.h
[modify] https://crrev.com/f086a5c1d9349bf4f1ed7aaf4d39bc3effe27212/chrome/browser/signin/dice_response_handler_unittest.cc

Comment 9 by jlebel@chromium.org, Jun 14 2018

Cc: -jlebel@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90

commit f53a075d8690a6eaf6bf0fcc8080943f4b37ae90
Author: David Roger <droger@chromium.org>
Date: Mon Jun 18 14:46:48 2018

[signin] Use AccountConsistencyModeManager

This CL converts almost all the remaining code to use
AccountConsistencyModeManager. There are a few calls left in tests and
debugging code, which will be converted in a follow-up CL.

TBR=stevenjb

Bug: 777774
Change-Id: Ic2da79f6b332880e2143425c91ab50322b9d542f
Reviewed-on: https://chromium-review.googlesource.com/1099069
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568000}
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/chrome_signin_helper.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/dice_browsertest.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/dice_response_handler.h
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/process_dice_header_delegate_impl.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/process_dice_header_delegate_impl.h
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/signin/signin_promo.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/ui/signin_view_controller.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/f53a075d8690a6eaf6bf0fcc8080943f4b37ae90/chrome/browser/ui/webui/welcome_ui.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7

commit 7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7
Author: David Roger <droger@chromium.org>
Date: Wed Jun 20 15:44:49 2018

[signin] Cleanup calls to IsAccountConsistencyMirrorEnabled

IsAccountConsistencyMirrorEnabled is deprecated, because Mirror can now be enabled
on a per-profile bases.
This CL replaces the calls by the new API (AccountConsistencyModeManager) and
cleans up unnecessary calls.

TBR=sky

Bug: 777774
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I19e9ecc779b90911f6e4e63a11850417c9eddbdf
Reviewed-on: https://chromium-review.googlesource.com/1104682
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568853}
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/printing/print_dialog_cloud.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/signin/chrome_signin_client.h
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/signin/chromeos_mirror_account_consistency_browsertest.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/signin/signin_error_controller_factory.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/signin/signin_promo.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/signin/signin_promo.h
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/ui/webui/signin/inline_login_handler.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/ui/webui/signin/inline_login_handler.h
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/components/signin/core/browser/signin_client.h
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/components/signin/core/browser/signin_manager.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/components/signin/core/browser/test_signin_client.cc
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/components/signin/core/browser/test_signin_client.h
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/ios/chrome/browser/signin/ios_chrome_signin_client.h
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/ios/chrome/browser/signin/ios_chrome_signin_client.mm
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/ios/web_view/internal/signin/ios_web_view_signin_client.h
[modify] https://crrev.com/7821d1cbb73cdaee70f4e4d013fa62a3ce345cd7/ios/web_view/internal/signin/ios_web_view_signin_client.mm
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5879a9d27ce0cd505b3e7d18d8810433c45735b0

commit 5879a9d27ce0cd505b3e7d18d8810433c45735b0
Author: David Roger <droger@chromium.org>
Date: Thu Jun 21 16:17:51 2018

[signin] Fix regression in MergeSigninCredentialIntoCookieJar

The CL https://chromium-review.googlesource.com/c/chromium/src/+/1104682/9/components/signin/core/browser/signin_manager.cc
introduced a regression, leading to cookies not being merged correctly.
The cookies should be merged in all cases except Mirror, but that CL
did the opposite (only merging cookies when Mirror is enabled)

Change-Id: Ib3c5454259ff6b7ec82bb2411bcff011bc63f3e1
Bug: 777774
Reviewed-on: https://chromium-review.googlesource.com/1109976
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569287}
[modify] https://crrev.com/5879a9d27ce0cd505b3e7d18d8810433c45735b0/components/signin/core/browser/signin_manager.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/346e25c7a244148737214b7bb8e69678166bd04b

commit 346e25c7a244148737214b7bb8e69678166bd04b
Author: David Roger <droger@chromium.org>
Date: Fri Jul 06 15:08:15 2018

[signin] Move dice configuration to AccountConsistencyModeManager

The code in profile_management_switches was only used from
AccountConsistencyModeManager.
It is dangerous to leave this code exposed publicly, as this is really
an implementation detail of AccountConsistencyModeManager, and should
not be used directly.

TBR=sky

Bug: 777774
Change-Id: I88e2e36c5af7b27227a6c45d8f64139fe5ce1e07
Reviewed-on: https://chromium-review.googlesource.com/1106163
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572975}
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/BUILD.gn
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/about_flags.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/account_consistency_mode_manager.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/account_consistency_mode_manager.h
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/account_consistency_mode_manager_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/chrome_signin_helper_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/dice_browsertest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
[rename] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/scoped_account_consistency.cc
[rename] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/scoped_account_consistency.h
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/signin_ui_util_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/signin/unified_consent_helper_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/test/data/webui/signin_browsertest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/chrome/test/data/webui/signin_browsertest.h
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/components/signin/core/browser/DEPS
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/components/signin/core/browser/profile_management_switches.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/components/signin/core/browser/profile_management_switches.h
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/components/signin/core/browser/profile_management_switches_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/services/identity/public/cpp/identity_manager_unittest.cc
[modify] https://crrev.com/346e25c7a244148737214b7bb8e69678166bd04b/services/identity/public/cpp/identity_test_environment.cc

Comment 14 by benhenry@chromium.org, Aug 2

Status: Assigned (was: Available)
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3

commit a67998f93a1bc8a1be0faa08fa62b93fbbd417f3
Author: David Roger <droger@chromium.org>
Date: Wed Aug 22 18:27:03 2018

[signin] Remove code from Dice Milestone 2

Dice Milestone 3 has now be launched, and Milestone 2 is no longer needed.

TBR=ellyjones

Bug: 777774
Change-Id: Id82bb13fbd277a014bb3fb8961d8d98eecb32124
Reviewed-on: https://chromium-review.googlesource.com/1183662
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585173}
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/about_flags.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/account_consistency_mode_manager.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/account_consistency_mode_manager.h
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/account_consistency_mode_manager_unittest.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/account_reconcilor_factory.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/dice_browsertest.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/process_dice_header_delegate_impl.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/scoped_account_consistency.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/scoped_account_consistency.h
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/signin/signin_promo.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/ui/signin_view_controller.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/chrome/browser/ui/webui/signin/login_ui_test_utils.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
[modify] https://crrev.com/a67998f93a1bc8a1be0faa08fa62b93fbbd417f3/components/signin/core/browser/profile_management_switches.h
Project Member

Comment 16 by sheriffbot@chromium.org, Sep 24

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by droger@chromium.org, Sep 24

Status: Assigned (was: Available)

Comment 18 by droger@chromium.org, Nov 29

Status: Started (was: Assigned)
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/153707e1531f4233168575401a73ad4568ab5caa

commit 153707e1531f4233168575401a73ad4568ab5caa
Author: David Roger <droger@chromium.org>
Date: Thu Dec 06 12:22:30 2018

[signin] Delete DiceFixAuthErrors

This configuration is no longer enabled on any platforms.
The code can now be removed.

TBR=sky

Bug: 777774
Change-Id: Id92ef784e3ae933b21d96f8fd39deba1a4fa67a6
Reviewed-on: https://chromium-review.googlesource.com/c/1355189
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614323}
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/about_flags.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/extensions/api/identity/identity_api.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/extensions/api/identity/identity_api_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/account_consistency_mode_manager.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/account_consistency_mode_manager.h
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/account_consistency_mode_manager_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/account_reconcilor_factory.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/chrome_signin_helper_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/dice_browsertest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/dice_response_handler_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/process_dice_header_delegate_impl.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/process_dice_header_delegate_impl_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/scoped_account_consistency.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/signin/scoped_account_consistency.h
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/components/signin/core/browser/about_signin_internals.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/components/signin/core/browser/account_consistency_method.h
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/components/signin/core/browser/account_reconcilor_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/components/signin/core/browser/dice_account_reconcilor_delegate.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/components/signin/core/browser/dice_account_reconcilor_delegate_unittest.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/components/signin/core/browser/dice_header_helper.cc
[modify] https://crrev.com/153707e1531f4233168575401a73ad4568ab5caa/components/signin/core/browser/signin_header_helper_unittest.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50ace3cf29e41b2c65aa1800b085c08a43409b48

commit 50ace3cf29e41b2c65aa1800b085c08a43409b48
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Jan 04 12:02:15 2019

Remove unused class DiceTestTokenServiceObserver

This is a left over of https://crrev.com/c/1355189 ([signin] Delete
DiceFixAuthErrors).

TBR=droger@chromium.org

BUG= 777774

Change-Id: I89b6359df1c8910973ca3bcdc9c9145b89d5d464
Reviewed-on: https://chromium-review.googlesource.com/c/1394666
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#619914}
[modify] https://crrev.com/50ace3cf29e41b2c65aa1800b085c08a43409b48/chrome/browser/signin/dice_response_handler_unittest.cc
►

Sign in to add a comment