New issue
Advanced search Search tips

Issue 777766 link

Starred by 1 user
Status: Fixed
Owner:
mek@chromium.org
Closed: Dec 2017
Cc:
jbroman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 738794



Sign in to add a comment

MessagePort implementation should not be in dom directory

Project Member Reported by hayato@chromium.org, Oct 24 2017 
This CL [1] introduced {BlinkCloneableMessage,BlinkMessagePortMessage,/BlinkTransferableMessage} files into Source/core/dom, however, it does't seem that these are related to DOM. Rather, that looks an opposite direction of the recent cleanup of Source/core/dom directory.

Please see dom README.md [2] or the sheet [3] for details.

- [1] https://chromium-review.googlesource.com/c/chromium/src/+/600541
- [2] https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/core/dom/README.md
- [3] https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit#gid=0

mek@, it would be nice that if you could move these files out of core/dom directory.

Comment 1 by hayato@chromium.org, Oct 24 2017

Description: Show this description

Comment 2 by hayato@chromium.org, Oct 24 2017

Blocking: 738794

Comment 3 by hayato@chromium.org, Oct 24 2017

Description: Show this description

Comment 4 by mek@chromium.org, Oct 24 2017

Summary: MessagePort implementation should not be in dom directory (was: {BlinkCloneableMessage,BlinkMessagePortMessage,/BlinkTransferableMessage} files shouldn't be put in dom directory)
This is really about the MessagePort implementation itself, rather than these new files that I added, right? And yeah, it definitely makes sense to move all the MessagePort related code to a separate directory.

Comment 5 by mek@chromium.org, Oct 24 2017

Components: Blink>Messaging

Comment 6 by jbroman@chromium.org, Oct 24 2017 

Indeed.

Suggest "core/messaging/" to align with the bug component name.

Comment 7 by hayato@chromium.org, Oct 25 2017 

> This is really about the MessagePort implementation itself, rather than these new files that I added, right? 

Yup, that is not your fault, I think. :)
It looks I was aware that there were MessagePort files in dom directory when I created this sheet [1].

Please feel free to edit the sheet, as you like.

[1] https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit#gid=0
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d44003f5987082a5638b89fd1aa9f2dfb81bc258

commit d44003f5987082a5638b89fd1aa9f2dfb81bc258
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Dec 19 00:12:08 2017

Move MessagePort code from core/dom to core/messaging.

TBR=palmer@chromium.org

Bug:  777766 
Change-Id: I0c9fa4bde65611bd724335810d71709063a07bd3
Reviewed-on: https://chromium-review.googlesource.com/828853
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524873}
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/events/MessageEvent.h
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/exported/WebDOMMessageEvent.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[add] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BUILD.gn
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkCloneableMessage.cpp
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkCloneableMessage.h
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkCloneableMessage.typemap
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkCloneableMessageStructTraits.cpp
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkCloneableMessageStructTraits.h
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkTransferableMessage.cpp
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkTransferableMessage.h
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkTransferableMessage.typemap
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkTransferableMessageStructTraits.cpp
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/BlinkTransferableMessageStructTraits.h
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/MessageChannel.cpp
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/MessageChannel.h
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/MessageChannel.idl
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/MessagePort.cpp
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/MessagePort.h
[rename] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/MessagePort.idl
[add] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/OWNERS
[add] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/messaging/README.md
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/workers/DedicatedWorker.h
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.h
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.h
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.h
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScopeTest.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/webaudio/AudioWorkletMessagingProxy.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessor.cpp
[modify] https://crrev.com/d44003f5987082a5638b89fd1aa9f2dfb81bc258/third_party/WebKit/Source/platform/mojo/blink_typemaps.gni

Comment 9 by mek@chromium.org, Dec 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment