New issue
Advanced search Search tips

Issue 777761 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 738794



Sign in to add a comment

TrustedType shouldn't be put in Source/core/dom

Project Member Reported by hayato@chromium.org, Oct 24 2017

Issue description

This CL [1] introduced Source/core/dom/trustedtypes directory, however, it doesn't seem that TrustedType is related to DOM. Rather, that looks an opposite direction of the recent cleanup of Source/core/dom directory.

Please see dom README.md [2] or the sheet [3] for details.

- [1] https://chromium-review.googlesource.com/c/chromium/src/+/677390
- [2] https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Source/core/dom/README.md
- [3] https://docs.google.com/spreadsheets/d/1OydPU6r8CTj8HC4D9_gVkriJETu1Egcw2RlajYcw3FM/edit#gid=0 for detail.

Mike, it would be nice that if you could move this directory out of core/dom.
 

Comment 1 by hayato@chromium.org, Oct 24 2017

Blocking: 738794

Comment 2 by hayato@chromium.org, Oct 24 2017

Description: Show this description

Comment 3 by hayato@chromium.org, Oct 24 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2429f7cf43028af27e7c4e2768f556296880830

commit d2429f7cf43028af27e7c4e2768f556296880830
Author: Hayato Ito <hayato@chromium.org>
Date: Wed Jun 20 09:46:03 2018

Move trustedtypes from core/dom/trustedtypes to core/trustedtypes

A part of crbug.com/738794. trustedtypes are not related to DOM
Standard.

BUG= 777761 ,738794

Change-Id: I56906a4ca41a3a3318b26cc52579661ed25f3c50
Reviewed-on: https://chromium-review.googlesource.com/1107519
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568777}
[modify] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/dom/BUILD.gn
[modify] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/frame/location.cc
[add] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/BUILD.gn
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_html.cc
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_html.h
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_html.idl
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_script_url.cc
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_script_url.h
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_script_url.idl
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_url.cc
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_url.h
[rename] https://crrev.com/d2429f7cf43028af27e7c4e2768f556296880830/third_party/blink/renderer/core/trustedtypes/trusted_url.idl

Comment 5 by hayato@chromium.org, Jun 20 2018

Owner: hayato@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment