when generting a password in incognito, it's stored in sync, but no password icon appears in the omnibox |
||||||||||
Issue descriptionChrome Version : 64.0.3241.0 What steps will reproduce the problem? 1. in Incognito, go to accounts.google.com, select "more options" -> "create account" 2. enter some random email address, and generate a password (via context menu) 3. look at omnibox 4. go to chrome://settings/passwords What is the expected result? at 3) there should be a key icon not sure what I expect for 4). If we generate a password, it's reasonable to store it, but maybe we shouldn't generate passwords in incognito?
,
Oct 24 2017
Vadym, what is the plan for generation in Incognito?
,
Oct 24 2017
Generation via context menu is the part of manual fallbacks. Automatic generation doesn't work in Incognito. I think it should be a product decision what to do in Incognito.
,
Oct 24 2017
I think there are two issues here: 1) if we generate, we should show the key icon. 2) does it make sense to generate in incognito via the fallback
,
Oct 24 2017
Saving passwords by prompt is still disabled in Incognito though, isn't it? Since generating implies saving, I'd prefer it to be disabled as well. I understand that manual fallbacks should consistently work and do what the user asks for, but this complicates the answer to the question "Can you save passwords in Incognito?".
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a972ed40c192d1be60872610a5ae7132ce28653f commit a972ed40c192d1be60872610a5ae7132ce28653f Author: Jochen Eisinger <jochen@chromium.org> Date: Tue Oct 24 15:01:38 2017 Don't offer generatig or saving passwords in incognito BUG= 777753 R=melandory@chromium.org,battre@chromium.org Change-Id: Ia00492beb50d81448087331163967b09aa98fea0 Reviewed-on: https://chromium-review.googlesource.com/735158 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#511147} [modify] https://crrev.com/a972ed40c192d1be60872610a5ae7132ce28653f/chrome/browser/renderer_context_menu/render_view_context_menu.cc
,
Oct 24 2017
,
Oct 25 2017
Verified the latest behavior of not to generating or saving passwords in incognito on the latest canary(64.0.3249.0) on Windows-10, Mac OS 10.12.6 and Linux Ubuntu 14.04. Attaching the screen-shot of the behavior before and after fix.
,
Oct 25 2017
I think it's worth merging.
,
Oct 26 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64ec3303bb739967a275bf16f0809f6cca6768f7 commit 64ec3303bb739967a275bf16f0809f6cca6768f7 Author: Jochen Eisinger <jochen@chromium.org> Date: Thu Oct 26 11:31:25 2017 Don't offer generatig or saving passwords in incognito BUG= 777753 R=battre@chromium.org, melandory@chromium.org TBR=jochen@chromium.org (cherry picked from commit a972ed40c192d1be60872610a5ae7132ce28653f) Change-Id: Ia00492beb50d81448087331163967b09aa98fea0 Reviewed-on: https://chromium-review.googlesource.com/735158 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511147} Reviewed-on: https://chromium-review.googlesource.com/738770 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#238} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/64ec3303bb739967a275bf16f0809f6cca6768f7/chrome/browser/renderer_context_menu/render_view_context_menu.cc
,
Nov 1 2017
Verified the merge on 63.0.3239.30 on Windows-10, Mac OS 10.12.6 and Linux Ubuntu 14.04. This is working as intended. Hence adding the verified label.
,
Nov 10 2017
Verified on M64 dev build (10115.0.0, 64.0.3264.0). There is no Generate Password option in incognito now. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by vabr@chromium.org
, Oct 24 2017