Official Win MSVC build of cc_unittests failing with warning during the LTCG step |
||
Issue descriptionhttps://build.chromium.org/p/chromium.clang/builders/CrWinClang/builds/323 https://build.chromium.org/p/chromium.clang/builders/CrWinClang64/builds/102 FAILED: cc_unittests.exe cc_unittests.exe.pdb cmd /c C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py delete-file ./cc_unittests.exe.pdb && C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False link.exe /nologo /OUT:./cc_unittests.exe /PDB:./cc_unittests.exe.pdb @./cc_unittests.exe.rsp c:\b\c\b\win_clang\src\cc\scheduler\scheduler_unittest.cc(268) : error C2220: warning treated as error - no 'executable' file generated c:\b\c\b\win_clang\src\cc\scheduler\scheduler_unittest.cc(268) : warning C4723: potential divide by 0 LINK : fatal error LNK1257: code generation failed Presumably the trybots didn't catch this because LTCG is only used in official builds.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54277e5bf5a0b529b67490e90049925d70227f28 commit 54277e5bf5a0b529b67490e90049925d70227f28 Author: Hans Wennborg <hans@chromium.org> Date: Tue Oct 24 08:19:08 2017 Fix MSVC link-time code gen warning from building cc_unittests It was failing like so: c:\b\c\b\win_clang\src\cc\scheduler\scheduler_unittest.cc(268): error C2220: warning treated as error - no 'executable' file generated c:\b\c\b\win_clang\src\cc\scheduler\scheduler_unittest.cc(268): warning C4723: potential divide by 0 LINK : fatal error LNK1257: code generation failed TBR=enne Bug: 777752 Change-Id: I65c3d95217429ff3aa03ffc44c8f3d4d1248d919 Reviewed-on: https://chromium-review.googlesource.com/735081 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#511058} [modify] https://crrev.com/54277e5bf5a0b529b67490e90049925d70227f28/cc/scheduler/scheduler_unittest.cc
,
Oct 24 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by h...@chromium.org
, Oct 24 2017