New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777730 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cherry-picking Chrome CWP experiment to R63

Project Member Reported by laszio@chromium.org, Oct 24 2017

Issue description

These experiments were designed for R63, however, due to several issues they were blocked for more than 2 weeks.

We need to cherry-pick the CLs to R63:
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/731678
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/710457

I'll prepare two clean CLs, rather than cherry-picking on gerrit because rebasing chrome ebuild and chromite is a little tricky.
 

Comment 1 by laszio@chromium.org, Oct 24 2017

Labels: Merge-Request-63

Comment 2 by laszio@chromium.org, Oct 24 2017

Cc: gkihumba@chromium.org josa...@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 25 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6fd507f804decbfb513f7b8d0b2755d3a8fc1dda

commit 6fd507f804decbfb513f7b8d0b2755d3a8fc1dda
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Oct 25 19:08:21 2017

chrome: update experimental autofdo profiles

where exp1 comes from R62 CWP and exp2 from the new benchmark set.

BUG=b:37251947,  chromium:777730 
TEST=USE="afdo_chrome_exp1" emerge-* chromeos-chrome

Change-Id: I56e88dd864b7c69e1e85d01f4a0b07f49df81128
Reviewed-on: https://chromium-review.googlesource.com/735206
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/6fd507f804decbfb513f7b8d0b2755d3a8fc1dda/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9c25c28131d3ed29a33be6538e969d9ab21f42a0

commit 9c25c28131d3ed29a33be6538e969d9ab21f42a0
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Oct 25 19:08:23 2017

autofdo: try new profiles on falco and peppy when building Chrome

The profiles are from CWP and the new benchmark set.

BUG=b:37251947,  chromium:777730 
TEST=cros tryjob {falco,peppy}-release

Change-Id: I2456d94e8779d056118d8125fbb38d3882e76b19
Reviewed-on: https://chromium-review.googlesource.com/735205
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/9c25c28131d3ed29a33be6538e969d9ab21f42a0/cbuildbot/config_dump.json
[modify] https://crrev.com/9c25c28131d3ed29a33be6538e969d9ab21f42a0/cbuildbot/chromeos_config.py

Comment 6 by laszio@chromium.org, Oct 27 2017

Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 30 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 2 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4eab301c8a6edad0f58b7d3bbeb6fd63824aee97

commit 4eab301c8a6edad0f58b7d3bbeb6fd63824aee97
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sat Nov 04 04:56:52 2017

chrome: update experimental autofdo profiles to 3239.20

BUG=b:37251947,  chromium:777730 
TEST=USE="afdo_chrome_exp1" emerge-* chromeos-chrome

Change-Id: I074265437cb92ac162ed9de5427dd87bad6c322f
Reviewed-on: https://chromium-review.googlesource.com/754122
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4eab301c8a6edad0f58b7d3bbeb6fd63824aee97/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/4eab301c8a6edad0f58b7d3bbeb6fd63824aee97/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0174cca1d1110f52acd2a77399108b244a3a89b3

commit 0174cca1d1110f52acd2a77399108b244a3a89b3
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Mon Nov 06 23:33:12 2017

chrome: update experimental autofdo profiles to 3239.20

BUG=b:37251947,  chromium:777730 
TEST=USE="afdo_chrome_exp1" emerge-* chromeos-chrome

Change-Id: Ica0b8c872414840f2a0dd6ae37aab6f83d8e37fa
Reviewed-on: https://chromium-review.googlesource.com/753992
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/0174cca1d1110f52acd2a77399108b244a3a89b3/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/0174cca1d1110f52acd2a77399108b244a3a89b3/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fd92f4beba2f98bd29756a0a64fc922c60c66073

commit fd92f4beba2f98bd29756a0a64fc922c60c66073
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Mon Nov 20 23:43:59 2017

chrome: update experimental autofdo profiles to 3239.42

BUG=b:37251947,  chromium:777730 
TEST=USE=chrome_afdo_exp1 emerge-peppy chromeos-chrome
     cros tryjob falco-release

Change-Id: Ic549960c8db4b124bb0208faaba4198f2e749d28
Reviewed-on: https://chromium-review.googlesource.com/777026
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/fd92f4beba2f98bd29756a0a64fc922c60c66073/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/fd92f4beba2f98bd29756a0a64fc922c60c66073/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a5dabe9e7001432e4f308d92b3764c6ab5fa630f

commit a5dabe9e7001432e4f308d92b3764c6ab5fa630f
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Nov 21 02:13:36 2017

chrome: update experimental autofdo profiles to 3239.42

BUG=b:37251947,  chromium:777730 
TEST=USE=afdo_chrome_exp1 emerge-peppy chromeos-chrome
     cros tryjob falco-release

Change-Id: Iaea8b0f9ad1ca582d8625bd2acf941183fa509fb
Reviewed-on: https://chromium-review.googlesource.com/777199
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/a5dabe9e7001432e4f308d92b3764c6ab5fa630f/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/a5dabe9e7001432e4f308d92b3764c6ab5fa630f/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7eb81de7616298d3e8aee05e2336ed91a4c79218

commit 7eb81de7616298d3e8aee05e2336ed91a4c79218
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Nov 23 00:07:40 2017

Revert "chrome: update experimental autofdo profiles to 3239.42"

This reverts commit fd92f4beba2f98bd29756a0a64fc922c60c66073.

Reason for revert: the CL seemed to cause BuildPackages timeout.

Original change's description:
> chrome: update experimental autofdo profiles to 3239.42
>
> BUG=b:37251947,  chromium:777730 
> TEST=USE=chrome_afdo_exp1 emerge-peppy chromeos-chrome
>      cros tryjob falco-release
>
> Change-Id: Ic549960c8db4b124bb0208faaba4198f2e749d28
> Reviewed-on: https://chromium-review.googlesource.com/777026
> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
> Tested-by: Ting-Yuan Huang <laszio@chromium.org>

BUG=b:37251947,  chromium:777730 
TEST=tryjob
Change-Id: I2af37c68e404d0433d53f8015f65ed41aedbcaec
Reviewed-on: https://chromium-review.googlesource.com/786513
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/7eb81de7616298d3e8aee05e2336ed91a4c79218/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/7eb81de7616298d3e8aee05e2336ed91a4c79218/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a8889de841211103d105d397cd9f94a029227726

commit a8889de841211103d105d397cd9f94a029227726
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sat Nov 25 07:18:48 2017

Revert "chrome: update experimental autofdo profiles to 3239.42"

This reverts commit fd92f4beba2f98bd29756a0a64fc922c60c66073.

Reason for revert: the CL seemed to cause BuildPackages timeout.

Original change's description:
> chrome: update experimental autofdo profiles to 3239.42
>
> BUG=b:37251947,  chromium:777730 
> TEST=USE=chrome_afdo_exp1 emerge-peppy chromeos-chrome
>      cros tryjob falco-release
>
> Change-Id: Ic549960c8db4b124bb0208faaba4198f2e749d28
> Reviewed-on: https://chromium-review.googlesource.com/777026
> Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
> Tested-by: Ting-Yuan Huang <laszio@chromium.org>

BUG=b:37251947,  chromium:777730 ,  chromium:788017 
TEST=USE=afdo_chrome_exp1 emerge-falco chromeos-chrome

Change-Id: I3f31f39fe4ce45c9097f935843c3a53fc21ccf21
Reviewed-on: https://chromium-review.googlesource.com/786826
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/a8889de841211103d105d397cd9f94a029227726/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/a8889de841211103d105d397cd9f94a029227726/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c55298556f70627e7bc4796cd9f76eb3a7639af8

commit c55298556f70627e7bc4796cd9f76eb3a7639af8
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Nov 28 22:23:16 2017

chrome: update experimental autofdo profiles to 3239.50

BUG=b:37251947,  chromium:777730 
TEST=USE=afdo_chrome_exp1 emerge-falco chromeos-chrome
     cros tryjob falco-release

Change-Id: Ida53c74891a1d4e5d98b21b79059ead43e7e105b
Reviewed-on: https://chromium-review.googlesource.com/794391
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/c55298556f70627e7bc4796cd9f76eb3a7639af8/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/c55298556f70627e7bc4796cd9f76eb3a7639af8/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/00028d7ed1536eb5b218ac1836cf69caeeb649e0

commit 00028d7ed1536eb5b218ac1836cf69caeeb649e0
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Nov 29 04:17:04 2017

chrome: update experimental autofdo profiles to 3239.50

BUG=b:37251947,  chromium:777730 
TEST=USE=afdo_chrome_exp1 emerge-falco chromeos-chrome
     cros tryjob falco-release

Change-Id: I6f598859679919c8ea7430204c75b24bf36ad2f0
Reviewed-on: https://chromium-review.googlesource.com/794339
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/00028d7ed1536eb5b218ac1836cf69caeeb649e0/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/00028d7ed1536eb5b218ac1836cf69caeeb649e0/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9d63c093cec72ec2cdaacb90d67a446daaa2b8f7

commit 9d63c093cec72ec2cdaacb90d67a446daaa2b8f7
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Dec 05 19:10:19 2017

chrome: update experimental autofdo profiles to 3239.50-r2

The parameters to generate the profile are fine tuned.

BUG=b:37251947,  chromium:777730 
TEST=USE=afdo_chrome_exp1 emerge-falco chromeos-chrome
     cros tryjob falco-release

Change-Id: Ie65874b533f1acc389c33e387874e5f217b7ca75
Reviewed-on: https://chromium-review.googlesource.com/807424
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/9d63c093cec72ec2cdaacb90d67a446daaa2b8f7/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/9d63c093cec72ec2cdaacb90d67a446daaa2b8f7/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ea50ba01ae1d24ce2db5ca72445fcbde8ca6ab72

commit ea50ba01ae1d24ce2db5ca72445fcbde8ca6ab72
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Dec 06 08:03:49 2017

chrome: update experimental autofdo profiles to 3239.50-r2

The parameters to generate the profile are fine tuned.

BUG=b:37251947,  chromium:777730 
TEST=USE=afdo_chrome_exp1 emerge-falco chromeos-chrome
     cros tryjob falco-release

Change-Id: I21df3d4f5afea84dd3db849d1aa7196f0007d2ab
Reviewed-on: https://chromium-review.googlesource.com/809537
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/ea50ba01ae1d24ce2db5ca72445fcbde8ca6ab72/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/ea50ba01ae1d24ce2db5ca72445fcbde8ca6ab72/chromeos-base/chromeos-chrome/Manifest

Labels: -Merge-Approved-63
Status: Verified (was: Fixed)
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 16 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/233ed2b6fe5abb94694577715c9656904cbe86d7

commit 233ed2b6fe5abb94694577715c9656904cbe86d7
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Jan 16 19:15:10 2018

chrome: update experimental autofdo profiles to 3282.41

BUG=b:37251947,  chromium:777730 
TEST=cros tryjob falco-release

Change-Id: I70d6e172f2f3bed79fbe6cd7467721f3683fd4b1
Reviewed-on: https://chromium-review.googlesource.com/865517
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/233ed2b6fe5abb94694577715c9656904cbe86d7/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/233ed2b6fe5abb94694577715c9656904cbe86d7/chromeos-base/chromeos-chrome/Manifest

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 31 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bf4c888d0fab140f5c7053c32d300e21b0bfdadd

commit bf4c888d0fab140f5c7053c32d300e21b0bfdadd
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Wed Jan 31 19:39:50 2018

chrome: update experimental autofdo profiles to 3299.0

This is a continuation of an experiment from R64, in which
we tried to optimize Chrome with CWP.

See bugs below for more details.

BUG=b:37251947,  chromium:777730 
TEST=cros tryjob falco-release
     USE=afdo_chrome_exp1 emerge-kip chromeos-chrome

Change-Id: Ic3e4b90790ebe747ec7a9c5fe0fa5421de3ac96f
Reviewed-on: https://chromium-review.googlesource.com/890347
Reviewed-by: Ting-Yuan Huang <laszio@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/bf4c888d0fab140f5c7053c32d300e21b0bfdadd/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/bf4c888d0fab140f5c7053c32d300e21b0bfdadd/chromeos-base/chromeos-chrome/Manifest

Sign in to add a comment