Replace unibuild logic in chromeos-ec with something simpler |
|||
Issue descriptionWe have decided that the master configuration can be different between ToT and a branch. This allows us to simplify the chromeos-ec ebuild. To do: - Update reef master config on ToT so that it does not build - Do nothing with firmware branch: for now it has separate builders so is WAI. Before we turn down those builds we will need to do more work - Use cros_config_host_py get-firmware-build-targets ec - Add 'cros_config_host_py get-firmware-build-targets cr50' to handle that - Simplify chromeos-ec build to remove additional checks
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4b224417307a2f52c17760ec65e58b7f2cac37c6 commit 4b224417307a2f52c17760ec65e58b7f2cac37c6 Author: Simon Glass <sjg@chromium.org> Date: Wed Nov 01 18:26:01 2017 chromeos-ec: Simplify the ebuild for unibuild This is currently quite complicated because we cannot rely on the master configuration to tell us what to do. We're going to fix that, which allows the ebuild to be simplified. Update the ebuild to use cros_config_host_py and do exactly what it is told. BUG= chromium:777726 TEST=emerge-reef-uni chromeos-ec emerge-coral chromeos-ec See that it builds the expected targets Change-Id: I8b87df8a3cfe095b3f16084479646e9eec730633 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/733090 Reviewed-by: Randall Spangler <rspangler@chromium.org> [modify] https://crrev.com/4b224417307a2f52c17760ec65e58b7f2cac37c6/eclass/cros-ec-board.eclass [modify] https://crrev.com/4b224417307a2f52c17760ec65e58b7f2cac37c6/chromeos-base/chromeos-ec/chromeos-ec-9999.ebuild
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/91773c6fad5b7473f3444661cac7459b9b426bc4 commit 91773c6fad5b7473f3444661cac7459b9b426bc4 Author: Simon Glass <sjg@chromium.org> Date: Wed Nov 01 23:47:19 2017 coreboot: Simplify the ebuild for unibuild This is currently quite complicated because we cannot rely on the master configuration to tell us what to do. We're going to fix that, which allows the ebuild to be simplified. Update the ebuild to use cros_config_host_py and do exactly what it is told. BUG= chromium:777726 TEST=emerge-reef-uni coreboot chromeos-bootimage See that it builds the expected target Change-Id: I450a8632ac462d33de282936aa98fd8d357293f5 Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/742380 Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/91773c6fad5b7473f3444661cac7459b9b426bc4/sys-boot/coreboot/coreboot-9999.ebuild
,
Nov 4 2017
,
Nov 6 2017
It is back to being simple now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 29 2017