Always use cl.exe for CrWinGoma(clbr) |
||
Issue descriptionCurrently, goma canary builders are following the default compilers (except CrWinClangGoma, which uses clang always). However, these days default compiler is often switching. When the default compiler is clang, there will not be any cl.exe builder in goma canary builders. I'd like to convert CrWinGoma(clbr) to CrWinClexeGoma, which always uses cl.exe. CrWinClangGoma is actually a clobber builder, so converting clobber builder is natural. Ok to follow the default compilers for the other CrWinGoma builders.
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ea3d65e56d99e61c1edfa8061293cbd0198edc06 commit ea3d65e56d99e61c1edfa8061293cbd0198edc06 Author: Shinya Kawanaka <shinyak@google.com> Date: Tue Oct 31 02:42:25 2017 Convert CrWin7Goma(clbr) to CrWinClexeGoma These days chromium default compiler is switching. Since we have assumed the default compiler for Win was cl.exe, when the default compiler is clang-cl.exe, we don't have any cl.exe builder. I'd like to keep one cl.exe builder. So, let me convert CrWin7Goma(clbr) to CrWinClexeGoma, which does clobber build with cl.exe. Since we have CrWinClangGoma, which also does clobber build with clang-cl.exe, having CrWinClexeGoma is balanced well. Bug: 777705 Change-Id: I2f96b57a626c866f1628034ab758881133baeba1 Reviewed-on: https://chromium-review.googlesource.com/735260 Reviewed-by: Takuto Ikuta <tikuta@google.com> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> [modify] https://crrev.com/ea3d65e56d99e61c1edfa8061293cbd0198edc06/masters/master.chromium.fyi/master.cfg [modify] https://crrev.com/ea3d65e56d99e61c1edfa8061293cbd0198edc06/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py [modify] https://crrev.com/ea3d65e56d99e61c1edfa8061293cbd0198edc06/masters/master.chromium.fyi/slaves.cfg
,
Nov 6 2017
I'd like to add the similar config builder to goma staging.
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01bd16be13ee7fc484ba200dbed7ba089ccfe13e commit 01bd16be13ee7fc484ba200dbed7ba089ccfe13e Author: shinyak <shinyak@chromium.org> Date: Wed Nov 08 02:20:17 2017 Add CrWinClexeGomaGCEStaging Since chromium's default compiler is switching, currently we don't have any builder that always uses cl.exe on goma staging builders. We have fixed it for goma canary builders in rev 3b4c0299, however, we'd like to fix goma staging builders, too. I'll convert CrWinGomaGCEStaging to CrWinClexeGomaGCEStaging. So, let me add a config for CrWinClexeGomaGCEStaging. Bug: 777705 Change-Id: Id65bd8ab5f6a6992658bb757231a8f032e3e9df4 Reviewed-on: https://chromium-review.googlesource.com/753203 Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#514712} [modify] https://crrev.com/01bd16be13ee7fc484ba200dbed7ba089ccfe13e/testing/buildbot/chromium.goma.json [modify] https://crrev.com/01bd16be13ee7fc484ba200dbed7ba089ccfe13e/tools/mb/mb_config.pyl
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/476157fc18c94a9c2b9ed3925f412ad8cbc1f3ef commit 476157fc18c94a9c2b9ed3925f412ad8cbc1f3ef Author: Shinya Kawanaka <shinyak@google.com> Date: Wed Nov 08 05:46:52 2017 Convert CrWinGomaGCEStaging to CrWinClexeGomaGCEStaging These days chromium default compiler is switching, so currently goma staging server have 2 clang-cl builders but no cl.exe builder. Convert CrWinGomaGCEStaging to CrWinClexeGomaGCEStaging, so that it uses cl.exe always. Then we can test cl.exe on goma staging builders. Bug: 777705 Change-Id: Icc44ba410b9eee47fd2153c9d9bcd0eece93f662 Reviewed-on: https://chromium-review.googlesource.com/758138 Reviewed-by: Takuto Ikuta <tikuta@google.com> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> [modify] https://crrev.com/476157fc18c94a9c2b9ed3925f412ad8cbc1f3ef/masters/master.chromium.goma/builders.pyl
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/8f236fdaab9db54aa68781049dbb7074c362d2f1 commit 8f236fdaab9db54aa68781049dbb7074c362d2f1 Author: Shinya Kawanaka <shinyak@google.com> Date: Wed Nov 08 07:04:02 2017 Convert CrWinGomaGCEStaging to CrWinClexeGomaGCEStaging (follow-up) This is a follow-up patch for revision 476157f. Currently CrWinClexeGomaGCEStaging builder is failing with exception. I should have updated chromium_goma.py, too. Bug: 777705 Change-Id: I979d848411bf5d425cbd42d52cac16037006c53d Reviewed-on: https://chromium-review.googlesource.com/758296 Reviewed-by: Takuto Ikuta <tikuta@google.com> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> [modify] https://crrev.com/8f236fdaab9db54aa68781049dbb7074c362d2f1/scripts/slave/recipe_modules/chromium_tests/chromium_goma.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0379942f5c95ee753e50094ba132a53663e632e0 commit 0379942f5c95ee753e50094ba132a53663e632e0 Author: shinyak <shinyak@chromium.org> Date: Fri Nov 10 02:48:07 2017 Clean up mb_config.pyl for goma builders I've converted CrWinGomaGCEStaging to CrWinClexeGomaGCEStaging, and CrWin7Goma(clbr) to CrWinClexeGoma. So, CrWinGomaGCEStaging and CrWin7Goma(clbr) are not necessary any more. Let me remove them. Bug: 777705 Change-Id: Icf23e23d01a4d1f7c4d0f96d0fef99aa5f4680c6 Reviewed-on: https://chromium-review.googlesource.com/760099 Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#515429} [modify] https://crrev.com/0379942f5c95ee753e50094ba132a53663e632e0/tools/mb/mb_config.pyl
,
Nov 10 2017
clean up is done. Closing |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 30 2017