New issue
Advanced search Search tips

Issue 777677 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add default/cached network quality samples in the network quality estimator's constructor

Project Member Reported by tbansal@chromium.org, Oct 24 2017 
Currently, Network Quality Estimator (NQE) adds default/cached network quality samples when a connection type change notification is received. This notification is typically received on Chromium immediately after startup, but may not be received for Cronet embedders. For such embedders, default/cached network quality samples would not be added to the NQE's observation buffers.

To fix this, NQE should add the default/cached network quality samples in the NQE's constructor.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdded3566babd0e9a39ad4c73629bc4311f6a39d

commit fdded3566babd0e9a39ad4c73629bc4311f6a39d
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Oct 24 22:59:57 2017

Add default platform observation and cached estimate in
the network quality constructor

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
TBR: nasko@chromium.org
Bug:  777677 
Change-Id: I692ce5a3d63d4fce24fc75bb01210e26aff78688
Reviewed-on: https://chromium-review.googlesource.com/734582
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511293}
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/content/browser/net_info_browsertest.cc
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_qualities_prefs_manager_unittest.cc
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_quality_estimator_params.h
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/fdded3566babd0e9a39ad4c73629bc4311f6a39d/net/nqe/network_quality_estimator_unittest.cc

Comment 2 by tbansal@chromium.org, Oct 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment