New issue
Advanced search Search tips

Issue 777676 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Socket watcher should discard first RTT notification from the QUIC connection

Project Member Reported by tbansal@chromium.org, Oct 24 2017 
QUIC connection may push an RTT observation of 100msec to network quality estimator (NQE). Link to the relevant QUIC code: https://cs.chromium.org/chromium/src/net/quic/core/congestion_control/rtt_stats.cc?rcl=27c22fb9647891b15b9624115928d0dacf245743&l=16

This value is hard-coded, and thus does not reflect the actual quality of the network. To avoid computing network quality based on this observation, the socket watcher should should discard the first RTT observation from QUIC connections.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9

commit 6a7df1f45d9b90d8b0bf290d3a358a15206cacc9
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Oct 25 18:15:42 2017

Drop first RTT notification from a QUIC connection

The first RTT notification from a QUIC connection may be
synthetically generated, and may not reflect the actual network
quality.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Bug:  777676 
Change-Id: I678d2c4c1046095defe344f59446038314cc75f6
Reviewed-on: https://chromium-review.googlesource.com/734701
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511519}
[modify] https://crrev.com/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9/net/nqe/socket_watcher.cc
[modify] https://crrev.com/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9/net/nqe/socket_watcher.h
[modify] https://crrev.com/6a7df1f45d9b90d8b0bf290d3a358a15206cacc9/net/nqe/socket_watcher_unittest.cc

Comment 2 by tbansal@chromium.org, Oct 25 2017

Status: Fixed (was: Started)
►

Sign in to add a comment