New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777667 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Status tray network status display is broken in myltibyte languages.

Project Member Reported by alemate@chromium.org, Oct 24 2017

Issue description

Latest M63 build on kevin.

Set system language to any multibyte.
Open network status from the system tray.
Observe broken UTF-8 display.

See attached screenshot for example.
(This doesn't happen for M62 for some reason.)
 
Screenshot 2017-10-23 at 17.46.37.1.png
220 KB View Download
Components: UI>Settings UI>Localization
What language were you using for this?
Does this problem occur when logged in?
Does htis problem occur in the Settings UI?

Able to reproduce the issue on Chrome 63.0.3239.17/CrOS 10032.14.0 -Daisy

I checked the issue in Korean/Russian
>> What language were you using for this?

The issue happens when logged in.
Does this problem occur when logged in?

It works fine in the Settings UI.
Does htis problem occur in the Settings UI? 
Yes, I used Russian, but probably all multibyte languages are broken.
Labels: -Type-Bug Type-Bug-Regression
Unable to reproduce the issue on chrome 62.0.3202.67/CrOS 9901.51.0 -Stout
Cc: dschuyler@chromium.org michae...@chromium.org tbarzic@chromium.org
Status: Started (was: Assigned)
It sounds like we may not be loading fonts correctly in Web UI. I will start looking into this today.

To my eye it does not look like fonts issue. If you look carefully at my screenshot, you'll see that every second character is the same. Basically we are displaying double converted UTF-8 string. I.e. take UTF-8 string and run one more ASCII2UTF8() transformation over it.

May be we are supplying UTF-8 encoded string as ASCII to JS code, and second conversion happens automatically. Or, maybe, charset part of Content-Type is not UTF-8.
Yeah, we're not setting up utf8 correctly. Fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/737536
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4678ff108d0b4f0073bfd526cfc99a50e762074

commit f4678ff108d0b4f0073bfd526cfc99a50e762074
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Oct 25 23:12:34 2017

Network: Dialogs: Fix l10n

When the internet detail and config .html files were converted
to stand-alone dialogs with no extra wrapper the html formatting
was incorrect, causing l10n to fail.

This CL fixes that issue and ads a bit of additional cleanup to how
the dialogs are built, including the removal of an unnecessary call
to DisableContentSecurityPolicy().


Bug:  777667 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If227215fd7d6037672302c3062ddd7234d97c712
Reviewed-on: https://chromium-review.googlesource.com/737536
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511630}
[modify] https://crrev.com/f4678ff108d0b4f0073bfd526cfc99a50e762074/chrome/browser/resources/chromeos/internet_config_dialog.html
[modify] https://crrev.com/f4678ff108d0b4f0073bfd526cfc99a50e762074/chrome/browser/resources/chromeos/internet_detail_dialog.html
[modify] https://crrev.com/f4678ff108d0b4f0073bfd526cfc99a50e762074/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/f4678ff108d0b4f0073bfd526cfc99a50e762074/chrome/browser/ui/webui/chromeos/internet_detail_dialog.cc
[modify] https://crrev.com/f4678ff108d0b4f0073bfd526cfc99a50e762074/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.h

Labels: Merge-Request-63
Status: Fixed (was: Started)
Labels: -Merge-Request-63 Merge-Approved-63
Labels: -Merge-Approved-63 Merge-Request-63
Labels: -Merge-Request-63 Merge-Approved-63
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 30 2017

Cc: gkihumba@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 30 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c982e75d25b61431f112f03aabcec86b63243a3c

commit c982e75d25b61431f112f03aabcec86b63243a3c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Oct 30 16:24:58 2017

Network: Dialogs: Fix l10n

When the internet detail and config .html files were converted
to stand-alone dialogs with no extra wrapper the html formatting
was incorrect, causing l10n to fail.

This CL fixes that issue and ads a bit of additional cleanup to how
the dialogs are built, including the removal of an unnecessary call
to DisableContentSecurityPolicy().

TBR=stevenjb@chromium.org

(cherry picked from commit f4678ff108d0b4f0073bfd526cfc99a50e762074)

Bug:  777667 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If227215fd7d6037672302c3062ddd7234d97c712
Reviewed-on: https://chromium-review.googlesource.com/737536
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511630}
Reviewed-on: https://chromium-review.googlesource.com/744103
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#289}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/c982e75d25b61431f112f03aabcec86b63243a3c/chrome/browser/resources/chromeos/internet_config_dialog.html
[modify] https://crrev.com/c982e75d25b61431f112f03aabcec86b63243a3c/chrome/browser/resources/chromeos/internet_detail_dialog.html
[modify] https://crrev.com/c982e75d25b61431f112f03aabcec86b63243a3c/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/c982e75d25b61431f112f03aabcec86b63243a3c/chrome/browser/ui/webui/chromeos/internet_detail_dialog_ui.cc

Status: Verified (was: Fixed)
Verified on M64 dev build (10109.0.0, 64.0.3261.0).

Sign in to add a comment