New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777664 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-17
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 575762



Sign in to add a comment

Consolidating all dromaeo benchmarks into one

Project Member Reported by nedngu...@google.com, Oct 24 2017

Issue description

To make it easier for speed-ops@ team to manage benchmarks, we would want to merge benchmarks whenever possible.

I notice that dromaeo.* benchmarks should be mergeable into a single benchmark. 

dromaeo@ benchmark owners: do you still need this benchmark? If yes, can any of you own this work?
 
Cc: ashleymarie@chromium.org
+Ashley who probably might want to review this work.
Cc: lfg@chromium.org
Owner: ashleymarie@chromium.org
Status: Started (was: Untriaged)
THe only things left are:
1) Schedule dromaeo on perf waterfall (this benchmark takes 2m 33s)
2) Enable monitoring
3) Wait 3 days after (2) then remove all the dromaeo.*

Ashley: can you help me with (1)?
Owner: nedngu...@google.com
Ashley explained me how to do (1), so I will do it myself.
Owner: sullivan@chromium.org
Annie: I want to set up monitoring on the "dromaeo" benchmark (step 2 in #4). Can you help triage this?
Owner: nedngu...@google.com
I just did step (2). Reasigning to Ned. If you need more dashboard help (migration, deleting old data) please reassign to Simon if I am out.
dromaeo benchmark is up and running here: https://chromeperf.appspot.com/report?sid=cec8aad9cfe66aaa61421ef4395e2e16fa2f05352a44378a2b9589abd7f2b425

I will remove dromaeo.* by the end of this week 
NextAction: 2017-11-17
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/177b8e6b81c434a2c5fc55f3286348d892e91500

commit 177b8e6b81c434a2c5fc55f3286348d892e91500
Author: nednguyen <nednguyen@google.com>
Date: Fri Nov 17 03:01:25 2017

Remove dromaeo.* benchmarks from perf waterfall


We now have overlapping data: https://chromeperf.appspot.com/report?sid=9f295d22e6e471ddb12191a1cc59b12e5d8c0e29660595a3c72d3bb31989dd86

So it should be safe to remove all these legacy dromaeo benchmarks

Bug:  777664 
Change-Id: I2d1d56ac2b59ec701475641f6b5cbd7875cd0246
Reviewed-on: https://chromium-review.googlesource.com/775587
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#517264}
[modify] https://crrev.com/177b8e6b81c434a2c5fc55f3286348d892e91500/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/177b8e6b81c434a2c5fc55f3286348d892e91500/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/177b8e6b81c434a2c5fc55f3286348d892e91500/tools/perf/benchmark.csv
[modify] https://crrev.com/177b8e6b81c434a2c5fc55f3286348d892e91500/tools/perf/benchmarks/dromaeo.py

The NextAction date has arrived: 2017-11-17
Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/321b152fff38f1cfae8918c6970de96d269755fd

commit 321b152fff38f1cfae8918c6970de96d269755fd
Author: Kuo-Hsin Yang <vovoy@chromium.org>
Date: Thu Aug 02 15:22:12 2018

Cleanup dromaeo benchmark

Remove unused base class and json files.

Bug:  chromium:777664 
Change-Id: I06323e435e2acb9b471a2e733f80dae92f4d94ce
Reviewed-on: https://chromium-review.googlesource.com/1160129
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#580185}
[modify] https://crrev.com/321b152fff38f1cfae8918c6970de96d269755fd/tools/perf/benchmarks/dromaeo.py
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.cssqueryjquery.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.domcoreattr.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.domcoremodify.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.domcorequery.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.domcoretraverse.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibattrjquery.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibattrprototype.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibeventjquery.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibeventprototype.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibmodifyjquery.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibmodifyprototype.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibstylejquery.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibstyleprototype.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibtraversejquery.json
[delete] https://crrev.com/a2c7b5b9e8890b89397692007ff26e42784c3acf/tools/perf/page_sets/data/dromaeo.jslibtraverseprototype.json

Sign in to add a comment