New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777659 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 769391



Sign in to add a comment

Make MediaFoundationVideoEncodeAccelerator work on Windows 7

Project Member Reported by zijiehe@chromium.org, Oct 24 2017

Issue description

Media Foundation transform is supported by Windows 7, but some attributes are not. So we would like to modify MediaFoundationVideoEncodeAccelerator to support a "compatible mode". The required changes include,
1. A flag in GpuPreference to enable / disable the "compatible mode".
2. Do not check OS version if "compatible mode" is on.
3. Do not return false when "compatible mode" is on and setting unsupported attributes returns false.
 
Blocking: 769391
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c95cf145da41a07ed8cf8eee46b32d0a92f90818

commit c95cf145da41a07ed8cf8eee46b32d0a92f90818
Author: Zijie He <zijiehe@chromium.org>
Date: Wed Oct 25 18:43:33 2017

Respect compatible_with_win7_ flag in MediaFoundationVideoEncodeAccelerator

This change loosens the restrictions in MediaFoundationVideoEncodeAccelerator
if |compatible_with_win7_| flag is true. On Windows 7, some attributes /
properites are not supported, so instead of returning false, the return value of
these function calls are ignored.

After this change, H264 can be used by CRD on Windows 7.

Bug: chromium:769391,  chromium:777659 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1ee8d496669fec834b4468f8ea0051d64729049
Reviewed-on: https://chromium-review.googlesource.com/736781
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511535}
[modify] https://crrev.com/c95cf145da41a07ed8cf8eee46b32d0a92f90818/media/gpu/media_foundation_video_encode_accelerator_win.cc
[modify] https://crrev.com/c95cf145da41a07ed8cf8eee46b32d0a92f90818/remoting/codec/webrtc_video_encoder_gpu.cc

Status: Fixed (was: Started)
New flag GpuPreference.enable_media_foundation_vea_on_windows7 is added, and it works well on Windows 7.

Sign in to add a comment