New issue
Advanced search Search tips

Issue 777656 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a |public_key| parameter to the CrxInstaller::Install function.

Project Member Reported by sorin@chromium.org, Oct 24 2017

Issue description

This is a mechanical change for the component updater.

The extension updater needs the public key of the CRX extension for its installer to write it in the extension manifest, when the CRX extension is installed.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea5534e98ebb2312cf99e2102f37c5027697cca7

commit ea5534e98ebb2312cf99e2102f37c5027697cca7
Author: Sorin Jianu <sorin@chromium.org>
Date: Fri Oct 27 01:40:28 2017

Add a |public_key| parameter to the CrxInstaller::Install function.

This is a mechanical change for the component updater.

The extension updater needs the public key of the CRX extension for its
installer to write it in the extension manifest, when the CRX
extension is installed.


Bug:  777656 
Change-Id: I8243b64c61888fa11dba81d2664003a2c57e8b16
Reviewed-on: https://chromium-review.googlesource.com/734199
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512058}
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/component_updater/component_installer.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/component_updater/component_installer.h
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/component_updater/component_installer_unittest.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/component_updater/component_updater_service_unittest.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/update_client/component.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/update_client/test_installer.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/update_client/test_installer.h
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/update_client/update_client.h
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/extensions/browser/updater/update_install_shim.cc
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/extensions/browser/updater/update_install_shim.h
[modify] https://crrev.com/ea5534e98ebb2312cf99e2102f37c5027697cca7/extensions/browser/updater/update_service_unittest.cc

Comment 2 by sorin@chromium.org, Nov 1 2017

Status: Fixed (was: Started)

Sign in to add a comment