Top of settings window trimmed in overview mode. |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Ensure auto hide title bars in tablet mode is on. (2) Enter tablet mode. (3) Open settings in a window. Tray -> settings icon. (4) Enter overview. What is the expected result? What happens instead? Top of settings (size of title bar) is trimmed. Seems to not affect chrome apps v1 or v2. Pretty hard to notice, as its 33px trimmed than transformed, but not ideal.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f914a44d05e431c2e43f7ac7a27248bcf494086 commit 3f914a44d05e431c2e43f7ac7a27248bcf494086 Author: Sammie Quon <sammiequon@google.com> Date: Mon Oct 30 17:44:00 2017 tablet mode: Hide selection when dragging in overview and prevent overview window from clipping immersive moded tablet windows. Fixes two of overview mode introduced by tablet mode work. - Do not allow the top of the settings app to get trimmed. - Hide the selection widget while dragging. Test: manual Bug: 777652 Change-Id: I9b8313cbd255378cf51c7919269491e85190f449 Reviewed-on: https://chromium-review.googlesource.com/733728 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#512528} [modify] https://crrev.com/3f914a44d05e431c2e43f7ac7a27248bcf494086/ash/wm/overview/window_grid.cc [modify] https://crrev.com/3f914a44d05e431c2e43f7ac7a27248bcf494086/ash/wm/overview/window_grid.h [modify] https://crrev.com/3f914a44d05e431c2e43f7ac7a27248bcf494086/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/3f914a44d05e431c2e43f7ac7a27248bcf494086/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/3f914a44d05e431c2e43f7ac7a27248bcf494086/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
,
Nov 3 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sammiequon@chromium.org
, Oct 24 2017