Add a second msvc trybot |
||||||||||
Issue descriptionwin_clang / WinClang64 (dbg) currently does release msvc builds. We should cover debug builds too. Might as well fix up the naming while at it. For both CQ and main waterfall. dpranke tells me we should have enough capacity for this.
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/557db5b973a893db57ad8d1ae0bdc1b526a25e90 commit 557db5b973a893db57ad8d1ae0bdc1b526a25e90 Author: Nico Weber <thakis@chromium.org> Date: Wed Nov 01 18:55:02 2017 Add mb configs for win_msvc bots. We want to replace win_clang and WinClang64 (dbg) which currently do release MSVC builds on CQ and main waterfall respectively with win_msvc and win_msvc_dbg / WinMSVC64 and WinMSVC64 (dbg) to 1.) get both release and debug coverage 2.) have less confusing bot names at least on CQ and main waterfall. This adds mb configs for the new bot names. Bug: 777642 , 751220 Change-Id: I79aa4a41554e9961dfc3fdad5922c590bb603d38 Reviewed-on: https://chromium-review.googlesource.com/746535 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513197} [modify] https://crrev.com/557db5b973a893db57ad8d1ae0bdc1b526a25e90/tools/mb/mb_config.pyl
,
Nov 7 2017
Is there someone taking this issue instead of thakis@? There were the case that cl.exe fails to build but clang-cl does not. https://chromium-review.googlesource.com/756295
,
Nov 7 2017
Yes, I'm looking at it. Currently waiting on https://chromium-review.googlesource.com/c/chromium/tools/build/+/746374
,
Nov 9 2017
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98d8f30d3c4e067793290042607af25a81c285cd commit 98d8f30d3c4e067793290042607af25a81c285cd Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Nov 14 01:05:39 2017 Add MB, test configs for new MSVC-based builders. This add two new MSVC-based builders -- and matching trybots -- to ensure that MSVC still works. R=hans@chromium.org BUG= 751220 , 777642 Change-Id: I4864979264852116fddeb8269751b6a5344680a6 Reviewed-on: https://chromium-review.googlesource.com/759740 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#516128} [modify] https://crrev.com/98d8f30d3c4e067793290042607af25a81c285cd/testing/buildbot/chromium.win.json [modify] https://crrev.com/98d8f30d3c4e067793290042607af25a81c285cd/tools/mb/mb_config.pyl
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d commit ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Nov 14 01:32:38 2017 Add MSVC bots to chromium.win, tryserver.chromium.win This CL adds x64 release and debug MSVC bots to chromium.win, so that we can catch any regressions in the visual studio toolchain support. This will helpfully also be done by bots that don't have "clang" in the name :). This also adds matching win-msvc-{dbg,rel} bots to tryserver.chromium.win for the CQ. Note that these bots will do x64 (64-bit) builds, not x86 (32-bit) ones, which is a change from the older default windows naming scheme, but makes them consistent with the other platforms. R=hans@chromium.org BUG= 751220 , 777642 Change-Id: I10083ec6dcb39a17d917750d451e003f2bcad1b9 Reviewed-on: https://chromium-review.googlesource.com/759684 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/scripts/slave/recipe_modules/chromium_tests/chromium_win.py [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/masters/master.chromium.win/master_win_cfg.py [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/scripts/slave/recipe_modules/chromium_tests/trybots.py [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.py [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/masters/master.tryserver.chromium.win/master.cfg [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/masters/master.tryserver.chromium.win/slaves.cfg [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/update_clang.json [modify] https://crrev.com/ca5c40db5aa9381f01e77a34cf6aa602a1da9a7d/masters/master.chromium.win/slaves.cfg
,
Nov 14 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/beeea4f03bf1a130aafed22a742de9f3b0e5e2b6 commit beeea4f03bf1a130aafed22a742de9f3b0e5e2b6 Author: Dirk Pranke <dpranke@google.com> Date: Tue Nov 14 01:38:34 2017
,
Nov 14 2017
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/f2265cfd8270ad7ddd0945b5e69dba47a85dedb6 commit f2265cfd8270ad7ddd0945b5e69dba47a85dedb6 Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Nov 14 02:33:23 2017 Add missing 'chromium' config for new MSVC builders :(. TBR=hans@chromium.org BUG= 751220 , 777642 Change-Id: Id984fa6c594e3a20b8782b4a14e1c49fe49ad718 Reviewed-on: https://chromium-review.googlesource.com/768099 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/f2265cfd8270ad7ddd0945b5e69dba47a85dedb6/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f746d52899a4623b42b3332e3080b27661e7db61 commit f746d52899a4623b42b3332e3080b27661e7db61 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 15 02:35:08 2017 Add win-msvc-{dbg,rel} as 5% experiments in the CQ. win-msvc-rel will replace win_clang; win-msvc-dbg will be a new configuration to catch debug-specific MSVC-specific compile failures. R=hans@chromium.org BUG= 751220 , 777642 Change-Id: Iff9fabfac25aad130e755530f44582230e494ed0 Reviewed-on: https://chromium-review.googlesource.com/768187 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516566} [modify] https://crrev.com/f746d52899a4623b42b3332e3080b27661e7db61/infra/config/cq.cfg
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/419e78b73b1cfdf9cbbc454b374d8996b675051c commit 419e78b73b1cfdf9cbbc454b374d8996b675051c Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 15 02:44:47 2017 Revert "Add win-msvc-{dbg,rel} as 5% experiments in the CQ." This reverts commit f746d52899a4623b42b3332e3080b27661e7db61. Reason for revert: typos in file :(. Original change's description: > Add win-msvc-{dbg,rel} as 5% experiments in the CQ. > > win-msvc-rel will replace win_clang; win-msvc-dbg will be a new > configuration to catch debug-specific MSVC-specific compile failures. > > R=hans@chromium.org > BUG= 751220 , 777642 > > Change-Id: Iff9fabfac25aad130e755530f44582230e494ed0 > Reviewed-on: https://chromium-review.googlesource.com/768187 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516566} TBR=hans@chromium.org,dpranke@chromium.org Change-Id: I83da43d129a81022ca8e90f93391dd94ecbdcc1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 751220 , 777642 Reviewed-on: https://chromium-review.googlesource.com/770610 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516570} [modify] https://crrev.com/419e78b73b1cfdf9cbbc454b374d8996b675051c/infra/config/cq.cfg
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58dfbce9a505484f24fe7f79a1c91f5038bd7c05 commit 58dfbce9a505484f24fe7f79a1c91f5038bd7c05 Author: Dirk Pranke <dpranke@chromium.org> Date: Wed Nov 15 03:49:24 2017 Reland "Add win-msvc-{dbg,rel} as 5% experiments in the CQ." This re-lands #516566 to add win-msvc-{dbg,rel} as 5% experiments in the CQ, with the typo fixed :). Tbr: iannucci@chromium.org Bug: 751220 , 777642 Change-Id: I694fa957e8e2fe518419c5098891047fc3323afd Reviewed-on: https://chromium-review.googlesource.com/770523 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516586} [modify] https://crrev.com/58dfbce9a505484f24fe7f79a1c91f5038bd7c05/infra/config/cq.cfg
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97e5a19825fdb8f50b27f1229b5cf9d9476a2100 commit 97e5a19825fdb8f50b27f1229b5cf9d9476a2100 Author: Dirk Pranke <dpranke@chromium.org> Date: Thu Nov 16 02:36:19 2017 Re-enable win_chromium_compile_dbg_ng, flip win_clang. This re-adds the win_chromium_compile_dbg_ng builder to the CQ for crbug.com/785432, and replaces win_clang with win-msvc-rel in order to be clearer about which bots are which. We still want to add win-msvc-dbg into the CQ as well, but need to wait until we understand our current capacity better. R=jbudorick@chromium.org, hans@chromium.org NOTRY=true BUG=785432, 777642 , 751220 Change-Id: I2405f34ccdc6200fc700877873b3e8c04e67d272 Reviewed-on: https://chromium-review.googlesource.com/773824 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#516964} [modify] https://crrev.com/97e5a19825fdb8f50b27f1229b5cf9d9476a2100/infra/config/cq.cfg
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/449ceedce2207329148e0a132f0c79a46cde3381 commit 449ceedce2207329148e0a132f0c79a46cde3381 Author: Dirk Pranke <dpranke@chromium.org> Date: Mon Dec 18 21:50:40 2017 Bump win-msvc-dbg to 25% CQ but stop compiling all. It looks like the cycle time of this bot is >50 min if we build all (not surprising since we didn't build all when we were using msvc instead of clang in the CQ). This CL drops things to just building chrome, browser_tests, and unit_tests for now, which should hopefully catch the most egregious errors. R=jbudorick@chromium.org BUG= 777642 Change-Id: Ifee1c5f6231fca1dcce210e05bc812f2ee5d5ed0 Reviewed-on: https://chromium-review.googlesource.com/831090 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#524811} [modify] https://crrev.com/449ceedce2207329148e0a132f0c79a46cde3381/infra/config/cq.cfg [modify] https://crrev.com/449ceedce2207329148e0a132f0c79a46cde3381/testing/buildbot/chromium.win.json [modify] https://crrev.com/449ceedce2207329148e0a132f0c79a46cde3381/testing/buildbot/waterfalls.pyl
,
Dec 18 2017
,
Feb 2 2018
CL to bump win-msvc-dbg to 50%: https://crrev.com/c/898350. It's unclear if we'll have enough capacity in the pool to do 100%. It looks like there are ~15 bots that are permanently borked, that we can possibly recover, but we might still have to find more. I've filed bug 808298 to increase the capacity.
,
Feb 2 2018
,
Feb 2 2018
(disclaiming ownership and marking as available in case some other ICC person wants to run this to completion before I get to).
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7f6dd7b52c83657a716177ac5cf0ba953312737 commit a7f6dd7b52c83657a716177ac5cf0ba953312737 Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Feb 06 22:55:30 2018 Bump win-msvc-dbg to 50% experiment and adjust symbol levels. This increases the bot from 25->50% of the load, and since the bots are compile only, turns symbols completely off, which should speed things up. R=jbudorick@chromium.org BUG= 777642 Change-Id: I43505426e665f7ade473db9ed46f172be94c1e5c Reviewed-on: https://chromium-review.googlesource.com/898350 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@google.com> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534821} [modify] https://crrev.com/a7f6dd7b52c83657a716177ac5cf0ba953312737/infra/config/cq.cfg [modify] https://crrev.com/a7f6dd7b52c83657a716177ac5cf0ba953312737/tools/mb/mb_config.pyl
,
Feb 15 2018
Actually, given how long it's taken to get to this point, and that we'll likely be turning down the MSVC builds in the next month or two, is this really worth adding? hans/brucedawson/thakis/wfh@ - thoughts?
,
Feb 15 2018
I suppose we've made it this far without it, and it sounds like there are capacity concerns so maybe it's not worth it.
,
Feb 20 2018
Too late to care now I think. The only thing it would give us would be more ability to find compiler bugs for Microsoft, and ???
,
Feb 20 2018
Okay, I'll WontFix this then. Sorry this dragged out so long :(.
,
Feb 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a00fb2774344bce8fc913e4028a8053baa795739 commit a00fb2774344bce8fc913e4028a8053baa795739 Author: Dirk Pranke <dpranke@chromium.org> Date: Tue Feb 20 22:28:11 2018 Remove win-msvc-dbg from the CQ. We're close enough to turning off MSVC altogether that this doesn't make enough sense any more. R=jbudorick@chromium.org, hans@chromium.org BUG= 777642 Change-Id: I64cdde1cbe777abd58fbdb8ee79e71e2b3e4cce7 Reviewed-on: https://chromium-review.googlesource.com/927456 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537911} [modify] https://crrev.com/a00fb2774344bce8fc913e4028a8053baa795739/infra/config/cq.cfg |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by thakis@chromium.org
, Oct 27 2017