New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777638 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 771573
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cannot drag link if inside element with style of user-select:text

Reported by ne...@fastmail.com, Oct 23 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

Example URL:
(See attached minimal test case)

Steps to reproduce the problem:
1. Open attached minimal test case.
2. Try to drag the link (e.g. to the tab bar to open it in a new tab).

What is the expected behavior?
The link is draggable.

What went wrong?
The link is not draggable, and text is selected instead.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes 61 (stable)

Does this work in other browsers? Yes

Chrome version: 62.0.3202.62  Channel: stable
OS Version: OS X 10.13.0
Flash Version: 

If a parent element has a style of user-select:none, this regression means there is no way to restore selection on a child element without breaking the ability to drag links.
 
testcase.html
304 bytes View Download
Mergedinto: 776799
Status: Duplicate (was: Unconfirmed)

Comment 2 by ne...@fastmail.com, Oct 24 2017

Is there a reason I can't see the status of 776799?
The crbug/776799 has 'restrict-view' since it contains some internal info as repro case. We identified the culprit (https://chromium.googlesource.com/chromium/src/+/656f9b939150e9a40553757cea46d385bcb423d9) and the fix would be landing soon.

Thank you!
Cc: dtapu...@chromium.org
Components: -Blink Blink>Input
Status: Unconfirmed (was: Duplicate)
As far as I can tell I don't think it is the duplicate of the other bug. However, I cannot repro this bug either. I just tested with a M64 (Canary) on mac and I was able to drag the link and a new tab opened with the given example.

manoranjanr@, were you able to repro this problem? Can you share a screen cast?

Comment 5 by ne...@fastmail.com, Oct 24 2017

Hmm, I can't reproduce on v64 Canary either actually. So I guess whatever caused this has already been fixed in either v63 or v64. Sorry for not checking this first.
Cc: susanjuniab@chromium.org pdr@chromium.org
Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable Needs-Triage-M62 hasbisect OS-Linux OS-Windows Pri-1 Type-Bug-Regression
Owner: hu...@vewd.com
Status: Assigned (was: Unconfirmed)
neilj@ Thanks for the feedback.

Able to reproduce the issue on Windows 7, Mac OS 10.12.6 and Ubuntu 14.04 on the latest Stable 62.0.3202.62 and Beta 62.0.3202.62.
Unable to reproduce this issue on latest Canary 64.0.3248.0 and Dev 63.0.3239.9.

Hence providing reverse bisect information.

Reverse Bisect Information:
======================
Good Build : 63.0.3239.9 
Bad Build :  63.0.3239.8 

As both the Good and Bad builds are branch builds, providing the changelog with manual bisect from omahaproxy.

CHANGELOG URL:
==============
https://chromium.googlesource.com/chromium/src/+log/63.0.3239.8..63.0.3239.9?pretty=fuller&n=10000

From the above Changelog, suspecting below change:
Reviewed-on: https://chromium-review.googlesource.com/705234

Adding Reviewer pdr@ in CC list to please check this issue, as owner(hugoh@) is not available till October 31st and this issue is marked as ReleaseBlock-Stable. Please remove the same if it is not applicable.

Thanks!

Comment 7 by pdr@chromium.org, Oct 24 2017

Cc: hu...@vewd.com
Owner: yosin@chromium.org
This should have been fixed by:

Original patch:
"Make links draggable despite 'user-select: text' styling" @r508658
https://chromium-review.googlesource.com/c/chromium/src/+/705234

Merge:
"Make links draggable despite 'user-select: text' styling"
https://chromium-review.googlesource.com/c/chromium/src/+/723284

Do we need to merge this patch to M62, maybe?

Yosin, could you look into this?

Comment 8 by yosin@chromium.org, Oct 25 2017

Labels: -Needs-Triage-M62 Merge-Request-62
Mergedinto: -776799 771573
Status: Duplicate (was: Assigned)
We track this issue by  issue 771573 .
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 25 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
We have been at M62 stable and planning a respin for Thursday. Has this been already tested in Canary? Can you please provide further justification for why this is critical and should be included in M62? 

Comment 11 by yosin@chromium.org, Oct 25 2017

>#c10, good to know. I gave up merge since it is already released...

Here is jadement,
- Tested in M62 Canary
- Tested in M63 Dev, Cnary
- Tested in M64 Canary and ToT
- Changes are small, 22 lines added 5 lines deleted
- It is common operation of dragging link

Thanks for reviewing!

Labels: -Merge-Review-62 Merge-Rejected-62 M-62
Thanks for the fix yosin@. My recommendation is to target this for M63 if this is not too critical. Please re-apply merge-request-62 if you consider this is critical. 

Sign in to add a comment