New issue
Advanced search Search tips

Issue 777631 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 737629



Sign in to add a comment

Serialize typefaces for oop raster

Project Member Reported by enne@chromium.org, Oct 23 2017

Issue description

See: https://docs.google.com/document/d/1vsJsk1zGSagxxBggd8j5G9u0rMzD1NTaQWgEbUabEvY/edit#heading=h.xzi2kl5b59mm

SkTypeface needs to be serialized and fonts created in the gpu process for oop raster.
 
Components: Internals>Compositing
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39d862bce3dd59bb88708fdccc237655146a3d7

commit c39d862bce3dd59bb88708fdccc237655146a3d7
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Mon Nov 06 19:46:32 2017

oop: Implement linux oop fonts support.

This patch enables us to be able to use linux fonts in oop raster mode, with
the exception of webfonts. The changes are summarized below:

- Introduce PaintTypeface, a Paint equivalent of SkTypeface
- Introduce PaintTextBlob, a Paint equivalent of SkTextBlob
- Introduce PaintTextBlobBuilder, a Paint equivalent of SkTextBlobBuilder
- Introduce PaintFont, a Paint equivalent of some of the SkPaint flags
  that deal with fonts.
- Serialize and deserialize drawTextBlobOp
- Update platform/fonts to use PaintTypeface in places that end up being painted
  - Update FontPlatformData to use PaintTypefaces

R=enne@chromium.org
TBR=asvitkine@chromium.org

Bug:  777631 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I02233be5533e753a99d3d7f32eabfeebfa85308a
Reviewed-on: https://chromium-review.googlesource.com/730568
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514210}
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/BUILD.gn
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_canvas.h
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_font.cc
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_font.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_op_reader.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_op_writer.h
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_text_blob.cc
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_text_blob.h
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_text_blob_builder.cc
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_text_blob_builder.h
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_typeface.cc
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/paint_typeface.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/cc/paint/skia_paint_canvas.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/fuchsia/FontPlatformDataFuchsia.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizerTest.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/graphics/paint/PaintFont.h
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/graphics/paint/PaintTextBlob.h
[add] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/graphics/paint/PaintTypeface.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/third_party/WebKit/Source/platform/graphics/test/MockPaintCanvas.h
[modify] https://crrev.com/c39d862bce3dd59bb88708fdccc237655146a3d7/ui/gfx/render_text.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36dc97759af44affed20d4268b77197b74e2c759

commit 36dc97759af44affed20d4268b77197b74e2c759
Author: Scott Violet <sky@chromium.org>
Date: Mon Nov 06 23:22:50 2017

Revert "oop: Implement linux oop fonts support."

This reverts commit c39d862bce3dd59bb88708fdccc237655146a3d7.

Reason for revert: cc_unittests failing on Linux msan test.

https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests

See  http://crbug.com/782001 

Original change's description:
> oop: Implement linux oop fonts support.
> 
> This patch enables us to be able to use linux fonts in oop raster mode, with
> the exception of webfonts. The changes are summarized below:
> 
> - Introduce PaintTypeface, a Paint equivalent of SkTypeface
> - Introduce PaintTextBlob, a Paint equivalent of SkTextBlob
> - Introduce PaintTextBlobBuilder, a Paint equivalent of SkTextBlobBuilder
> - Introduce PaintFont, a Paint equivalent of some of the SkPaint flags
>   that deal with fonts.
> - Serialize and deserialize drawTextBlobOp
> - Update platform/fonts to use PaintTypeface in places that end up being painted
>   - Update FontPlatformData to use PaintTypefaces
> 
> R=​enne@chromium.org
> TBR=asvitkine@chromium.org
> 
> Bug:  777631 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I02233be5533e753a99d3d7f32eabfeebfa85308a
> Reviewed-on: https://chromium-review.googlesource.com/730568
> Commit-Queue: vmpstr <vmpstr@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514210}

TBR=vmpstr@chromium.org,asvitkine@chromium.org,enne@chromium.org,eae@chromium.org,drott@chromium.org,khushalsagar@chromium.org

Change-Id: If8a71dc8883017e5ab4216970dd8115339b36ae5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  777631 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/755628
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514286}
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/BUILD.gn
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_canvas.h
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_font.cc
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_font.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_op_reader.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/paint_op_writer.h
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_text_blob.cc
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_text_blob.h
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_text_blob_builder.cc
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_text_blob_builder.h
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_typeface.cc
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/cc/paint/paint_typeface.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/cc/paint/skia_paint_canvas.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/fuchsia/FontPlatformDataFuchsia.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizerTest.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/third_party/WebKit/Source/platform/graphics/paint/PaintFont.h
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/third_party/WebKit/Source/platform/graphics/paint/PaintTextBlob.h
[delete] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/third_party/WebKit/Source/platform/graphics/paint/PaintTypeface.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/third_party/WebKit/Source/platform/graphics/test/MockPaintCanvas.h
[modify] https://crrev.com/36dc97759af44affed20d4268b77197b74e2c759/ui/gfx/render_text.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95a0613c04d3fa9e16d7dcd92478c58f4e923b59

commit 95a0613c04d3fa9e16d7dcd92478c58f4e923b59
Author: meade_UTC10 <meade@chromium.org>
Date: Tue Nov 07 00:54:29 2017

Revert "oop: Implement linux oop fonts support."

This reverts commit c39d862bce3dd59bb88708fdccc237655146a3d7.

Reason for revert: Suspected of causing failure on Linux ChromiumOS MSan and Linux MSan
https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/5664
https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/4006

Original change's description:
> oop: Implement linux oop fonts support.
> 
> This patch enables us to be able to use linux fonts in oop raster mode, with
> the exception of webfonts. The changes are summarized below:
> 
> - Introduce PaintTypeface, a Paint equivalent of SkTypeface
> - Introduce PaintTextBlob, a Paint equivalent of SkTextBlob
> - Introduce PaintTextBlobBuilder, a Paint equivalent of SkTextBlobBuilder
> - Introduce PaintFont, a Paint equivalent of some of the SkPaint flags
>   that deal with fonts.
> - Serialize and deserialize drawTextBlobOp
> - Update platform/fonts to use PaintTypeface in places that end up being painted
>   - Update FontPlatformData to use PaintTypefaces
> 
> R=​enne@chromium.org
> TBR=asvitkine@chromium.org
> 
> Bug:  777631 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I02233be5533e753a99d3d7f32eabfeebfa85308a
> Reviewed-on: https://chromium-review.googlesource.com/730568
> Commit-Queue: vmpstr <vmpstr@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514210}

TBR=vmpstr@chromium.org,asvitkine@chromium.org,enne@chromium.org,eae@chromium.org,drott@chromium.org,khushalsagar@chromium.org

Change-Id: I7ffd060ac04ebfb8acd29d81cd297de33461e06b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  777631 , 782045
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/756114
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514325}

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06970f10e5aab4e7b49196a335f9fbca1df5fa16

commit 06970f10e5aab4e7b49196a335f9fbca1df5fa16
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Thu Nov 09 02:05:28 2017

Reland "oop: Implement linux oop fonts support."

This patch enables us to be able to use linux fonts in oop raster mode, with
the exception of webfonts. The changes are summarized below:

- Introduce PaintTypeface, a Paint equivalent of SkTypeface
- Introduce PaintTextBlob, a Paint equivalent of SkTextBlob
- Introduce PaintTextBlobBuilder, a Paint equivalent of SkTextBlobBuilder
- Introduce PaintFont, a Paint equivalent of some of the SkPaint flags
  that deal with fonts.
- Serialize and deserialize drawTextBlobOp
- Update platform/fonts to use PaintTypeface in places that end up being painted
  - Update FontPlatformData to use PaintTypefaces

The difference from the initial patch is that we initialize allocated run
buffers in the unittests.

TBR=enne@chromium.org

Bug:  777631 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6a019a993c72938c47ecb3be27bb9a79f5fdc9dc
Reviewed-on: https://chromium-review.googlesource.com/756213
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515060}
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/BUILD.gn
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_canvas.h
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_font.cc
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_font.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_op_reader.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_op_writer.h
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_text_blob.cc
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_text_blob.h
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_text_blob_builder.cc
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_text_blob_builder.h
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_typeface.cc
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/paint_typeface.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/record_paint_canvas.cc
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/record_paint_canvas.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/cc/paint/skia_paint_canvas.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/FontCache.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/FontPlatformData.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/fuchsia/FontPlatformDataFuchsia.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/linux/FontRenderStyle.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/mac/FontPlatformDataMac.mm
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizer.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizerTest.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/fonts/win/FontPlatformDataWin.cpp
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/graphics/paint/PaintFont.h
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/graphics/paint/PaintTextBlob.h
[add] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/graphics/paint/PaintTypeface.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/third_party/WebKit/Source/platform/graphics/test/MockPaintCanvas.h
[modify] https://crrev.com/06970f10e5aab4e7b49196a335f9fbca1df5fa16/ui/gfx/render_text.cc

Comment 6 by enne@chromium.org, Apr 5 2018

Status: Fixed (was: Assigned)

Sign in to add a comment