New issue
Advanced search Search tips

Issue 777625 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve warning message for inlined move constructors

Project Member Reported by dcheng@chromium.org, Oct 23 2017

Issue description

It's not always clear that it's referring to an implicitly generated move ctor. This results in difficult to understand errors such as:
In file included from ../../chrome/browser/task_manager/sampling/task_group.cc:5:                  
In file included from ../../chrome/browser/task_manager/sampling/task_group.h:21:                  
../../chrome/browser/task_manager/sampling/shared_sampler.h:41:10: error: [chromium-style] Complex constructor has an inlined body.
  struct SamplingResult {                                                                          
         ^
1 error generated.

Demo example: https://chromium-review.googlesource.com/c/chromium/src/+/733958
Build command: ninja -C out/Release ../../chrome/browser/task_manager/sampling/task_group.cc^

wez and I were guessing which ctor this was complaining about until we just guessed wildly.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 24

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment