New issue
Advanced search Search tips

Issue 777621 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 792774



Sign in to add a comment

Print preview cleanup: Migrate usages of var to let/const

Project Member Reported by dpa...@chromium.org, Oct 23 2017

Issue description

Only for the files that are not related to print_preview.Component class. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1145490b7858be8ad8da7cface5ec9b6a6786199

commit 1145490b7858be8ad8da7cface5ec9b6a6786199
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Oct 24 01:37:23 2017

Print Preview cleanup: convert search to const and let

Bug:  777621 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a72e81c072552dd6b18a6f328cdb494a0f20be5
Reviewed-on: https://chromium-review.googlesource.com/731837
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510994}
[add] https://crrev.com/1145490b7858be8ad8da7cface5ec9b6a6786199/chrome/browser/resources/print_preview/search/.eslintrc.js
[modify] https://crrev.com/1145490b7858be8ad8da7cface5ec9b6a6786199/chrome/browser/resources/print_preview/search/cloud_destination_list.js
[modify] https://crrev.com/1145490b7858be8ad8da7cface5ec9b6a6786199/chrome/browser/resources/print_preview/search/destination_list.js
[modify] https://crrev.com/1145490b7858be8ad8da7cface5ec9b6a6786199/chrome/browser/resources/print_preview/search/destination_list_item.js
[modify] https://crrev.com/1145490b7858be8ad8da7cface5ec9b6a6786199/chrome/browser/resources/print_preview/search/destination_search.js
[modify] https://crrev.com/1145490b7858be8ad8da7cface5ec9b6a6786199/chrome/browser/resources/print_preview/search/provisional_destination_resolver.js
[add] https://crrev.com/1145490b7858be8ad8da7cface5ec9b6a6786199/chrome/browser/resources/print_preview/settings/.eslintrc.js

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f207b6db7148720c335155fe1a89a276e256af9

commit 5f207b6db7148720c335155fe1a89a276e256af9
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Oct 24 17:27:42 2017

Print Preview cleanup: Convert data/ directory to const and let

Bug:  777621 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idda5ca0b40bae11df2cc4b74b9566ffba41a4240
Reviewed-on: https://chromium-review.googlesource.com/730645
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511192}
[add] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/.eslintrc.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/cloud_parsers.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/destination.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/destination_match.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/document_info.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/local_parsers.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/margins.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/measurement_system.js
[modify] https://crrev.com/5f207b6db7148720c335155fe1a89a276e256af9/chrome/browser/resources/print_preview/data/print_ticket_store.js

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b1e4d7257ec11a68f33673ed1cd3e26184a27f

commit 73b1e4d7257ec11a68f33673ed1cd3e26184a27f
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Oct 25 03:23:54 2017

Print preview cleanup: Finish conversion to const and let

Bug:  777621 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7add28b9882039395050035e09f50833e8084f29
Reviewed-on: https://chromium-review.googlesource.com/737130
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511348}
[rename] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/.eslintrc.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/cloud_print_interface.js
[delete] https://crrev.com/910beb8bacc3c31e0f3f9e66ffa3b8328e30902d/chrome/browser/resources/print_preview/common/.eslintrc.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/component.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/native_layer.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/preview_generator.js
[delete] https://crrev.com/910beb8bacc3c31e0f3f9e66ffa3b8328e30902d/chrome/browser/resources/print_preview/previewarea/.eslintrc.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/print_header.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/print_preview_animations.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/print_preview_focus_manager.js
[modify] https://crrev.com/73b1e4d7257ec11a68f33673ed1cd3e26184a27f/chrome/browser/resources/print_preview/print_preview_utils.js
[delete] https://crrev.com/910beb8bacc3c31e0f3f9e66ffa3b8328e30902d/chrome/browser/resources/print_preview/search/.eslintrc.js
[delete] https://crrev.com/910beb8bacc3c31e0f3f9e66ffa3b8328e30902d/chrome/browser/resources/print_preview/settings/.eslintrc.js

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65af251daaa8610d2161d6904abecd8889d923e3

commit 65af251daaa8610d2161d6904abecd8889d923e3
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Oct 25 23:24:43 2017

Print Preview: Convert tests to const/let

Bug:  777621 
Change-Id: I4c80541c50755d49dd5af1a58ba09c7b6db3455d
Reviewed-on: https://chromium-review.googlesource.com/737667
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511638}
[modify] https://crrev.com/65af251daaa8610d2161d6904abecd8889d923e3/chrome/test/data/webui/print_preview/native_layer_stub.js
[modify] https://crrev.com/65af251daaa8610d2161d6904abecd8889d923e3/chrome/test/data/webui/print_preview/print_preview_tests.js

Status: Fixed (was: Started)
Blocking: 792774

Sign in to add a comment