New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 777618 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Move VideoFrame* out of platform/graphics and into separate directory.

Project Member Reported by lethalantidote@chromium.org, Oct 23 2017

Issue description

Currently, VideoFrameSubmitter and VideoFrameResourceProvider both live in platform/graphics. This doesn't make much sense since these classes represent an isolated check of work dealing solely with the video stack. These files should be moved to their own platform/media directory.
 
Any opinion on what that directory should be called?

Comment 2 by enne@chromium.org, Jan 31 2018

My hope here is that these two classes don't need to live in Blink.  They're used by content/renderer/media and by media/blink.  Is there a common directory that both of these can access that it would make sense to move this code to?
Didn't they have to live in Blink to access the OffscreenSurface stuff? Or has something changed such that dependency is no longer valid? 

Comment 4 by enne@chromium.org, Feb 1 2018

Cc: fsam...@chromium.org junov@chromium.org
OffscreenCanvasProvider isn't really very blink-y either, other than just using a few blink base types.  I could see moving it to some common place that both this media code and offscreen canvas could use.

+junov,fsamuel who might have opinions on where this code should all live.  Do y'all think all of this code should continue to live in Blink? Or maybe should go elsewhere?
Cc: -junov@chromium.org
pinging this to see if there are any opinions
Cc: fs...@chromium.org

Sign in to add a comment