New issue
Advanced search Search tips

Issue 777616 link

Starred by 1 user
Status: Fixed
Owner:
seobrien@chromium.org
Closed: Oct 2017
Cc:
adlr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Touchscreen history not sent in feedback report

Project Member Reported by seobrien@chromium.org, Oct 23 2017 
What steps will reproduce the problem?
(1) Turn on device
(2) Login and use touchscreen
(3) File feedback

What is the expected result?
Feedback report should have touchscreen history

What happens instead?
No history is included in the feedback report

Comment 1 by seobrien@chromium.org, Oct 23 2017 

This is happening on eve, but I've had issues with feedback reports not including feedback reports off and on for months.

After a little digging, it seems that the initialization of the virtual keyboard disables touchscreen logging, but it should only disable logging when the keyboard is active.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a6e915bde07fb8f2c45b8e11db26e88e232e1b

commit a5a6e915bde07fb8f2c45b8e11db26e88e232e1b
Author: Sean O'Brien <seobrien@google.com>
Date: Tue Oct 24 20:36:20 2017

Do not disable touch event logging unnecessarily

Touch event logging is currently disabled whenever the virtual keyboard
is initialized, but it should only be disabled when the keyboard is
shown. This CL makes that change.

Bug:  777616 
Change-Id: Ie479e0b7925119ca83cb68ecc3c91cd46672a58b
Reviewed-on: https://chromium-review.googlesource.com/734217
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Sean O'Brien <seobrien@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511250}
[modify] https://crrev.com/a5a6e915bde07fb8f2c45b8e11db26e88e232e1b/ui/keyboard/keyboard_controller.cc

Comment 3 by seobrien@chromium.org, Oct 26 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment