The experiment using ULP to determine translate target language (go/ulp_chrome_translate) has concluded; it's logic should be cleaned up.
The experiment using ULP to determine translate target language (go/ulp_chrome_translate) has concluded; its logic should be cleaned up.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2 commit 89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2 Author: Michael Martis <martis@chromium.org> Date: Wed Nov 15 08:46:46 2017 Backed out of the (now concluded) ULP translate experiment. Bug: 777611 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4f0d4df1ad6dc54231b25c9af4fc7abd53d6582f Reviewed-on: https://chromium-review.googlesource.com/762692 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#516642} [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/chrome/browser/about_flags.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/chrome/browser/flag_descriptions.h [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/chrome/browser/language/language_model_factory.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/chrome/browser/language/language_model_factory.h [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/components/translate/core/browser/translate_manager.h [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/components/translate/core/browser/translate_manager_unittest.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/components/translate/core/browser/translate_prefs_unittest.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/ios/chrome/browser/language/language_model_factory.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/ios/chrome/browser/language/language_model_factory.h [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/ios/web_view/internal/language/web_view_language_model_factory.cc [modify] https://crrev.com/89a6d468fe6cdcfdb339b6a4e5d8d3625d91e6f2/ios/web_view/internal/language/web_view_language_model_factory.h
Can I mark this as fixed?
Yep - marking as fixed.
Comment 1 by martis@chromium.org
, Oct 23 2017