display rotation menu is always disabled on touch-capable-device |
||||||
Issue descriptionlooks like it's always disabled regardless of whether or not it's in tablet mode. stevenjb@ ,can you look into this?
,
Oct 23 2017
I observed this on ChromeOS dev-channel; is that on the same milestone as Canary, or do we need something merged back?
,
Oct 23 2017
Canary is later, we should merge back if this is in Dev
,
Oct 24 2017
It looks like there was a bad merge then an incorrect merge fix.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b83546e0509a53e5bced7eaaa654252a15c63b9 commit 1b83546e0509a53e5bced7eaaa654252a15c63b9 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Oct 25 18:36:16 2017 Settings: Display: Use isTabletMode to disable orientation Bug: 777587 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f4be9848269fa38d737c3a2c5f9b1a4cfb030d4 Reviewed-on: https://chromium-review.googlesource.com/736021 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#511532} [modify] https://crrev.com/1b83546e0509a53e5bced7eaaa654252a15c63b9/chrome/browser/resources/settings/device_page/display.html
,
Oct 25 2017
,
Oct 25 2017
,
Oct 26 2017
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3644216a46ec82c8b6cd5d2b0b0827c72608963 commit f3644216a46ec82c8b6cd5d2b0b0827c72608963 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Oct 27 23:07:45 2017 Settings: Display: Use isTabletMode to disable orientation TBR=stevenjb@chromium.org (cherry picked from commit 1b83546e0509a53e5bced7eaaa654252a15c63b9) Bug: 777587 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f4be9848269fa38d737c3a2c5f9b1a4cfb030d4 Reviewed-on: https://chromium-review.googlesource.com/736021 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#511532} Reviewed-on: https://chromium-review.googlesource.com/742460 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#279} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/f3644216a46ec82c8b6cd5d2b0b0827c72608963/chrome/browser/resources/settings/device_page/display.html |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by omrilio@chromium.org
, Oct 23 2017