wpt-update-expectations is not fully simplifying platform specifiers since Mac10.13 was added |
|||
Issue descriptionRecent example: https://chromium-review.googlesource.com/c/chromium/src/+/733640/4/third_party/WebKit/LayoutTests/TestExpectations crbug.com/626703 [ Android Linux Mac10.10 Mac10.11 Mac10.12 Retina Win ] external/wpt/acid/acid2/reftest.html [ Failure ] was added, and this should have been simplified away (there should not have been a specifier added). I suspect that this happened after we removed Mac10.9, and something has to be changed/updated.
,
Oct 26 2017
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/679bd7be408869e0be6d24949c0c830d7dcc789c commit 679bd7be408869e0be6d24949c0c830d7dcc789c Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Oct 31 22:38:07 2017 Change specifier simplification to only consider platforms with try bots Bug: 777582 Change-Id: I76bdb88f6e7941ce67c474a9bf600a46bac96896 Reviewed-on: https://chromium-review.googlesource.com/738795 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#512981} [modify] https://crrev.com/679bd7be408869e0be6d24949c0c830d7dcc789c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py [modify] https://crrev.com/679bd7be408869e0be6d24949c0c830d7dcc789c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list_unittest.py [modify] https://crrev.com/679bd7be408869e0be6d24949c0c830d7dcc789c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py [modify] https://crrev.com/679bd7be408869e0be6d24949c0c830d7dcc789c/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py [modify] https://crrev.com/679bd7be408869e0be6d24949c0c830d7dcc789c/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py
,
Nov 4 2017
Looks like this is fixed?
,
Nov 5 2017
Yep, should be! :-) |
|||
►
Sign in to add a comment |
|||
Comment 1 by qyears...@chromium.org
, Oct 23 2017